[PATCH] D63753: [Sema] Instead of rejecting C unions with non-trivial fields, detect attempts to destruct/initialize/copy them.

ahatanak created this revision. ahatanak added reviewers: rjmccall, rsmith. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. This patch diagnoses uses of non-trivial C unions in the following contexts: - function parameters - function returns - variables with automa

[PATCH] D63559: [clang-tidy] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlight.cpp:75 + SemanticSymbolASTCollector Collector(Ctx); + Collector.TraverseAST(Ctx); + return Collector.getSymbols(); jvikstrom wro

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom updated this revision to Diff 206375. jvikstrom added a comment. Made SemanticTokenCollector visible and removed getSemanticHighlights function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63559/new/ https://reviews.llvm.org/D63559 Fil

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5000 EXPECT_TRUE(ImportedOK); } I see now that this test is really not required, the previous test checks the almost same thing in case of `class B` and `NS` (but more test

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom updated this revision to Diff 206376. jvikstrom marked 3 inline comments as done. jvikstrom added a comment. Added header and empty line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63559/new/ https://reviews.llvm.org/D63559 Files: cl

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet updated this revision to Diff 206378. kadircet marked 4 inline comments as done. kadircet added a comment. - Move clang related changes to a different patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/

[PATCH] D63755: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. kadircet added a child revision: D63194: [clangd] Link and initialize target infos. Wraps JSON compilation database with a target and mode adding

[PATCH] D63714: [clangd] Cleanup the duplicated getTokenRange.

hokein updated this revision to Diff 206380. hokein marked an inline comment as done. hokein added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63714/new/ https://reviews.llvm.org/D63714 Files: clang-tools-ex

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

cdevadas created this revision. cdevadas added reviewers: yaxunl, b-sumner. Herald added subscribers: cfe-commits, t-tye, Anastasia, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. Herald added a project: clang. To enable a new implicit kernel argument, increasing the number of argument bytes

r364279 - [ASTImporter] Store import errors for Decls

Author: martong Date: Tue Jun 25 01:00:51 2019 New Revision: 364279 URL: http://llvm.org/viewvc/llvm-project?rev=364279&view=rev Log: [ASTImporter] Store import errors for Decls Summary: We add a new member which is a mapping from the already-imported declarations in the "from" context to the err

[clang-tools-extra] r364280 - [clangd] Cleanup the duplicated getTokenRange.

Author: hokein Date: Tue Jun 25 01:01:46 2019 New Revision: 364280 URL: http://llvm.org/viewvc/llvm-project?rev=364280&view=rev Log: [clangd] Cleanup the duplicated getTokenRange. Summary: Also lift it to SourceCode.h, so that it can be used in other places (semantic code highlighting). Reviewer

[PATCH] D62373: [ASTImporter] Store import errors for Decls

martong marked 2 inline comments as done. martong added a comment. @shafik I've been looking for any lldb regression in our Mac machine, could not find any. Now I am looking at http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ . I don't expect regression because here we changed logic ab

[PATCH] D62373: [ASTImporter] Store import errors for Decls

This revision was automatically updated to reflect the committed changes. Closed by commit rL364279: [ASTImporter] Store import errors for Decls (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D63714: [clangd] Cleanup the duplicated getTokenRange.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364280: [clangd] Cleanup the duplicated getTokenRange. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D63755: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63755/new/ https://reviews.llvm.org/D63755 _

[PATCH] D63194: [clangd] Link and initialize target infos

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:14 #include "clang/Tooling/CompilationDatabase.h" +#include "clang/Tooling/Tooling.h"

[PATCH] D63755: [clang][Tooling] Infer target and mode from argv[0] when using JSONCompilationDatabase

kadircet updated this revision to Diff 206386. kadircet added a comment. Herald added a subscriber: arphaman. - Rename file - Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63755/new/ https://reviews.llvm.org/D63755 Files: clang/binding

[PATCH] D61681: [clangd] A code tweak to expand a macro

ilya-biryukov updated this revision to Diff 206388. ilya-biryukov added a comment. - Rebase - Update some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61681/new/ https://reviews.llvm.org/D61681 Files: clang-tools-extra/clangd/refactor/

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlight.cpp:43 + + unsigned int Len = + clang::Lexer::MeasureTokenLength(D->getLocation(), SM, Ctx.getLangOpts()); we can reuse the getTokenRange() function (in SourceCode.h), you

r364283 - [clangd] Narrow rename to local symbols.

Author: hokein Date: Tue Jun 25 01:43:17 2019 New Revision: 364283 URL: http://llvm.org/viewvc/llvm-project?rev=364283&view=rev Log: [clangd] Narrow rename to local symbols. Summary: Previously, we performed rename for all kinds of symbols (local, global). This patch narrows the scope by only re

[clang-tools-extra] r364283 - [clangd] Narrow rename to local symbols.

Author: hokein Date: Tue Jun 25 01:43:17 2019 New Revision: 364283 URL: http://llvm.org/viewvc/llvm-project?rev=364283&view=rev Log: [clangd] Narrow rename to local symbols. Summary: Previously, we performed rename for all kinds of symbols (local, global). This patch narrows the scope by only re

[PATCH] D63426: [clangd] Narrow rename to local symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364283: [clangd] Narrow rename to local symbols. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D62373: [ASTImporter] Store import errors for Decls

martong added a comment. http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/29310/ is green. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62373/new/ https://reviews.llvm.org/D62373 ___ cfe-commits mailing list

[PATCH] D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers

MyDeveloperDay added a comment. It was more about not having time to pursue it at this time.. I didn't feel I should hog the PR if someone else wanted to take a look. Even though its "Abandoned" it can be brought back at anytime, I don't like to sit on reviews for too long as it doesn't show th

[PATCH] D48680: Add missing visibility annotation for __base

EricWF added a comment. You have an ODR violation. You can't compile one TU with `-fno-rtti -fno-exceptions` and another without. You give the definitions of `__base` different vtables. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48680/new/ https://reviews

[PATCH] D51262: Implement P0553 and P0556

jwakely added a comment. In D51262#1213514 , @mclow.lists wrote: > I should also mention that as a conforming extension, I have implemented the > non-numeric bit operations for `std::byte` I thought there was a DR or proposal to enable that, but I don't

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5000 EXPECT_TRUE(ImportedOK); } balazske wrote: > I see now that this test is really not required, the previous test checks the > a

[clang-tools-extra] r364284 - [clangd] Fix NestedNameSpecifierLoc in SelectionTree

Author: sammccall Date: Tue Jun 25 02:36:09 2019 New Revision: 364284 URL: http://llvm.org/viewvc/llvm-project?rev=364284&view=rev Log: [clangd] Fix NestedNameSpecifierLoc in SelectionTree Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Diff

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightTests.cpp:57 + + checkTokensExists(Tokens, Variables, SemanticHighlightKind::Variable); + checkTokensExists(Tokens, Function, SemanticHighlightKind::Function); hoke

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom updated this revision to Diff 206393. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Changed tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63559/new/ https://reviews.llvm.org/D63559 Files: clang-tools-extr

[PATCH] D63708: [clangd] Fix NestedNameSpecifierLoc in SelectionTree

This revision was automatically updated to reflect the committed changes. Closed by commit rL364284: [clangd] Fix NestedNameSpecifierLoc in SelectionTree (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D63759: [clangd] Don't rename the namespace.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Also fix a small bug -- the extra argument "-xc++" doesn't overwrite the language if the argument is present after the fil

[PATCH] D63759: [clangd] Don't rename the namespace.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:167 + case UnsupportedSymbol: +return "not a supported symbol (e.g. namespace)"; }

[PATCH] D63760: [clangd] Address limitations in SelectionTree:

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - nodes can have special-cased hit ranges including "holes" (FunctionTypeLoc in void foo()) - token conf

[PATCH] D63759: [clangd] Don't rename the namespace.

hokein updated this revision to Diff 206412. hokein marked 3 inline comments as done. hokein added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63759/new/ https://reviews.llvm.org/D63759 Files: clang-tools-ex

[PATCH] D63759: [clangd] Don't rename the namespace.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:137 +// Parsing the .h file as C++ include. +TU.ExtraArgs.push_back("-xobjective-c++-header"); auto AST = TU.build(); sammccall wrote: > (why this change?) f

[PATCH] D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/google/GoogleTidyModule.cpp:41-42 void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override { +CheckFactories.registerCheck( +"google-upgrade-googletest-case"); CheckF

[PATCH] D63763: [clang-tidy] Update documentation for Qt Creator integration.

nik created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63763 Files: clang-tools-extra/docs/clang-tidy/Integrations.rst Index: clang-tools-extra/docs/clang-tidy/Integrations.rs

[PATCH] D63497: Add support for openSUSE RISC-V triple

schwab updated this revision to Diff 206423. schwab added a comment. Herald added subscribers: jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc27, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. Test added Repository: rC Clang CHANGES SINCE LAST ACTION htt

[PATCH] D51262: Implement P0553 and P0556

mclow.lists added a comment. In D51262#1557154 , @jwakely wrote: > In D51262#1213514 , @mclow.lists > wrote: > > > I should also mention that as a conforming extension, I have implemented > > the non-numeric bit o

[PATCH] D63759: [clangd] Don't rename the namespace.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:137 +// Parsing the .h file as C++ include. +TU.ExtraArgs.push_back("-xobjective-c++-header"); auto AST = TU.build(); hokein wrote: > sammccall wrote: > >

[PATCH] D63763: [clang-tidy] Update documentation for Qt Creator integration.

Eugene.Zelenko added a comment. Looks OK for me, but will be good idea to hear other people too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63763/new/ https://reviews.llvm.org/D63763 ___ cfe-commits

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

martong updated this revision to Diff 206429. martong added a comment. - Add FIXMEs - Set error for FromD if it maps to an existing Decl which has an error set - Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62376/new/ https://reviews.llvm

[PATCH] D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:92 + const std::string Input = "void log(int);"; + EXPECT_EQ(Input, test::runCheckOnCode(Input)); +} Would a

[PATCH] D63763: [clang-tidy] Update documentation for Qt Creator integration.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. LGTM, assuming you know what's new in QtCreator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63763/new/ https://reviews.llvm.org/D63763

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Artem had some comments that are not marked as done, but LGTM! Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:157 + /// Conditions we'r

[PATCH] D63763: [clang-tidy] Update documentation for Qt Creator integration.

nik added a comment. In D63763#1557398 , @gribozavr wrote: > LGTM, assuming you know what's new in QtCreator. Sure, I'm involved in Qt Creator development :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

martong updated this revision to Diff 206431. martong added a comment. - Set error for FromD if it maps to an existing Decl which has an error set Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62376/new/ https://reviews.llvm.org/D62376 Files: cl

[PATCH] D63623: [clang-tidy] Add a check on expected return values of posix functions (except posix_openpt) in Android module.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/clang-tidy/checks/android-posix-return.rst:21 + int ret = posix_fadvise(...); + if (ret != 0) ... why not `if

[clang-tools-extra] r364315 - [clang-tidy] Update documentation for Qt Creator integration.

Author: nik Date: Tue Jun 25 06:50:09 2019 New Revision: 364315 URL: http://llvm.org/viewvc/llvm-project?rev=364315&view=rev Log: [clang-tidy] Update documentation for Qt Creator integration. Subscribers: xazax.hun, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D63763

[PATCH] D63763: [clang-tidy] Update documentation for Qt Creator integration.

This revision was automatically updated to reflect the committed changes. Closed by commit rG181f252d5373: [clang-tidy] Update documentation for Qt Creator integration. (authored by nik). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63763/new/ http

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

martong added a reviewer: balazske. martong marked 6 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7830 if (ToD) { +// Already imported (possibly from another TU) and with an error. +if (auto Error = SharedState->getI

[PATCH] D63767: [NFC] Make some ObjectFormatType switches covering

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: sfertile, jasonliu, daltenty. Herald added subscribers: jsji, aheejin. Herald added projects: clang, LLVM. This patch removes the `default` case from some switches on `llvm::Triple::ObjectFormatType`, and cases

[PATCH] D63759: [clangd] Don't rename the namespace.

hokein updated this revision to Diff 206437. hokein marked an inline comment as done. hokein added a comment. Verify the error message in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63759/new/ https://reviews.llvm.org/D63759 Files: c

[PATCH] D63759: [clangd] Don't rename the namespace.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:137 +// Parsing the .h file as C++ include. +TU.ExtraArgs.push_back("-xobjective-c++-header"); auto AST = TU.build(); sammccall wrote: > hokein wrote: > > sa

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

martong marked 7 inline comments as done. martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7867 if (PosF != ImportedFromDecls.end()) { -if (LookupTable) +if (SharedState->getLookupTable()) if (auto *ToND = dyn_cast(ToD)) -

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

martong updated this revision to Diff 206441. martong marked an inline comment as done. martong added a comment. - Encapsulate by adding addDeclToLookup and removeDeclFromLookup to the shared state Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6237

[PATCH] D63760: [clangd] Address limitations in SelectionTree:

kadircet added a comment. Also there were some offline discussions around, handling of "invisible nodes"(e.g, `ExprWithCleanups`) and other types of typelocs like ParenTypeLocs and owner of '=' sign in copy/move assignment constructors Comment at: clangd/Selection.cpp:54 + +

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 206446. nicolas added a comment. - Added tests of instance and static functions - Added tests of parameters with cv qualifiers - Added tests of parameters with attributes - Removed `auto` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ http

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

hokein added a comment. the test looks better now, another round of reviews, most are nits. Comment at: clang-tools-extra/clangd/SemanticHighlight.cpp:19 +class SemanticTokenCollector +: private RecursiveASTVisitor { + friend class RecursiveASTVisitor; nit

[PATCH] D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations

jvikstrom updated this revision to Diff 206450. jvikstrom added a comment. Made SemanticTokenCollector skip Decls not in the main file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63559/new/ https://reviews.llvm.org/D63559 Files: clang-tools-e

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

yaxunl added a comment. can you try compile an empty HIP kernel and see what metadata is generated by backend? If I remember correctly, backend generates kernel arg metadata based on the number of implicit kernel args. It knows how to handle 48 but I am not sure what will happen if it becomes

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas marked an inline comment as done. nicolas added inline comments. Comment at: clang/include/clang/AST/Decl.h:2331 + /// Attempt to compute an informative source range covering the + /// function parameters. This omits the ellipsis of a variadic function. + SourceRange g

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

simon_tatham updated this revision to Diff 206455. simon_tatham added a comment. Rebased this patch to current trunk, and also fixed a test failure by adding `arm_aapcs_vfpcc` to the test functions that use MVE vector types (since we can't support passing vector types in GPRs until we get all th

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, mgorny. Herald added a project: clang. SureYeaah retitled this revision from "dummy variable extraction on a function scope" to "[clangd] dummy variable extrac

[PATCH] D48680: Add missing visibility annotation for __base

pcc added a comment. The same problem occurs whether or not `exe.cpp` is compiled with`-fno-exceptions -fno-rtti`. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48680/new/ https://reviews.llvm.org/D48680 ___ cfe-

[PATCH] D63742: [WebAssembly] Implement Address Sanitizer for Emscripten

sbc100 added inline comments. Comment at: lld/wasm/Writer.cpp:228 + if (WasmSym::GlobalBase) +WasmSym::GlobalBase->setVirtualAddress(Config->GlobalBase); + Surly if emscripten is passing in --global-base it already knows this value? Otherwise lgtm. Perh

[PATCH] D63742: [WebAssembly] Implement Address Sanitizer for Emscripten

sbc100 added a comment. I wonder if we should use the linux/unix convention or `edata` `etext` and `end`? Terrible names obviously but there is precedent. I can't remember why I didn't do that for __data_end and __heap_base. If not, then perhaps this should be called __data_start to match th

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

cdevadas added a comment. Hi Sam, The compiler generates metadata for the first 48 bytes. I compiled a sample code and verified it. The backend does nothing for the extra bytes now. I will soon submit the backend patch to generate the new metadata. Repository: rC Clang CHANGES SINCE LAST ACT

[PATCH] D63774: android: enable double-word CAS on x86_64

compnerd created this revision. compnerd added reviewers: craig.topper, srhines. Herald added a subscriber: jfb. Herald added a project: clang. The android target assumes that for the x86_64 target, the CPU supports SSE4.2 and `popcnt`. This implies that the CPU is Nehalem or newer. This should

[PATCH] D63774: android: enable double-word CAS on x86_64

lebedev.ri added a comment. Is there some test for this area of code? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63774/new/ https://reviews.llvm.org/D63774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 206464. Tyker edited the summary of this revision. Tyker added a comment. Change: - Add support for LValue, MemberPointer and AddrDiffExpr. - Add tests for importing. i wasn't able to test for some APValueKinds: FixePoint, ComplexInt, ComplexFloat, AddrLabelD

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 206467. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/Expr.h

[PATCH] D63760: [clangd] Address limitations in SelectionTree:

sammccall planned changes to this revision. sammccall marked 2 inline comments as done. sammccall added a comment. Thanks for the comments here and the offline discussion. The problems identified were: - when a node's range is adjusted, then invisible parents (like ExprWithCleanups) don't adj

r364331 - [ARM] Support inline assembler constraints for MVE.

Author: statham Date: Tue Jun 25 09:49:32 2019 New Revision: 364331 URL: http://llvm.org/viewvc/llvm-project?rev=364331&view=rev Log: [ARM] Support inline assembler constraints for MVE. "To" selects an odd-numbered GPR, and "Te" an even one. There are some 8.1-M instructions that have one too few

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364331: [ARM] Support inline assembler constraints for MVE. (authored by statham, committed by ). Changed prior to commit: https://reviews.llvm.org/D60709?vs=206455&id=206472#toc Repository: rL LLVM

[PATCH] D63774: android: enable double-word CAS on x86_64

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Craig, can you confirm that this is acceptable? I don't think there are any chips with SSE4.2 but without cx16, so this just seemed like an oversight. It might be a good idea to really audit

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

craig.topper added inline comments. Comment at: cfe/trunk/lib/Basic/Targets/ARM.cpp:912 + return true; +} case 'U': // a memory reference... Is this supposed to fallthrough from 'T' to 'U'? If so can you add an LLVM_FALLTHROUGH Repository: rL LLV

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

craig.topper added inline comments. Comment at: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp:14098 } + + case 2: Is this supposed to fallthrough from case 1 to case 2? Comment at: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp:14113 +

[PATCH] D63756: [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).

tra added a comment. In D63756#1557658 , @cdevadas wrote: > Hi Sam, > The compiler generates metadata for the first 48 bytes. I compiled a sample > code and verified it. The backend does nothing for the extra bytes now. > I will soon submit the backend

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

Szelethus marked an inline comment as done. Szelethus added a comment. I usually do the final update right before commiting. There still are non-accepted dependencies, who knows what'll happen. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:157

[PATCH] D63742: [WebAssembly] Implement Address Sanitizer for Emscripten

quantum marked an inline comment as done. quantum added a comment. As for the name, I think `__global_base` matches the command line flag and makes it more clear what controls it, so I lean towards that. Comment at: lld/wasm/Writer.cpp:228 + if (WasmSym::GlobalBase) +Wasm

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added a comment. Sorry for the delay, Lingda. I tried to find some better solution for this. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponen

[PATCH] D62293: [modules] Add PP callbacks for entering and leaving a submodule.

rsmith added a comment. `PPCallbacks` seems to be missing the addition of `EnteredSubmodule` and `LeftSubmodule`; `PPChainedCallbacks` seems to be missing the addition of `LeftSubmodule`. Generally this seems reasonable. Comment at: lib/Lex/PPLexerChange.cpp:783 +if (Cal

[PATCH] D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:92 + const std::string Input = "void log(int);"; + EXPECT_EQ(Input, test::runCheckOnCode(Input)); +} g

[PATCH] D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:92 + const std::string Input = "void log(int);"; + EXPECT_EQ(Input, test::runCheckOnCode(Input)); +} y

r364340 - Add regression test for PR41576 (which is already fixed in trunk,

Author: rsmith Date: Tue Jun 25 11:42:53 2019 New Revision: 364340 URL: http://llvm.org/viewvc/llvm-project?rev=364340&view=rev Log: Add regression test for PR41576 (which is already fixed in trunk, perhaps by r361300). Modified: cfe/trunk/test/SemaTemplate/lambda-capture-pack.cpp Modified:

[PATCH] D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:92 + const std::string Input = "void log(int);"; + EXPECT_EQ(Input, test::runCheckOnCode(Input)); +} y

[PATCH] D62738: [HIP] Support attribute hip_pinned_shadow

yaxunl updated this revision to Diff 206504. yaxunl retitled this revision from "[HIP] Support device_shadow variable" to "[HIP] Support attribute hip_pinned_shadow". yaxunl edited the summary of this revision. yaxunl added a comment. rename the attribute and make it HIP only. CHANGES SINCE LAS

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran updated this revision to Diff 206502. DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Removed rendering of some CommentInfo kinds to reduce review load. Removed all , , and tags; they are not n

[PATCH] D63180: [clang-doc] Adds HTML generator

DiegoAstiazaran marked 12 inline comments as done. DiegoAstiazaran added a comment. A couple of comments that were related to the function writeDescription() were marked as done since most of that function was deleted. Rendering of the other kinds of CommentInfos will be handled later. ==

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, ar

[PATCH] D63774: android: enable double-word CAS on x86_64

compnerd added a comment. @lebedev.ri - sure, I will add a driver test to ensure that the feature is set on the command line when invoked from the driver, however, I don't think that there is really much in terms of testing that you can do for this type of stuff other than throw a large corpus

[PATCH] D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. Currently, `clang::tidy::test::runCheckOnCode()` constructs the check instances *before* initializing the ClangTidyContext. This ordering causes problems when th

[PATCH] D63774: android: enable double-word CAS on x86_64

craig.topper added inline comments. Comment at: test/Driver/android-default-x86_64.c:1 +// RUN: %clang -### -target x86_64-unknown-linux-android -c %s 2>&1 | FileCheck %s +// CHECK: "-mcx16" should we just update the android 64 case in clang-translation.c instea

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D63774: android: enable double-word CAS on x86_64

compnerd updated this revision to Diff 206508. compnerd added a comment. add additional context and test case Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63774/new/ https://reviews.llvm.org/D63774 Files: lib/Driver/ToolChains/Arch/X86.cpp test/Driver/andro

[PATCH] D63288: [clang-tidy] Generalize TransformerClangTidyCheck to take a rule generator.

ymandel updated this revision to Diff 206510. ymandel added a comment. Rebase onto fix to `runCheckOnCode`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63288/new/ https://reviews.llvm.org/D63288 Files: clang-tools-extra/clang-tidy/utils/Transf

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked 4 inline comments as done. lildmh added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, ar

[PATCH] D63774: android: enable double-word CAS on x86_64

compnerd updated this revision to Diff 206519. compnerd added a comment. Move test case around Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63774/new/ https://reviews.llvm.org/D63774 Files: lib/Driver/ToolChains/Arch/X86.cpp test/Driver/clang-translation.c

  1   2   >