sbc100 added inline comments.
================ Comment at: lld/wasm/Writer.cpp:228 + if (WasmSym::GlobalBase) + WasmSym::GlobalBase->setVirtualAddress(Config->GlobalBase); + ---------------- Surly if emscripten is passing in --global-base it already knows this value? Otherwise lgtm. Perhaps split of the lld part into a separate change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63742/new/ https://reviews.llvm.org/D63742 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
