sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:137
+ // Parsing the .h file as C++ include.
+ TU.ExtraArgs.push_back("-xobjective-c++-header");
auto AST = TU.build();
----------------
hokein wrote:
> sammccall wrote:
> > (why this change?)
> for the cases here, we want the main file treat as a header file, using
> `-xc++` here would make clang treat it as a `.cc` file.
It sounds like this is unrelated to the current change, and is designed to
address tests that were passing by mistake (rename was failing because the file
was not a header, not for the desired reason.
Can we split up the fix into another patch, and verify it by asserting on the
error message?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63759/new/
https://reviews.llvm.org/D63759
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
