[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

aaron.ballman added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:1279 continue; - if (S.getLangOpts().CPlusPlus11) { + if (S.getLangOpts().CPlusPlus11 || S.getLangOpts().C99) { const Stmt *Term = B->getTerminatorStmt(); -

[PATCH] D59402: Suggestions to fix -Wmissing-{prototypes,variable-declarations}

aaronpuchert added inline comments. Comment at: lib/Sema/SemaDecl.cpp:13345-13346 +<< (FD->getStorageClass() == SC_None +? FixItHint::CreateInsertion(FD->getTypeSpecStartLoc(), + "static ") +

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:244 // interface). + bool IsTypeDef = false; // Indicates if record was declared using typedef llvm::SmallVector Run

[PATCH] D59402: Suggestions to fix -Wmissing-{prototypes,variable-declarations}

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:13345-13346 +<< (FD->getStorageClass() == SC_None +? FixItHint::CreateInsertion(FD->getTypeSpecStartLoc(), + "static ") +

r363606 - PR42205: DebugInfio: Do not attempt to emit debug info metadata for static member variable template partial specializations

Author: dblaikie Date: Mon Jun 17 12:40:52 2019 New Revision: 363606 URL: http://llvm.org/viewvc/llvm-project?rev=363606&view=rev Log: PR42205: DebugInfio: Do not attempt to emit debug info metadata for static member variable template partial specializations Would cause a crash in an attempt to

[PATCH] D63438: [analyzer] print() JSONify: ProgramPoint revision

NoQ added a comment. Yes, this would be helpful! Tests? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63438/new/ https://reviews.llvm.org/D63438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D63436: [analyzer] Fix JSON dumps for ExplodedNodes

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Analysis/dump_egraph.c:3 // RUN: cat %t.dot | FileCheck %s -// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-dump-egraph=%t.dot -trim-egraph

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn updated this revision to Diff 205151. kpn marked 3 inline comments as done. kpn added a comment. Address review comments. Run the changes through clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 Files: include/llvm/IR/IRBuild

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn added inline comments. Comment at: include/llvm/IR/IRBuilder.h:1138 + +return MetadataAsValue::get(Context, RoundingMDS); + } rjmccall wrote: > Huh? You build an `MDNode` that wraps an `MDString` and then immediately > extract the `MDString` from it an

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5609 +def warn_mul_in_bool_context : Warning< + "'*' in bool context, maybe you mean '&&'?">, + InGroup; I would appreciate seeing some motivating examples for this case

[PATCH] D63454: [OpenMP] Strengthen regression tests for task allocation under nowait depend clauses NFC

gtbercea created this revision. gtbercea added reviewers: ABataev, Hahnfeld, caomhin. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This patch strengthens the tests introduced in D63009 by: - adding new test for defau

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62944/new/ https://reviews.llvm.org/D62944 ___ cfe-commit

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

rjmccall added inline comments. Comment at: include/llvm/IR/IRBuilder.h:1138 + +return MetadataAsValue::get(Context, RoundingMDS); + } kpn wrote: > rjmccall wrote: > > Huh? You build an `MDNode` that wraps an `MDString` and then immediately > > extract the

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked 3 inline comments as done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5609 +def warn_mul_in_bool_context : Warning< + "'*' in bool context, maybe you mean '&&'?">, + InGroup; aaron.ballman wrote: > I w

[PATCH] D60974: Clang IFSO driver action.

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:91 + std::vector MangledNames = CGNameGen.getAllManglings(ND); + if (isa(ND) || isa(ND)) {

[PATCH] D63454: [OpenMP] Strengthen regression tests for task allocation under nowait depend clauses NFC

Hahnfeld added inline comments. Comment at: test/OpenMP/target_constant_device_codegen.cpp:2-4 +// RUN: %clang_cc1 -verify -fopenmp -x c++ -triple powerpc64le-unknown-unknown -fopenmp-targets=powerpc64le-ibm-linux-gnu -emit-llvm %s -o - | FileCheck %s --check-prefix CHECK --che

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn marked an inline comment as done. kpn added inline comments. Comment at: include/llvm/IR/IRBuilder.h:1138 + +return MetadataAsValue::get(Context, RoundingMDS); + } rjmccall wrote: > kpn wrote: > > rjmccall wrote: > > > Huh? You build an `MDNode` that wr

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rsmith updated this revision to Diff 205161. rsmith marked 13 inline comments as done. rsmith added a comment. - Address review comments from rjmccall. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63371/new/ https://reviews.llvm.org/D63371 Files: lib/CodeGen/

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rsmith added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:73 +/// Incremental builder for an llvm::Constant* holding a structure constant. +class ConstantBuilder : private ConstantBuilderUtils { + llvm::SmallVector Elems; rjmccall wrote: > This se

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

efriedma added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:967 // Constant folding is currently missing support for a few features supported // here: CK_ToUnion, CK_ReinterpretMemberPointer, and DesignatedInitUpdateExpr. class ConstExprEmitter : ---

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rsmith updated this revision to Diff 205162. rsmith added a comment. - Fix somewhat-incorrect comment on Size member. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63371/new/ https://reviews.llvm.org/D63371 Files: lib/CodeGen/CGExprConstant.cpp test/CodeGenC

r363612 - Clang :: Sema/wchar.c has long been failing on Solaris:

Author: ro Date: Mon Jun 17 13:21:25 2019 New Revision: 363612 URL: http://llvm.org/viewvc/llvm-project?rev=363612&view=rev Log: Clang :: Sema/wchar.c has long been failing on Solaris: error: 'error' diagnostics expected but not seen: File /vol/llvm/src/clang/local/test/Sema/wchar.c Line 2

[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL363612: Clang :: Sema/wchar.c has long been failing on Solaris: (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D59402: Suggestions to fix -Wmissing-{prototypes,variable-declarations}

aaronpuchert added inline comments. Comment at: lib/Sema/SemaDecl.cpp:13345-13346 +<< (FD->getStorageClass() == SC_None +? FixItHint::CreateInsertion(FD->getTypeSpecStartLoc(), + "static ") +

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:967 // Constant folding is currently missing support for a few features supported // here: CK_ToUnion, CK_ReinterpretMemberPointer, and DesignatedInitUpdateExpr. c

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:244 // interface). + bool IsTypeDef = false; // Indicates if record was declared us

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rjmccall added a comment. Minor requests, then LGTM. Comment at: lib/CodeGen/CGExprConstant.cpp:73 +/// Incremental builder for an llvm::Constant* holding a structure constant. +class ConstantBuilder : private ConstantBuilderUtils { + llvm::SmallVector Elems;

[PATCH] D63367: [clang-doc] Add basic support for templates and typedef

DiegoAstiazaran updated this revision to Diff 205169. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Specify type in declarations where //auto// keyword was used. Initialize pointer to nullptr in empty declaration. CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D63290: Unify DependencyFileGenerator class and DependencyCollector interface

aganea added a reviewer: benlangmuir. aganea added inline comments. Comment at: clang/include/clang/Frontend/Utils.h:118 /// Builds a depdenency file when attached to a Preprocessor (for includes) and /// ASTReader (for module imports), and writes it out at the end of process

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ updated this revision to Diff 205177. NoQ added a comment. Add tests, rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761 Files: clang/test/Analysis/exploded-graph-rewriter/environment_diff.dot clang/test/Analysis/exploded-graph-rewr

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:287 .replace('\\}', '}') \ +.replace('', '\\') \ .replace('\\<

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rsmith updated this revision to Diff 205182. rsmith marked 2 inline comments as done. rsmith added a comment. - Address additional review comments from rjmccall. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63371/new/ https://reviews.llvm.org/D63371 Files: li

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:287 .replace('\\}', '}') \ +.replace('', '\\') \

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: lib/CodeGen/CGExprConstant.cpp:162 + return replace(V, BeginOff, EndOff, Vals.begin(), Vals.end()); +} + rjmccall wrote: > Can these go to STLExtras or somewhere similar? Done. Th

[PATCH] D63371: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363620: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and… (authored by rsmith, committed by ).

r363620 - Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants.

Author: rsmith Date: Mon Jun 17 14:08:30 2019 New Revision: 363620 URL: http://llvm.org/viewvc/llvm-project?rev=363620&view=rev Log: Rewrite ConstStructBuilder with a mechanism that can cope with splitting and updating constants. Summary: This adds a ConstantBuilder class that deals with increme

[PATCH] D63454: [OpenMP] Strengthen regression tests for task allocation under nowait depend clauses NFC

gtbercea updated this revision to Diff 205186. gtbercea added a comment. - Fix test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63454/new/ https://reviews.llvm.org/D63454 Files: test/OpenMP/target_constant_device_codegen.cpp test/OpenMP/target_depend_code

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 205187. xbolva00 added a comment. Handle 10 ^ -C case.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Se

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1609-1613 + if (B->rbegin()->getKind() != CFGElement::Kind::Statement) +return nullptr; + + // This should be the condition of the terminator block. + const Stmt *S = B->rbegin()->

[PATCH] D63031: DebugInfo: Render the canonical name of a class template specialization, even when nested in another class template specialization

dblaikie marked an inline comment as done. dblaikie added a comment. Ping (just curious about the change to the canonicalization printing policy - making sure I don't break something important) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63031/new/ https://rev

r363622 - Fix crash when checking a dependently-typed reference that is

Author: rsmith Date: Mon Jun 17 14:46:17 2019 New Revision: 363622 URL: http://llvm.org/viewvc/llvm-project?rev=363622&view=rev Log: Fix crash when checking a dependently-typed reference that is initialized from a non-value-dependent initializer. Modified: cfe/trunk/lib/AST/Decl.cpp cfe/t

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

Quuxplusone added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10931 + // Do not diagnose hexadecimal literals + if (ExprStr.find("0x") != llvm::StringRef::npos) +return; Can you use `starts_with` (or the LLVM equivalent) in both of these cases? It'l

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 205191. plotfi marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/incl

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 added a comment. Thanks, I will address your notes soon! The only remaining question is, as your said, whether or not to diagnose xors in macros. @regerh @jfb ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 ___

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus marked 3 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1609-1613 + if (B->rbegin()->getKind() != CFGElement::Kind::Statement) +return nullptr; + + // This should be the condition of the

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10931 + // Do not diagnose hexadecimal literals + if (ExprStr.find("0x") != llvm::StringRef::npos) +return; Quuxplusone wrote: > Can you use `starts

[PATCH] D63161: Devirtualize destructor of final class.

yamauchi marked 2 inline comments as done. yamauchi added inline comments. Comment at: lib/CodeGen/CGExprCXX.cpp:1887 +Dtor = DevirtualizedDtor; +Ptr = CGF.EmitPointerWithAlignment(Inner); + } else { rsmith wrote: > In this case w

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1640-1642 + CFGBlock *OriginB = GetRelevantBlock(Origin); + if (!OriginB || !NB) +return nullptr; Szelethus wrote: > NoQ wrote: > > `// TODO: This can be cached.` >

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

regehr added a comment. In D63423#1547216 , @xbolva00 wrote: > The only remaining question is, as your said, whether or not to diagnose xors > in macros. @regerh @jfb ? IMO it's better to not warn about xors in macros-- I like the current tradeoffs. C

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 205198. xbolva00 added a comment. Addressed review notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 added a comment. In D63423#1547244 , @regehr wrote: > In D63423#1547216 , @xbolva00 wrote: > > > The only remaining question is, as your said, whether or not to diagnose > > xors in macros. @regerh @jfb ?

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 updated this revision to Diff 205202. xbolva00 added a comment. Removed unused diagnostic message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKind

r363626 - [clang-ifs] Clang Interface Stubs, first version.

Author: zer0 Date: Mon Jun 17 15:46:54 2019 New Revision: 363626 URL: http://llvm.org/viewvc/llvm-project?rev=363626&view=rev Log: [clang-ifs] Clang Interface Stubs, first version. Clang interface stubs (previously referred to as clang-ifsos) is a new frontend action in clang that allows the gene

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/SemaCXX/warn-xor-as-pow.cpp:13 +res = a ^ b; +res = 2 ^ 0; +res = 2 ^ 1; // expected-warning {{result of '2 ^ 1' is 3, maybe you mean '1<<1' (2)?}} jfb wrote:

[PATCH] D60974: Clang IFSO driver action.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363626: [clang-ifs] Clang Interface Stubs, first version. (authored by zer0, committed by ). Changed prior to commit: https://reviews.llvm.org/D60974?vs=205191&id=205203#toc Repository: rL LLVM CHAN

r363627 - [Remarks][Driver] Use the specified format in the remarks file extension

Author: thegameg Date: Mon Jun 17 15:49:38 2019 New Revision: 363627 URL: http://llvm.org/viewvc/llvm-project?rev=363627&view=rev Log: [Remarks][Driver] Use the specified format in the remarks file extension By default, use `.opt.yaml`, but when a format is specified with `-fsave-optimization-rec

[PATCH] D62635: Add enums as global variables in the IR metadata.

dblaikie added a comment. Is it practical/possible to do this in LLVM rather than in Clang? I'd have thought it'd be best to keep the IR metadata as output-format agnostic as practical/possible to reduce divergent codepaths, etc? Repository: rL LLVM CHANGES SINCE LAST ACTION https://revie

[PATCH] D63436: [analyzer] Fix JSON dumps for ExplodedNodes

Charusso updated this revision to Diff 205208. Charusso edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63436/new/ https://reviews.llvm.org/D63436 Files: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp clang/test/Analysis/dump_egraph.c Index: clang/t

[PATCH] D63438: [analyzer] print() JSONify: ProgramPoint revision

Charusso updated this revision to Diff 205209. Charusso added a comment. - Added a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63438/new/ https://reviews.llvm.org/D63438 Files: clang/lib/Analysis/ProgramPoint.cpp clang/test/Analysis/dump_egraph.c Index: clang/test/An

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. - Repository: rC Clang https://reviews.llvm.org/D63462 Fi

[PATCH] D63436: [analyzer] Fix JSON dumps for ExplodedNodes

Charusso marked 2 inline comments as done. Charusso added a comment. Thanks for the review! Comment at: clang/test/Analysis/dump_egraph.c:3 // RUN: cat %t.dot | FileCheck %s -// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-dump-egraph=%t.dot -trim-egraph %s // RE

[PATCH] D63438: [analyzer] print() JSONify: ProgramPoint revision

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63438/new/ https://reviews.llvm.org/D63438 ___ cfe-commits mailing list cfe-commi

[PATCH] D63161: Devirtualize destructor of final class.

rsmith added inline comments. Comment at: lib/CodeGen/CGExprCXX.cpp:1887 +Dtor = DevirtualizedDtor; +Ptr = CGF.EmitPointerWithAlignment(Inner); + } else { yamauchi wrote: > rsmith wrote: > > In this case we'll emit the inner expre

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso accepted this revision. Charusso marked an inline comment as done. Charusso added a comment. Thanks for the main development! Could I start to reduce the size with my SVG-magic? What do you think about make it more SVG-based on the styling side? Comment at: clang/util

[PATCH] D62635: Add enums as global variables in the IR metadata.

akhuang added a comment. I think the main issue was keeping track of which enums are used? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62635/new/ https://reviews.llvm.org/D62635 ___ cfe-commits mailing list cfe-comm

[PATCH] D62635: Add enums as global variables in the IR metadata.

dblaikie added a comment. In D62635#1547352 , @akhuang wrote: > I think the main issue was keeping track of which enums are used? The used enums would still end up in the 'enums' list for the DICompileUnit, right? (If CodeView needs more enums in the li

[PATCH] D62635: Add enums as global variables in the IR metadata.

akhuang added a comment. They should all be there, but emitting the unused enums makes the binary sizes larger. (I think around 6% increase? I forget the size difference for only emitting used enums) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62635/new/ https

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

rsmith added a comment. In D57086#1546386 , @aaron.ballman wrote: > In D57086#1535873 , @domdom wrote: > > > Something I should ask, it seems like GCC only ignores the NullStmts at the > > end if it's in C mode. S

RE: r363204 - [clang-scan-deps] initial outline of the tool that runs preprocessor to find

Hi Alex, In the test you added here, the json file contains compile commands that includes "-c". Is that really necessary for the test to work properly? The reason I ask is that if you run in a configuration which does not use the integrated assembler, the test fails with an error due to the fa

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. @hans Please make sure all Chromium for 32-bit Linux libraries are following System V ABI (i.e., m64 is passed on mmx register). I suspect that there are some hand written assembly code in your libraries which is not following the ABI. Repository: rL LLVM CHANGES SI

[PATCH] D59744: Fix i386 ABI "__m64" type bug

thakis added a comment. In D59744#1547445 , @wxiao3 wrote: > @hans > > Please make sure all Chromium for 32-bit Linux libraries are following System > V ABI (i.e., m64 is passed on mmx register). I suspect that there are some > hand written assembly code

[PATCH] D60974: Clang IFSO driver action.

MaskRay added inline comments. Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58 clangDriver + clangIndex clangEdit This is a layering issue. clangIndex depends on clangFrontend so clangFrontend should not depend on clangIndex. The circular dependency

[PATCH] D60974: Clang IFSO driver action.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58 clangDriver + clangIndex clangEdit MaskRay wrote: > This is a layering issue. clangIndex depends on clangFrontend so > clangFronten

[PATCH] D60974: Clang IFSO driver action.

MaskRay added inline comments. Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:22 + StringRef Format; + std::set ParsedTemplates; + Does `StringSet<>` work? Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsum

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 3 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:22 + StringRef Format; + std::set ParsedTemplates; + MaskRay wrote: > Does `StringSet<>` work? It probably could work. I

RE: r363548 - Promote -fdebug-compilation-dir from a cc1 flag to clang and clang-cl driver flags

Hi Nico, The test you added in cfe/trunk/test/Driver/clang_f_opts.c fails if a target does not use the integrated assembler. You can see what happens if you add "-fno-integrated-as" to the command line: /home/dyung/src/upstream/363548-linux/bin/clang -### -fno-integrated-as -fdebug-compilation

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 added a comment. I have created a patch for you: https://reviews.llvm.org/D63473 Is it ok? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 ___ cfe-commits mailing list c

[PATCH] D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior

wxiao3 created this revision. wxiao3 added reviewers: annita.zhang, LuoYuanke, smaslov, craig.topper, hjl.tools, rnk, andreadb, gbedwell, rjmccall, krytarowski, mgorny, joerg, RKSimon, hans, thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. The System V i386 bug fix

[PATCH] D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior

compnerd added a comment. Could you please add a test to ensure that Darwin defaults to the old behaviour? Comment at: include/clang/Basic/LangOptions.h:142 +/// Attempt to be ABI-compatible with code generated by Clang 8.0.x +/// (https://reviews.llvm.org/D59744). This

[PATCH] D60974: Clang IFSO driver action.

asb added inline comments. Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58 clangDriver + clangIndex clangEdit plotfi wrote: > MaskRay wrote: > > This is a layering issue. clangIndex depends on clangFrontend so > > clangFrontend should not depend on c

r363646 - [NFC] Fixing -DBUILD_SHARED_LIBS=ON problem caused by layering issue in D60974

Author: zer0 Date: Mon Jun 17 21:40:03 2019 New Revision: 363646 URL: http://llvm.org/viewvc/llvm-project?rev=363646&view=rev Log: [NFC] Fixing -DBUILD_SHARED_LIBS=ON problem caused by layering issue in D60974 Modified: cfe/trunk/lib/Frontend/CMakeLists.txt Modified: cfe/trunk/lib/Frontend/

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 3 inline comments as done. plotfi added inline comments. Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58 clangDriver + clangIndex clangEdit asb wrote: > plotfi wrote: > > MaskRay wrote: > > > This is a layering issue. clangIndex depends

r363648 - [NFC] Undoing r363646 to fix bots.

Author: zer0 Date: Mon Jun 17 22:15:59 2019 New Revision: 363648 URL: http://llvm.org/viewvc/llvm-project?rev=363648&view=rev Log: [NFC] Undoing r363646 to fix bots. -DBUILD_SHARED_LIBS=ON is still having problem caused by layering issues with D60974. Locally there weren't problems building with

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. I had to back out r363646. While it worked for me building locally with and without shared lib, it appears to have caused bots to break. I will take another look at fixing it in about 10 hours. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D60974: Clang IFSO driver action.

MaskRay added inline comments. Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:12 +#include "clang/Frontend/FrontendActions.h" +#include "clang/Index/CodegenNameGenerator.h" +#include "clang/Sema/TemplateInstCallback.h" > rL363646 This file

r363649 - Revert D60974 "[clang-ifs] Clang Interface Stubs, first version."

Author: maskray Date: Mon Jun 17 22:52:39 2019 New Revision: 363649 URL: http://llvm.org/viewvc/llvm-project?rev=363649&view=rev Log: Revert D60974 "[clang-ifs] Clang Interface Stubs, first version." This reverts commit rC363626. clangIndex depends on clangFrontend. r363626 adds a dependency fro

[PATCH] D60974: Clang IFSO driver action.

MaskRay added a comment. @plotfi Sorry I have to revert this patch. This can also cause problems in `-DBUILD_SHARED_LIBS=off` builds. clangFrontend files cannot `#include "clang/Index/CodegenNameGenerator.h"`, I think you may have to move files around. Repository: rL LLVM CHANGES SINCE LA

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1547682 , @MaskRay wrote: > @plotfi Sorry I have to revert this patch. This can also cause problems in > `-DBUILD_SHARED_LIBS=off` builds. clangFrontend files cannot `#include > "clang/Index/CodegenNameGenerator.h"`, I

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:755 + (Arch == llvm::Triple::x86 || Arch == llvm::Triple::x86_64)) +Opts.EnableDebugEntryValues = Args.hasArg(OPT_femit_debug_entry_values); + -

r363651 - Fix compiler warning by removing unused variable

Author: uabelho Date: Mon Jun 17 23:41:56 2019 New Revision: 363651 URL: http://llvm.org/viewvc/llvm-project?rev=363651&view=rev Log: Fix compiler warning by removing unused variable Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp URL: h

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

kimgr added a comment. This looks good to me, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62115/new/ https://reviews.llvm.org/D62115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

<    1   2