compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:91
+ std::vector<std::string> MangledNames = CGNameGen.getAllManglings(ND);
+ if (isa<CXXConstructorDecl>(ND) || isa<CXXDestructorDecl>(ND)) {
+ if (MangledNames.size() == 1)
----------------
I don't understand this clause. The structurors will always have 2 manglings
(both itanium and MSVC use multiple, I don't remember the SUN and GNU variants
off the top of my head). Adding the assert for the non-structor case is fine,
but please wrap the entire thing in an `LLVM_EXPENSIVE_ASSERT`.
================
Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:116
+ if (RDO & IsLate) {
+ llvm_unreachable("Generating Interface Stubs is not supported with "
+ "delayed template parsing.");
----------------
This really should emit a diagnostic. The `CompilerInstance` should have a
reference to the `DiagnosticsEngine`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60974/new/
https://reviews.llvm.org/D60974
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
