asb added inline comments.
================ Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58 clangDriver + clangIndex clangEdit ---------------- plotfi wrote: > MaskRay wrote: > > This is a layering issue. clangIndex depends on clangFrontend so > > clangFrontend should not depend on clangIndex. > > > > The circular dependency is allowed for static libraries but it breaks > > `-DBUILD_SHARED_LIBS=on`: > > > > ``` > > CMake Error: The inter-target dependency graph contains the following > > strongly connected component (cycle): > > "clangFrontend" of type SHARED_LIBRARY > > depends on "clangIndex" (weak) > > "clangIndex" of type SHARED_LIBRARY > > depends on "clangFrontend" (weak) > > At least one of these targets is not a STATIC_LIBRARY. Cyclic dependencies > > are allowed only among static libraries. > > ``` > Is there a bot affected by this? I will take a look. Sadly there is no -DBUILD_SHARED_LIBS=True bot. This layering issue will break builds for all downstream users using that option though. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
