[PATCH] D61508: [clang-tidy] misc-header-guard : a simple version of llvm-header-guard

JonasToth added a comment. Hi trixirt and thanks for the patch! I would rather like to generalize the llvm check to allow different styles and then alias the general version with different configurations. Introducing this code duplication does not sound like a good idea to me. The documentation

[PATCH] D58033: Add option for emitting dbg info for call site parameters

djtodoro added a comment. @probinson @aprantl Thanks! @vsk Thanks for the comment! Sure, we will add that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D61559: Fix the crash when formatting unsupported encodings

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-format/ClangFormat.cpp:273 +.StartsWith("\xFF\xFE", "UTF-16 (LE)") +.StartsWith("\x2B\x2F\x76", "UTF-7") +.StartsWith("\xF

[PATCH] D61559: Fix the crash when formatting unsupported encodings

sammccall added a comment. You might want to add a test for one of these? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61559/new/ https://reviews.llvm.org/D61559 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang-tools-extra] r360016 - [clangd] Support -fallback-style, similar to clang-format.

Author: sammccall Date: Mon May 6 01:11:59 2019 New Revision: 360016 URL: http://llvm.org/viewvc/llvm-project?rev=360016&view=rev Log: [clangd] Support -fallback-style, similar to clang-format. Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang

[PATCH] D61519: [clangd] Support -fallback-style, similar to clang-format.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360016: [clangd] Support -fallback-style, similar to clang-format. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHA

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

RKSimon added a comment. Where did all the clang diffs come from? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

Szelethus added a comment. Ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59464/new/ https://reviews.llvm.org/D59464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

Szelethus added a comment. Ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57858/new/ https://reviews.llvm.org/D57858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57860: [analyzer] Validate checker option names and values

Szelethus added a comment. Ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57860/new/ https://reviews.llvm.org/D57860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59465: [analyzer] Add a test plugin for checker option handling

Szelethus added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59465/new/ https://reviews.llvm.org/D59465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60552: [X86] Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

This revision was automatically updated to reflect the committed changes. Closed by commit rL360018: Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper… (authored by LuoYuanke, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[clang-tools-extra] r360020 - [clangd] Always call getFormatStyleForFile().

Author: sammccall Date: Mon May 6 01:39:17 2019 New Revision: 360020 URL: http://llvm.org/viewvc/llvm-project?rev=360020&view=rev Log: [clangd] Always call getFormatStyleForFile(). This means "format" will no longer return an error if the -fallback-style flag is invalid, it will log and use LLVM

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

ilya-biryukov added a comment. Nice! Looking at the numbers, the improvements look worthwhile. The stopwords don't seem to be in the patch anymore, but they do seem like a good idea. Specifically, we might want to remove all keywords - the intuition is that they don't provide much value, becaus

r360022 - [X86] Move files to correct directories after D60552

Author: maskray Date: Mon May 6 02:24:36 2019 New Revision: 360022 URL: http://llvm.org/viewvc/llvm-project?rev=360022&view=rev Log: [X86] Move files to correct directories after D60552 Added: cfe/trunk/lib/Headers/avx512bf16intrin.h cfe/trunk/lib/Headers/avx512vlbf16intrin.h cfe/tru

Re: r359949 - [clang] adding explicit(bool) from c++2a

On Sat, May 4, 2019 at 2:06 AM Nicolas Lesser via cfe-commits wrote: > > Author: rakete > Date: Fri May 3 17:09:00 2019 > New Revision: 359949 > > URL: http://llvm.org/viewvc/llvm-project?rev=359949&view=rev > Log: > [clang] adding explicit(bool) from c++2a > > this patch adds support for the

[clang-tools-extra] r360026 - [clangd] Qualify uses of ::testing everywhere. NFC

Author: ibiryukov Date: Mon May 6 03:08:47 2019 New Revision: 360026 URL: http://llvm.org/viewvc/llvm-project?rev=360026&view=rev Log: [clangd] Qualify uses of ::testing everywhere. NFC Add an initial '::' qualifier to all usages of 'testing' namespace that did not have one. The goal is to make

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198242. sammccall added a comment. address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 Files: clangd/CodeComplete.cpp clangd/FindSymbols.cpp clangd/

[clang-tools-extra] r360030 - [clangd] Boost code completion results that were named in the last few lines.

Author: sammccall Date: Mon May 6 03:25:10 2019 New Revision: 360030 URL: http://llvm.org/viewvc/llvm-project?rev=360030&view=rev Log: [clangd] Boost code completion results that were named in the last few lines. Summary: The hope is this will catch a few patterns with repetition: SomeClass*

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198243. sammccall marked 3 inline comments as done. sammccall added a comment. Comment about keywords Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 Files: clangd/C

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall added a comment. In D61537#1491649 , @ilya-biryukov wrote: > Nice! Looking at the numbers, the improvements look worthwhile. > > The stopwords don't seem to be in the patch anymore, but they do seem like a > good idea. Specifically, we might wa

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360030: [clangd] Boost code completion results that were named in the last few lines. (authored by sammccall, committed

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall added a comment. (doh, sorry - I thought this was accepted. Happy to revert, or try the lexer soon if you think it's important. Case-sensitive matching was still slightly negative within the noise) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D61422: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360032: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in… (authored by baloghadamsoftware, committed by ). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[clang-tools-extra] r360032 - [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic

Author: baloghadamsoftware Date: Mon May 6 03:41:37 2019 New Revision: 360032 URL: http://llvm.org/viewvc/llvm-project?rev=360032&view=rev Log: [clang-tidy] Extend bugprone-sizeof-expression check to detect sizeof misuse in pointer arithmetic Some programmers tend to forget that subtracting two

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Embedding clients want to experiment with showing such results in e.g. a different color. Repository: rCTE C

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

ilya-biryukov added a comment. Nah, it's ok. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org/D61537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

kadircet added a comment. We already have `CodeCompletion::Origin` which is (at least should be)set to `Identifier` in those cases. Is there a reason for not using it? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61588/new/ https://reviews.llvm.or

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Rakete added a comment. @Tyker This broke the Chromium build, could you investigate please? http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190506/270340.html Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added a comment. yes i am on it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

r360018 - Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

Author: luoyuanke Date: Mon May 6 01:25:11 2019 New Revision: 360018 URL: http://llvm.org/viewvc/llvm-project?rev=360018&view=rev Log: Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake Summary: 1. Enable infrastructure of AVX512_BF16, which is supported for BFLOA

[PATCH] D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions

dyatkovskiy added a comment. @jdenny ? @sepavloff ? ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61566/new/ https://reviews.llvm.org/D61566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

sammccall added a comment. In D61588#1491728 , @kadircet wrote: > We already have `CodeCompletion::Origin` which is (at least should be)set to > `Identifier` in those cases. Is there a reason for not using it? I'd forgotten about that. A couple I can th

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks for the info. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61588/new/ https://reviews.llvm.org/D61588 ___

[clang-tools-extra] r360039 - [clangd] Expose whether no-compile completion was used.

Author: sammccall Date: Mon May 6 05:03:26 2019 New Revision: 360039 URL: http://llvm.org/viewvc/llvm-project?rev=360039&view=rev Log: [clangd] Expose whether no-compile completion was used. Summary: Embedding clients want to experiment with showing such results in e.g. a different color. Revi

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360039: [clangd] Expose whether no-compile completion was used. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D61588?vs=198246&id=198251#toc Repository:

[PATCH] D61589: [CodeComplete] Add a trailing semicolons to some pattern completions

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added a project: clang. Where semicolon is required in any case. Here's a list of completions that now have a semicolon: - namespace = ; - using namespace ; - using ::; - continue; - break; - goto ; - return;

[PATCH] D61589: [CodeComplete] Add a trailing semicolons to some pattern completions

ilya-biryukov updated this revision to Diff 198254. ilya-biryukov added a comment. - Add tests for 'continue;' and 'break;' completions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61589/new/ https://reviews.llvm.org/D61589 Files: clang/lib/Sem

[PATCH] D61591: [MinGW] Use SEH by default on AArch64

mstorsjo created this revision. mstorsjo added reviewers: rnk, efriedma, mgrang, ssijaric. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. The implementation of SEH is pretty mature at this point. Repository: rC Clang https://reviews.llvm.org/D61591 Files

r360042 - [CodeComplete] Add a trailing semicolons to some pattern completions

Author: ibiryukov Date: Mon May 6 06:18:00 2019 New Revision: 360042 URL: http://llvm.org/viewvc/llvm-project?rev=360042&view=rev Log: [CodeComplete] Add a trailing semicolons to some pattern completions Summary: Where semicolon is required in any case. Here's a list of completions that now have

[PATCH] D61592: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW

mstorsjo created this revision. mstorsjo added reviewers: rnk, efriedma, mgrang, ssijaric. Herald added subscribers: kristina, kristof.beyls, javed.absar. Herald added a project: clang. In MinGW, setjmp isn't expanded as a builtin in the compiler (like it is for MSVC), but manually hooked up as c

[PATCH] D61589: [CodeComplete] Add a trailing semicolons to some pattern completions

This revision was automatically updated to reflect the committed changes. Closed by commit rL360042: [CodeComplete] Add a trailing semicolons to some pattern completions (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

aganea marked an inline comment as done. aganea added a comment. In D61046#1486850 , @rnk wrote: > The only remaining change I find questionable is the R600 backend change creduce'd and reported here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63477#c

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

This revision was automatically updated to reflect the committed changes. Closed by commit rL360044: Fix compilation warnings when compiling with GCC 7.3 (authored by aganea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61046?vs=196655&id=198265#toc Repository: rL LLVM

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

aganea marked an inline comment as done. aganea added inline comments. Comment at: clang/trunk/test/Preprocessor/indent_macro.c:1-2 -// RUN: %clang_cc1 -E %s | grep '^ zzap$' +// RUN: %clang_cc1 -E %s | FileCheck %s --match-full-lines --strict-whitespace +// CHECK: zzap ---

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. In D61509#1491537 , @lebedev.ri wrote: > In D61509#1491397 , @jdenny wrote: > > > In D61509#1491209 , @ABataev wrote: > > > > > In D61509#1491204

[PATCH] D61596: [clangd] Move Rename into its own file, and add unit test. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D61596 Files: clangd/CMakeLists.tx

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

ABataev added a comment. In D61509#1491397 , @jdenny wrote: > In D61509#1491209 , @ABataev wrote: > > > In D61509#1491204 , @lebedev.ri > > wrote: > > > > > In D61509#149115

[PATCH] D61497: [clangd] Introduce a structured hover response

sammccall added a comment. Layering and such looks good. This should compose well with D58547 Comment at: clang-tools-extra/clangd/XRefs.h:52 +struct HoverInfo { + LocatedSymbol Sym; + /// Name of the context containing the symbol. -

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10364 + if (const auto *FD = dyn_cast(D)) { +if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(FD)) { + HasEmittedDeclareTargetRegion = true; gtbercea wrote: > ABataev wro

[PATCH] D61596: [clangd] Move Rename into its own file, and add unit test. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/ClangdServer.cpp:264 Callback> CB) { - auto Action = [Pos](Path File, std::string NewName, + auto Action = [Pos](std:

r360048 - [CodeComplete] Update python tests after r360042

Author: ibiryukov Date: Mon May 6 07:56:24 2019 New Revision: 360048 URL: http://llvm.org/viewvc/llvm-project?rev=360048&view=rev Log: [CodeComplete] Update python tests after r360042 Modified: cfe/trunk/bindings/python/tests/cindex/test_code_completion.py Modified: cfe/trunk/bindings/pytho

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. In D61509#1491898 , @ABataev wrote: > Again, I don't see a single point why would we need this. I don't think there > is a big difference between the location of pragma keyword and `omp` keyword. @lebedev.ri : You said you're not

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:54 __DEVICE__ float fmod(float __x, float __y) { return ::fmodf(__x, __y); } +#ifndef _OPENMP __DEVICE__ int fpclassify(float __x) { Why we have this guard here? It does not work for Op

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

ABataev added a comment. In D61509#1491979 , @jdenny wrote: > In D61509#1491898 , @ABataev wrote: > > > Again, I don't see a single point why would we need this. I don't think > > there is a big difference between

[PATCH] D60605: [clangd] Revamp textDocument/onTypeFormatting.

ilya-biryukov added a comment. Sorry for the delay, I'll make sure to take a close look at the change tomorrow. As mentioned in offline discussions, doing this through `clang-format` seems like the right approach. At the same the markers we put into the files to drive formatting seem fragile, g

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

sammccall added a comment. As discussed, it probably makes sense to split into two patches, adding this abstraction and using it. (All together is also fine but should have the tests for the new behavior, which probably means renderForTests() too) Generally looks good. I think we'll run into th

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:54 __DEVICE__ float fmod(float __x, float __y) { return ::fmodf(__x, __y); } +#ifndef _OPENMP __DEVICE__ int fpclassify(float __x) { ABataev

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:54 __DEVICE__ float fmod(float __x, float __y) { return ::fmodf(__x, __y); } +#ifndef _OPENMP __DEVICE__ int fpclassify(float __x) { gtbercea wrote: > ABataev wrote: > > Why we have thi

Re: [PATCH] D61464: [RiscV] Typo in register aliases

I'll get it. On Sat, May 4, 2019 at 3:47 AM John LLVM via Phabricator wrote: > > JohnLLVM added a comment. > > What should I do now? I do not have rights to commit. > > > CHANGES SINCE LAST ACTION > https://reviews.llvm.org/D61464/new/ > > https://reviews.llvm.org/D61464 > > > _

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao added a comment. @rsmith Do you have the chance to review this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list cfe-com

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 198295. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://reviews.llvm.org/D61497 Files: clang-tools-ex

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper added a comment. Not sure. I'll fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

zoecarver added a comment. Herald added subscribers: libcxx-commits, ldionne. We also need to mark this off in the status. I can do that in D58879 or create a separate patch. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47109

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1490358 , @rupprecht wrote: > I didn't follow the technical details, but I don't see anything wrong with > moving forward on this patch. I think this seems like an interesting idea > worth experimenting with. > > In D609

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

ilya-biryukov updated this revision to Diff 198298. ilya-biryukov marked 7 inline comments as done. ilya-biryukov added a comment. - Use isWhitespace from CharInfo. - Add a comment for merging text blocks together. - Remove assertion that inline code block does not contain newlines. - Simplify how

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:71 + // start and end the code block with more. + unsigned MaxBackticks = 0; + for (llvm::StringRef Left = Input;;) { sammccall wrote: > ``` > backticks = "```" > whi

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

ilya-biryukov updated this revision to Diff 198300. ilya-biryukov added a comment. - Remove hover-related bits, they will go into a separate revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58547/new/ https://reviews.llvm.org/D58547 Files:

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc added a comment. Hey, still motivated to land this, but definitely don't want to break any existing workflows. In particular, > but this afaict (unless I'm missing something :) will also affect the > workflow where the provided range is 0-length range I'm curious how to do this - a

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:52 +struct HoverInfo { + LocatedSymbol Sym; + /// Name of the context containing the symbol. sammccall wrote: > I'm not sure about reuse of LocatedSymbol - do we want to commit to retu

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea updated this revision to Diff 198301. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists.txt lib/Head

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:444 using ::roundf; +#ifndef _OPENMP using ::scalblnf; I see that the same guard is used `lib/Headers/__clang_cuda_device_functions.h`, but for different set of functions. Is this ok?

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper updated this revision to Diff 198303. craig.topper added a comment. Get rid of clang stuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 Files: llvm/lib/Target/X86/X86FixupLEAs.cpp llvm/test/CodeGen/X86/GlobalISel/add-ext.ll

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. Thanks for everyone's responses so far. At this point, I'm going to follow the uncontroversial suggestions from @lebedev.ri: create a `struct PragmaIntroducer`, and split the OpenMP work into a second patch. That will hopefully make it easier for @rsmith or others to c

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/Headers/__clang_cuda_cmath.h:444 using ::roundf; +#ifndef _OPENMP using ::scalblnf; ABataev wrote: > I see that the same guard is used > `lib/Headers/__clang_cuda_device

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: lib/Headers/__clang_cuda_cmath.h:444 using ::roundf; +#ifndef _OPENMP using ::scalblnf; gtbercea wrote: > ABataev wrote: > > I

r360061 - [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses.

Author: abataev Date: Mon May 6 10:49:22 2019 New Revision: 360061 URL: http://llvm.org/viewvc/llvm-project?rev=360061&view=rev Log: [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses. If the `default(none)` was specified for the construct, we might miss diagnostic for the g

Re: r360061 - [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clauses.

Thank you! On Mon, May 6, 2019 at 8:46 PM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Mon May 6 10:49:22 2019 > New Revision: 360061 > > URL: http://llvm.org/viewvc/llvm-project?rev=360061&view=rev > Log: > [OPENMP]Fix PR41768: check DSA for globals with `default(none)` clau

[PATCH] D61591: [MinGW] Use SEH by default on AArch64

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61591/new/ https://reviews.llvm.org/D61591 ___ cfe-commits mailing

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61601 Files: clang-tools-extra/clangd/ClangdLSPServer.c

[PATCH] D61592: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61592/new/ https://reviews.llvm.org/D61592 ___ cfe-commits mailing

[PATCH] D61508: [clang-tidy] misc-header-guard : a simple version of llvm-header-guard

aaron.ballman added a comment. In D61508#1491570 , @JonasToth wrote: > Hi trixirt and thanks for the patch! > > I would rather like to generalize the llvm check to allow different styles > and then alias the general version with different configurations.

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea updated this revision to Diff 198311. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists.txt lib/Head

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC360063: [OpenMP][Clang] Support for target math functions (authored by gbercea, committed by ). Changed prior to commit: https://reviews.llvm.org/D61399?vs=198311&id=198314#toc Repository: rC Clang

r360063 - [OpenMP][Clang] Support for target math functions

Author: gbercea Date: Mon May 6 11:19:15 2019 New Revision: 360063 URL: http://llvm.org/viewvc/llvm-project?rev=360063&view=rev Log: [OpenMP][Clang] Support for target math functions Summary: In this patch we propose a temporary solution to resolving math functions for the NVPTX toolchain, temp

[PATCH] D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61260/new/ https://reviews.llvm.org/D61260 ___ cfe-commits mailing lis

[PATCH] D33841: [clang-tidy] redundant keyword check

aaron.ballman added inline comments. Comment at: test/clang-tidy/readability-redundant-extern.cpp:37 + +void another_file_scope(int _extern); koldaniel wrote: > aaron.ballman wrote: > > More tests that I figured out: > > ``` > > namespace { > > extern void f(); /

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

aaron.ballman added a comment. In D60507#1491095 , @ztamas wrote: > Ping. > Is it good to go or is there anything else I need to include in this patch? Sorry for the delay, I was gone for WG14 meetings last week, which made reviewing more involved patc

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

dblaikie added inline comments. Comment at: lib/Sema/SemaType.cpp:4913-4916 +ExpectNoDerefChunk = false; + } + + ExpectNoDerefChunk = state.didParseNoDeref(); Pointed out in PR41774 there's a dead store to ExpectNoDerefChunk here. Should line 4

[PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61386/new/ https://reviews.llvm.org/D61386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

r360073 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with

Author: abataev Date: Mon May 6 13:07:20 2019 New Revision: 360073 URL: http://llvm.org/viewvc/llvm-project?rev=360073&view=rev Log: [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with default(none). If the combined directive has default(none) clause and has clauses for inner directi

Re: r360073 - [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with

Thank you! On Mon, May 6, 2019 at 11:05 PM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Mon May 6 13:07:20 2019 > New Revision: 360073 > > URL: http://llvm.org/viewvc/llvm-project?rev=360073&view=rev > Log: > [OPENMP]Fix PR41767: diagnose DSA for variables in clauses with > d

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

rsmith reopened this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:373-374 + ExplicitSpecifier ES, FunctionDecl *New) { + if (!ES.getExpr() || ES.get

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:85-87 +if (TL.getQualifierLoc()) + if (!TraverseNestedNameSpecifierLoc(TL.getQualifierLoc())) +return false; You can combine these. ===

[PATCH] D33841: [clang-tidy] redundant keyword check

koldaniel marked an inline comment as done. koldaniel added inline comments. Comment at: test/clang-tidy/readability-redundant-extern.cpp:37 + +void another_file_scope(int _extern); aaron.ballman wrote: > koldaniel wrote: > > aaron.ballman wrote: > > > More tests

[PATCH] D61592: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rC360082: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW (authored by mstorsjo, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61592/new/ http

r360082 - [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW

Author: mstorsjo Date: Mon May 6 14:19:07 2019 New Revision: 360082 URL: http://llvm.org/viewvc/llvm-project?rev=360082&view=rev Log: [AArch64] Add __builtin_sponentry, for calling setjmp in MinGW In MinGW, setjmp isn't expanded as a builtin in the compiler (like it is for MSVC), but manually ho

[PATCH] D61591: [MinGW] Use SEH by default on AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rL360081: [MinGW] Use SEH by default on AArch64 (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D47109: LWG 2969 "polymorphic_allocator::construct() shouldn't pass resource()"

Quuxplusone added a comment. > We also need to mark this off in the status. I can do that in D58879 > or create a separate patch. Good catch! Either is fine with me but I bet a separate patch would be more appropriate. Repository: rCXX libc++ CHANGES SINCE

r360081 - [MinGW] Use SEH by default on AArch64

Author: mstorsjo Date: Mon May 6 14:19:01 2019 New Revision: 360081 URL: http://llvm.org/viewvc/llvm-project?rev=360081&view=rev Log: [MinGW] Use SEH by default on AArch64 The implementation of SEH is pretty mature at this point. Differential Revision: https://reviews.llvm.org/D61591 Modified:

  1   2   >