kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clangd/ClangdServer.cpp:264 Callback<std::vector<TextEdit>> CB) { - auto Action = [Pos](Path File, std::string NewName, + auto Action = [Pos](std::string File, std::string NewName, Callback<std::vector<TextEdit>> CB, ---------------- Why change Path to std::string ? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61596/new/ https://reviews.llvm.org/D61596 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits