ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.

LG with a nit.



================
Comment at: lib/Headers/__clang_cuda_cmath.h:444
 using ::roundf;
+#ifndef _OPENMP
 using ::scalblnf;
----------------
gtbercea wrote:
> ABataev wrote:
> > I see that the same guard is used 
> > `lib/Headers/__clang_cuda_device_functions.h`, but for different set of 
> > functions. Is this ok?
> Yep, it's intentional. Again the variant issue.
Then again, add TODO or FIXME


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61399/new/

https://reviews.llvm.org/D61399



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to