ABataev added inline comments.
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10364
+ if (const auto *FD = dyn_cast<FunctionDecl>(D)) {
+ if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(FD)) {
+ HasEmittedDeclareTargetRegion = true;
----------------
gtbercea wrote:
> ABataev wrote:
> > ABataev wrote:
> > > No need for the braces
> > What if `declare target` is used only for variabes but not for the
> > functions?
> Even more reason to error in that case since it may contain clauses like link
> or to which need for requires directives to be used consistently.
But I don't see that your patch works in this situation. Currently, it will
emit the error only if the declare target function is found, no?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60568/new/
https://reviews.llvm.org/D60568
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
