[clang-tools-extra] r358373 - [clangd] Reorder source files in CMakeLists

Author: kadircet Date: Mon Apr 15 00:21:17 2019 New Revision: 358373 URL: http://llvm.org/viewvc/llvm-project?rev=358373&view=rev Log: [clangd] Reorder source files in CMakeLists Modified: clang-tools-extra/trunk/unittests/clangd/CMakeLists.txt Modified: clang-tools-extra/trunk/unittests/cla

r358375 - [clang-format] [PR41170] Break after return type ignored with certain comments positions

Author: paulhoad Date: Mon Apr 15 00:47:15 2019 New Revision: 358375 URL: http://llvm.org/viewvc/llvm-project?rev=358375&view=rev Log: [clang-format] [PR41170] Break after return type ignored with certain comments positions Summary: Addresses https://bugs.llvm.org/show_bug.cgi?id=41170 The Alwa

[PATCH] D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions

This revision was automatically updated to reflect the committed changes. Closed by commit rL358375: [clang-format] [PR41170] Break after return type ignored with certain comments… (authored by paulhoad, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added inline comments. Comment at: clang/test/SemaSYCL/device-attrubutes.cpp:8-11 +__attribute((sycl_kernel)) void foo(); +__attribute((sycl_device)) void foo1(); +[[clang::sycl_kernel]] void foo2(); +[[clang::sycl_device]] void foo3(); bader wrote: > T

r358378 - [Lookup] Invisible decls should not be ambiguous when renaming.

Author: ioeric Date: Mon Apr 15 01:46:34 2019 New Revision: 358378 URL: http://llvm.org/viewvc/llvm-project?rev=358378&view=rev Log: [Lookup] Invisible decls should not be ambiguous when renaming. Summary: For example, a renamed type in a header file can conflict with declaration in a random file

[PATCH] D60257: [Lookup] Invisible decls should not be ambiguous when renaming.

This revision was automatically updated to reflect the committed changes. Closed by commit rC358378: [Lookup] Invisible decls should not be ambiguous when renaming. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D60257?vs=194841&id=195103#toc Repository:

[clang-tools-extra] r358383 - [clangd] Bump clangd-index version for TemplateArgument changes

Author: kadircet Date: Mon Apr 15 02:18:57 2019 New Revision: 358383 URL: http://llvm.org/viewvc/llvm-project?rev=358383&view=rev Log: [clangd] Bump clangd-index version for TemplateArgument changes Modified: clang-tools-extra/trunk/clangd/index/Serialization.cpp Modified: clang-tools-extra/

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric updated this revision to Diff 195111. ioeric added a comment. - Only return compile command (instead of FileInputs) from AST worker. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60607/new/ https://reviews.llvm.org/D60607 Files: clangd/Cla

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

javed.absar updated this revision to Diff 195112. javed.absar added a comment. Tests merged as suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60485/new/ https://reviews.llvm.org/D60485 Files: include/clang/Basic/BuiltinsAArch64.def include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

bader added inline comments. Comment at: clang/test/SemaSYCL/device-attrubutes.cpp:8-11 +__attribute((sycl_kernel)) void foo(); +__attribute((sycl_device)) void foo1(); +[[clang::sycl_kernel]] void foo2(); +[[clang::sycl_device]] void foo3(); Fznamznon wrote: > b

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

t.p.northover added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9566 +def err_memtag_arg_null_or_pointer : Error< + "%0 argument must be a null or a pointer (%1 invalid)">; +def err_memtag_any2arg_pointer : Error< I think these diagno

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ilya-biryukov added a comment. Thanks, the change LG now. Only nits from my side! Comment at: clangd/Compiler.h:19 #include "../clang-tidy/ClangTidyOptions.h" +#include "GlobalCompilationDatabase.h" #include "index/Index.h" NIT: this looks unrelated to the ac

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

javed.absar marked 2 inline comments as done. javed.absar added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9566 +def err_memtag_arg_null_or_pointer : Error< + "%0 argument must be a null or a pointer (%1 invalid)">; +def err_memtag_any2arg_pointer :

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan added a comment. Well, it doesn't seem to me like there is consensus on prohibiting nested address space conversion like this. I can simply redo the patch to only include the bugfix on implicit conversions and drop the nesting level checks. CHANGES SINCE LAST ACTION https://reviews.

r358393 - [MinGW] Remove some supefluous calls to MakeArgString. NFC.

Author: mstorsjo Date: Mon Apr 15 03:57:09 2019 New Revision: 358393 URL: http://llvm.org/viewvc/llvm-project?rev=358393&view=rev Log: [MinGW] Remove some supefluous calls to MakeArgString. NFC. Modified: cfe/trunk/lib/Driver/ToolChains/MinGW.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Min

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon updated this revision to Diff 195128. Fznamznon added a comment. Applied comments from @bader Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files: clang/include/clang/Basic/Attr.td clang/inc

[PATCH] D60685: [clangd] Dont index Symbols with invalid source location

kadircet created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. After rL358098 clangd started to index redecls of implicit symbols, but sometimes these decls lack the sour

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

bader accepted this revision. bader added a comment. LGTM. One minor comment. Comment at: clang/test/SemaSYCL/device-attributes-on-non-sycl.cpp:3 +// Now pretend that we're compiling a C++ file. There should be warnings. +// RUN: %clang_cc1 -DEXPECT_WARNINGS -fsyntax-only -veri

[PATCH] D60674: [X86] Restore the pavg intrinsics.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - there's too many different optimizations and canonicalizations that can occur on such a pattern to be able to match all of the permutations. We can probably add some InstCombine optim

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon updated this revision to Diff 195134. Fznamznon added a comment. Applied comment from @bader. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files: clang/include/clang/Basic/Attr.td clang/inc

[PATCH] D60687: [clangd] Check file path of declaring header when deciding whether to insert include.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously, we would use include spelling of the declaring header to check whether the inserted header is th

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:1148 + EXPECT_EQ(Res.Context, CodeCompletionContext::CCC_Recovery); + // Identifier-based fallback completion doesn't know about "symbol" scope. + EXPECT_THAT(Res.Completions, ilya-biry

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric updated this revision to Diff 195137. ioeric marked 9 inline comments as done. ioeric added a comment. - address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60607/new/ https://reviews.llvm.org/D60607 Files: clangd/ClangdServer.c

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:80 +// \endcode +struct TextChange { + // The (bound) id of the node whose source will be replaced. This id should ymandel wrote: > ilya-biryukov wrote: > > y

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! See the NITs, specifically about `runAddDocument` - those definitely look worth fixing. Comment at: unittests/clangd/ClangdTests.cpp:1148 + EXPECT_EQ(Re

[PATCH] D60689: [clangd] Fallback to OrigD when SLoc is invalid

kadircet created this revision. kadircet added a reviewer: sammccall. kadircet added a project: clang. Some implicit/built-in decls lack the source location information. Fallback to OrigD that we've seen in the source code instead of the canonical one in those cases. Repository: rG LLVM Github

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

ioeric updated this revision to Diff 195139. ioeric marked 5 inline comments as done. ioeric added a comment. - use sync runAddDocument in test Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60607/new/ https://reviews.llvm.org/D60607 Files: clangd

[clang-tools-extra] r358400 - [clangd] Wait for compile command in ASTWorker instead of ClangdServer

Author: ioeric Date: Mon Apr 15 05:32:28 2019 New Revision: 358400 URL: http://llvm.org/viewvc/llvm-project?rev=358400&view=rev Log: [clangd] Wait for compile command in ASTWorker instead of ClangdServer Summary: This makes addDocument non-blocking and would also allow code completion (in fallbac

[PATCH] D60607: [clangd] Wait for compile command in ASTWorker instead of ClangdServer

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358400: [clangd] Wait for compile command in ASTWorker instead of ClangdServer (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D60607?vs=195139&id=195141#toc Re

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

t.p.northover added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9566 +def err_memtag_arg_null_or_pointer : Error< + "%0 argument must be a null or a pointer (%1 invalid)">; +def err_memtag_any2arg_pointer : Error< javed.absar wrote: >

[PATCH] D51905: Front-end of the implementation of the interleaving algorithm

zhaomo updated this revision to Diff 195148. zhaomo marked 7 inline comments as done. zhaomo added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Fixed bugs in the previous patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51905/new/ https://reviews

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, samparker, SjoerdMeijer. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, javed.absar. Herald added projects: clang, LLVM. Now, when clang processes an argument of the form "-march=foo+x+y+z",

[PATCH] D60699: [ARM] add CLI support for 8.1-M and MVE.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, samparker, SjoerdMeijer. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. Given the existing infrastructure in LLVM side for +fp and +fp.dp, this is more or less trivial, nee

[PATCH] D51905: Front-end of the implementation of the interleaving algorithm

zhaomo added a comment. Addressed @rsmith's comments. Comment at: clang/include/clang/Driver/CC1Options.td:356-357 +HelpText<"Enable VTable interleaving">; +def disable_vtable_interleaving : Flag<["-"], "disable-vtable-interleaving">, +HelpText<"Disable VTable interleav

r358402 - clang-format vs plugin: Visual Studio 2019 support

Author: hans Date: Mon Apr 15 06:02:03 2019 New Revision: 358402 URL: http://llvm.org/viewvc/llvm-project?rev=358402&view=rev Log: clang-format vs plugin: Visual Studio 2019 support Modified: cfe/trunk/tools/clang-format-vs/source.extension.vsixmanifest.in Modified: cfe/trunk/tools/clang-for

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, samparker, SjoerdMeijer. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, eraman, javed.absar. Herald added projects: clang, LLVM. "To" selects an odd-numbered GPR, and "Te" an even one. There

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, samparker, SjoerdMeijer. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. If MVE is present at all, then the macro __ARM_FEATURE_MVE is defined to a value which has bit 0 set

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

t.p.northover added a comment. Is this coordinated with GCC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60709/new/ https://reviews.llvm.org/D60709 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

t.p.northover added a comment. Could you add some tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60710/new/ https://reviews.llvm.org/D60710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60699: [ARM] add CLI support for 8.1-M and MVE.

SjoerdMeijer added inline comments. Comment at: clang/test/Driver/armv8.1m.main.c:1 +// RUN: %clang -target arm-arm-none-eabi -march=armv8.1-m.main+dsp -### %s 2> %t +// RUN: FileCheck --check-prefix=CHECK-DSP < %t %s It doesn't really matter, I guess, but we d

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

riccibruno marked 2 inline comments as done. riccibruno added a comment. (I have numbered your examples to make the discussion easier, and moved to a non-inline comment to have more space) foo(ft_t); // OK: ADL considers N::foo (nobody but GCC implements this) #1 foo(vt_t); // Error: ADL

[PATCH] D60665: [Sema] ADL: Template arguments in a template-id naming a set of overloaded functions (part of CWG 997)

riccibruno added a comment. For information we are discussing in D60570 whether it is actually a good idea to implement this rule. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60665/new/ https://reviews.llvm.org/D60665 _

[PATCH] D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets

CodaFi marked an inline comment as done. CodaFi added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:173 + } + + // Builds of compiler-rt on bare-metal targets are specialized by specific phosek wrote: > Would it be possible to support t

[PATCH] D60691: [ARM] Replace fp-only-sp and d16 with fp64 and d32.

t.p.northover added a comment. I like the direction of this change, and the details look correct too. The one thing I wonder about is whether we should be upgrading .bc files too (or otherwise support fp-only-sp in legacy inputs). I think it's a specialized enough feature that there won't be mu

r358409 - [clang] Aligned allocation is actually supported in macosx 10.13

Author: ldionne Date: Mon Apr 15 07:14:45 2019 New Revision: 358409 URL: http://llvm.org/viewvc/llvm-project?rev=358409&view=rev Log: [clang] Aligned allocation is actually supported in macosx 10.13 Summary: In r350649, I changed aligned allocation from being available starting in macosx10.13 to

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

t.p.northover added a comment. This needs some tests. I'm also not quite sure when you'd use bare "+fp", if it's the default anyway. Comment at: llvm/lib/Support/ARMTargetParser.cpp:476 -StringRef ARM::getArchExtFeature(StringRef ArchExt) { - if (ArchExt.startswith("no")) {

[PATCH] D60626: [clang] Aligned allocation is actually supported in macosx 10.13

This revision was automatically updated to reflect the committed changes. Closed by commit rL358409: [clang] Aligned allocation is actually supported in macosx 10.13 (authored by ldionne, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D60699: [ARM] add CLI support for 8.1-M and MVE.

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60699/new/ https://reviews.llvm.org/D60699 ___

[PATCH] D60626: [clang] Aligned allocation is actually supported in macosx 10.13

ldionne added a comment. Just as a note to someone that might get here through CI failures: I expect this will break back-deployment CIs for libc++ that use recent Clangs (because the XFAILs in libc++ won't be correct anymore). I have a patch ready to address that but I want to see exactly how

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

simon_tatham added a comment. Yes, it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60709/new/ https://reviews.llvm.org/D60709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang-tools-extra] r358413 - [clangd] Fallback to OrigD when SLoc is invalid

Author: kadircet Date: Mon Apr 15 07:38:46 2019 New Revision: 358413 URL: http://llvm.org/viewvc/llvm-project?rev=358413&view=rev Log: [clangd] Fallback to OrigD when SLoc is invalid Summary: Some implicit/built-in decls lack the source location information. Fallback to OrigD that we've seen in t

[PATCH] D60689: [clangd] Fallback to OrigD when SLoc is invalid

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE358413: [clangd] Fallback to OrigD when SLoc is invalid (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D60689?vs=195140&id=195179#toc Repository: rCTE Clan

r358414 - Revert r358337: "[CommandLineParser] Add DefaultOption flag"

Author: ibiryukov Date: Mon Apr 15 07:43:50 2019 New Revision: 358414 URL: http://llvm.org/viewvc/llvm-project?rev=358414&view=rev Log: Revert r358337: "[CommandLineParser] Add DefaultOption flag" The change causes test failures under asan. Reverting to unbreak our integrate. Modified: cfe/t

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thanks! The change looks good now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59932/new/ https://reviews.llvm.org/D59932 _

[PATCH] D60709: [ARM] Support inline assembler constraints for MVE.

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Excellent, looks good to me then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60709/new/ https://reviews.llvm.org/D60709

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195185. gtbercea added a comment. - Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/C

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195186. gtbercea added a comment. - Remove atomic flags. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h li

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8970 +if (Clause->getClauseKind() == OMPC_unified_shared_memory) + CGM.getOpenMPRuntime().HasRequiresUnifiedSharedMemory = true; + } You can do `break;` here, no need for further

[PATCH] D58033: Add option for emitting dbg info for call sites

djtodoro updated this revision to Diff 195188. djtodoro edited the summary of this revision. djtodoro added a comment. -Rebase -Add all_call_sites flag in the case of GNU extensions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.org/D58033 Files: includ

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195190. gtbercea added a comment. - Fix type. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/C

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro updated this revision to Diff 195192. djtodoro added a comment. -Rebase -Use `ExprMutationAnalyzer` for parameter's modification check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58035/new/ https://reviews.llvm.org/D58035 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CG

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195195. gtbercea added a comment. - Add break. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen/

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:1438 + /// requires directives was used in the current module. + virtual llvm::Function *emitRequiresDirectiveRegFun(); + ABataev wrote: > ABata

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked 2 inline comments as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8978 +if (Clause->getClauseKind() == OMPC_unified_shared_memory) { + CGM.getOpenMPRuntime().HasRequiresUnifiedSharedMemory = true; + break; ---

[PATCH] D58043: Add experimental options for call site related dbg info

djtodoro updated this revision to Diff 195198. djtodoro retitled this revision from "Add option for emitting DW_OP_entry_values" to "Add experimental options for call site related dbg info". djtodoro edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58043

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea updated this revision to Diff 195200. gtbercea added a comment. - Remove const. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeG

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8978 +if (Clause->getClauseKind() == OMPC_unified_shared_memory) { + CGM.getOpenMPRuntime().HasRequiresUnifiedSharedMemory = true; + break; gtbercea wrote: > gtbercea wrote:

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: test/OpenMP/openmp_offload_registration.cpp:38 +// CHECK: define internal void @.omp_offloading.requires_reg() +// CHECK: call void @__tgt_register_requires(i64 0) +// CHECK: ret vo

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 195201. ymandel marked 10 inline comments as done. ymandel added a comment. Clarified comments for `translateEdits` function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/ https://reviews.llvm.org/D6

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:87 + TextGenerator Replacement; + TextGenerator Explanation; +}; ilya-biryukov wrote: > ymandel wrote: > > ilya-biryukov wrote: > > > ymandel wrote: > > > > ilya-bi

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Anastasia added a comment. > Our current approach is to add an attribute, which SYCL runtime will use to > mark code passed to `cl::sycl::handler::parallel_for` as "kernel functions". > Obviously runtime library can't mark `foo` as "device" code - this is a > compiler job: to traverse all sym

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda reopened this revision. hintonda added a comment. This revision is now accepted and ready to land. Reopen to track fix after buildbot failure and revert -- r358414. http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190415/644037.html Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D60719: Fixing freestanding for memcpy.

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60719 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/lib/

Re: r358402 - clang-format vs plugin: Visual Studio 2019 support

Nice! Is adding compat to https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.llvm-toolchain&ssr=false#overview equally easy? On Mon, Apr 15, 2019 at 9:01 AM Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hans > Date: Mon Apr 15 06:02:03 2019 > New Rev

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

trixirt added a comment. A comment by whisperity in the origin WIP did not seem to be addressed. Have you looked at IWYU https://github.com/include-what-you-use/include-what-you-use ? The end goals of clang-scan-deps and iwyu seem similar so their implementation problems would also be similar. T

[PATCH] D60721: [ARM] Check codegen of v8.2a intrinsics

dnsampaio created this revision. dnsampaio added reviewers: olista01, miyuki. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. dnsampaio added a parent revision: D60720: [ARM] Add v4f16 and v8f16 types to the CallingConv. ostannard requested changes

[PATCH] D60721: [ARM] Check codegen of v8.2a intrinsics

ostannard requested changes to this revision. ostannard added a comment. This revision now requires changes to proceed. Clang tests should just cover the C->IR translation, and not depend on the LLVM backends. This should instead be an IR->asm test in the LLVM repository. Repository: rC Clang

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:495 + virtual size_t getNumReturnValues() const override { +return isValidState() ? ReturnedValues.size() : -1; + } This should p

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 195217. hintonda added a comment. - Original patch, r358337, that was reverted. - Make sure to clear DefaultOptions on reset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added a comment. In D58236#1466263 , @ebevhan wrote: > Well, it doesn't seem to me like there is consensus on prohibiting nested > address space conversion like this. > > I can simply redo the patch to only include the bugfix on implicit > conv

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda updated this revision to Diff 195218. hintonda added a comment. - Add new test back. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746 Files: clang/lib/Tooling/CommonOptionsParser.cpp llvm/docs/C

r358427 - [X86] Restore the pavg intrinsics.

Author: ctopper Date: Mon Apr 15 10:17:35 2019 New Revision: 358427 URL: http://llvm.org/viewvc/llvm-project?rev=358427&view=rev Log: [X86] Restore the pavg intrinsics. The pattern we replaced these with may be too hard to match as demonstrated by PR41496 and PR41316. This patch restores the int

r358428 - [CommandLineParser] Add DefaultOption flag

Author: dhinton Date: Mon Apr 15 10:18:10 2019 New Revision: 358428 URL: http://llvm.org/viewvc/llvm-project?rev=358428&view=rev Log: [CommandLineParser] Add DefaultOption flag Summary: Add DefaultOption flag to CommandLineParser which provides a default option or alias, but allows users to overr

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL358428: [CommandLineParser] Add DefaultOption flag (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D59746?vs=195218&id=195220#toc Repository: rL LLVM CHANGES

[PATCH] D60674: [X86] Restore the pavg intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358427: [X86] Restore the pavg intrinsics. (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D60674?vs=195090&id=195219#toc Repository: rL LLVM CHANGES SINCE LA

[PATCH] D59744: Fix i386 ABI "__m64" type bug

RKSimon added inline comments. Comment at: test/CodeGen/x86_32-m64-darwin.c:1 +// RUN: %clang_cc1 -w -fblocks -triple i386-apple-darwin9 -target-cpu yonah -target-feature +mmx -emit-llvm -O2 -o - %s | FileCheck %s + You should be able to merge all of these tripl

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ilya-biryukov added a comment. A few quick responses, will take a closer look again tomorrow. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:87 + TextGenerator Replacement; + TextGenerator Explanation; +}; ymandel wrote: > ilya-biryukov wro

[PATCH] D60726: Fixed -Wconversion-null warning in GCC.

dendibakh created this revision. dendibakh added a reviewer: reuk. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC -Wconversion-null warning appeared after 9a63380260860b657b72f07c4f0e61e382ab934a. There was a similar problem already in the past: http://lists.llvm.org/p

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

dexonsmith added a comment. In D60233#1467092 , @trixirt wrote: > A comment by whisperity in the origin WIP did not seem to be addressed. > Have you looked at IWYU > https://github.com/include-what-you-use/include-what-you-use ? > The end goals of clang

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, hans, rsmith. Add a test for tracking PR41027 (8.0 regression breaking assembly code relying on __builtin_constant_p() to identify compile-time constants). Mark it as expected to fail everywhere. https://reviews.llvm.org/D

r358435 - [X86] Improve avx512-kconstraints-att_inline_asm.c to not be easily defeated by deadcode elimination. Improve CHECK lines to check IR types used. NFC

Author: ctopper Date: Mon Apr 15 11:39:36 2019 New Revision: 358435 URL: http://llvm.org/viewvc/llvm-project?rev=358435&view=rev Log: [X86] Improve avx512-kconstraints-att_inline_asm.c to not be easily defeated by deadcode elimination. Improve CHECK lines to check IR types used. NFC I plan to us

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek added a comment. @MaskRay can you review this again now that there's just a single `crtbegin.o` and `crtend.o` version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59264/new/ https://reviews.llvm.org/D59264 ___ cfe-commits mailing

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D60455#1464324 , @Fznamznon wrote: > Applied comments from @aaron.ballman and @keryell > > - Introduced a C++11 and C2x style

[PATCH] D60726: Fixed -Wconversion-null warning in GCC.

reuk accepted this revision. reuk added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60726/new/ https://reviews.llvm.org/D60726 ___ cfe-commits mailin

[PATCH] D60726: Fixed -Wconversion-null warning in GCC.

dendibakh added a comment. @reuk , can you please commit this patch on my behalf? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60726/new/ https://reviews.llvm.org/D60726 ___ cfe-commits mailing list cfe-commits@list

r358437 - Revert "[clang] Aligned allocation is actually supported in macosx 10.13"

Author: ldionne Date: Mon Apr 15 12:08:52 2019 New Revision: 358437 URL: http://llvm.org/viewvc/llvm-project?rev=358437&view=rev Log: Revert "[clang] Aligned allocation is actually supported in macosx 10.13" This reverts r358409, which I think broke the bots in compiler-rt. Since I'm having troub

[PATCH] D60663: Time profiler: small fixes and optimizations

anton-afanasyev added a comment. In D60663#1465721 , @lebedev.ri wrote: > Looks good ignoring the json bits. > > Re license: > > > https://reviews.llvm.org/D58675 > > This is the first part of time tracing system, I have splitted them cause > > this part

[PATCH] D60626: [clang] Aligned allocation is actually supported in macosx 10.13

ldionne added a comment. Reverted in r358437 because of unforeseen CI failures. The failures I was expecting are in libc++, not in compiler-rt. I'll investigate locally and re-apply. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60626/new/ https://reviews.llvm.o

[PATCH] D60663: Time profiler: small fixes and optimizations

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Ok, LG, thank you! Comment at: llvm/lib/Support/TimeProfiler.cpp:30 +cl::desc( +"Minimum time granularity (in microsecons) traced by time profiler"), +

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

void added a comment. ; ModuleID = 'arch_static_branch.bc' source_filename = "arch/x86/entry/vsyscall/vsyscall_64.c" target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target triple = "x86_64-grtev4-linux-gnu" %struct.atomic_t = type { i32 } %struct.jump_entry = type { i6

  1   2   >