SjoerdMeijer added inline comments.
================ Comment at: clang/test/Driver/armv8.1m.main.c:1 +// RUN: %clang -target arm-arm-none-eabi -march=armv8.1-m.main+dsp -### %s 2> %t +// RUN: FileCheck --check-prefix=CHECK-DSP < %t %s ---------------- It doesn't really matter, I guess, but we don't need a temp file and can pipe the output directly to FileCheck? ================ Comment at: clang/test/Driver/armv8.1m.main.c:3 +// RUN: FileCheck --check-prefix=CHECK-DSP < %t %s +// CHECK-DSP: "-target-feature" "+dsp" + ---------------- Do we also want to check that just: -march=armv8.1-m doesn't enable DSP (and other non-mandatory extensions)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60699/new/ https://reviews.llvm.org/D60699 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
