[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

kristina added a comment. If the author is still missing at the end of next week, any objections to me resubmitting a similar patch that just implements `__FILE_NAME__` or `__BASE_NAME__` (Need a few more opinions here I guess, personally I think `__FILE_NAME__` makes more sense)? I'll carve i

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added a comment. @shafik, Could you please take a look? I have run the LLDB tests on our macOS and I could not discover any regression. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://reviews.llvm.org/D58494 __

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

MyDeveloperDay added a comment. While we wait for code review I've landed this currently unaccepted clang-format revision into https://github.com/mydeveloperday/clang-experimental/releases for those wishing to try/test or provide feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

MyDeveloperDay added a comment. @JonasToth I left a comment in the commit needed to fix the index.rst, which I don't think your later review fixes, sphinx complained about the rst file being an unreferenced octtree https://reviews.llvm.org/rG5fbeff797a9dba504f08f14c4fa59b6f1076fe72#inline-2691

[clang-tools-extra] r355108 - [clang-tidy] fix documentation link in list of clang-tidy checks

Author: jonastoth Date: Thu Feb 28 09:53:51 2019 New Revision: 355108 URL: http://llvm.org/viewvc/llvm-project?rev=355108&view=rev Log: [clang-tidy] fix documentation link in list of clang-tidy checks Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified: clang-tools-ext

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay updated this revision to Diff 188752. MyDeveloperDay added a comment. rebase after D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions change as this was previous accepted I will land shortly, but I'd appreciate a quick overv

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno accepted this revision. riccibruno added a comment. This revision is now accepted and ready to land. Looks good, hopefully this time it will stick. thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914

[PATCH] D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions

JonasToth added a comment. In D58731#1413888 , @MyDeveloperDay wrote: > @JonasToth I left a comment in the commit needed to fix the index.rst, which > I don't think your later review fixes, sphinx complained about the rst file > being an unreferenced oc

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

shafik updated this revision to Diff 188753. shafik marked 7 inline comments as done. shafik added a comment. Addressed comments on formatting and missing changes to the `Import_New` version of the code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58743/new/ https://reviews.llvm.org/

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. friendly ping, think this is good to go now Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

JonasToth accepted this revision. JonasToth added a comment. LGTM Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:196 + ReplacementText = " " + OverrideSpelling + " "; +} } else if (GetText(Tokens.back(), Sources) == "ABSTRACT") {

[PATCH] D58737: [InstrProf] Use separate comdat group for data and counters

vsk added a comment. In D58737#1412846 , @rnk wrote: > Oops, forgot to respond to this... > > In D58737#1412734 , @vsk wrote: > > > I'm confused by this wording re: comdats in the LangRef: "All global > > objects t

r355112 - [WebAssembly] Remove uses of ThreadModel

Author: tlively Date: Thu Feb 28 10:39:08 2019 New Revision: 355112 URL: http://llvm.org/viewvc/llvm-project?rev=355112&view=rev Log: [WebAssembly] Remove uses of ThreadModel Summary: In the clang UI, replaces -mthread-model posix with -matomics as the source of truth on threading. In the backend

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

This revision was automatically updated to reflect the committed changes. Closed by commit rLLD355112: [WebAssembly] Remove uses of ThreadModel (authored by tlively, committed by ). Changed prior to commit: https://reviews.llvm.org/D58742?vs=188634&id=188758#toc Repository: rLLD LLVM Linker

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

RKSimon added a comment. Ideally I think you need more clang/frontend experts reviewers - many of us on the reviewers list tend to work mainly in llvm. Test cases would be good as well - even if its just basic sanity tests for command line args etc. Comment at: clang/lib/Sem

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

sbc100 added a comment. In D58742#1413077 , @sunfish wrote: > This is still a little confusing to me. -matomic is supposed to be a > subtarget flag, stating that the wasm implementation we will run on supports > atomic instructions. -mthread-model posix

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

sunfish added a comment. Wasm gives users reasons to want -mthread-model single that other architectures don't, even when -matomics is enabled by default. When shared memory is used, wasm requires modules to declare a max memory size, which is a burden on applications that want to use dynamic a

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

DHowett-MSFT added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:188 + StringRef SymbolPrefix() { +return CGM.getTriple().isOSBinFormatCOFF() ? "_" : "._"; theraven wrote: > DHowett-MSFT wrote: > > Should this be `SymbolPrefix()` or somethin

[PATCH] D57112: [ASTTypeTraits] OMPClause handling

lebedev.ri added a comment. ping @klimek @hokein thanks. The fun of of the code that is so well separated that no one touches it for years and thus can't review patches for it :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57112/new/ https://reviews.llvm.org/D5

[PATCH] D58742: [WebAssembly] Remove uses of ThreadModel

sbc100 added a comment. In D58742#1413979 , @sunfish wrote: > Wasm gives users reasons to want -mthread-model single that other > architectures don't, even when -matomics is enabled by default. > > When shared memory is used, wasm requires modules to decl

r355123 - [clang-format][NFC] Allow getLLVMStyle() to take a language

Author: rupprecht Date: Thu Feb 28 11:16:45 2019 New Revision: 355123 URL: http://llvm.org/viewvc/llvm-project?rev=355123&view=rev Log: [clang-format][NFC] Allow getLLVMStyle() to take a language Summary: getLLVMStyle() sets the default style, but doesn't take the language as a parameter, so can

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

This revision was automatically updated to reflect the committed changes. Closed by commit rL355123: [clang-format][NFC] Allow getLLVMStyle() to take a language (authored by rupprecht, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

rupprecht updated this revision to Diff 188765. rupprecht added a comment. Rebase after NFC commit rC355123 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https://reviews.llvm.org/D55964 Files: clang

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55964/new/ https://reviews.llvm.org/D55964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

theraven marked 2 inline comments as done. theraven added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:188 + StringRef SymbolPrefix() { +return CGM.getTriple().isOSBinFormatCOFF() ? "_" : "._"; DHowett-MSFT wrote: > theraven wrote: > > DHow

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

DHowett-MSFT added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:188 + StringRef SymbolPrefix() { +return CGM.getTriple().isOSBinFormatCOFF() ? "_" : "._"; theraven wrote: > DHowett-MSFT wrote: > > theraven wrote: > > > DHowett-MSFT wrote: >

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

This revision was automatically updated to reflect the committed changes. Closed by commit rL355132: [clang-tidy] add OverrideMacro to modernize-use-override check (authored by paulhoad, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D57087?vs=18

[PATCH] D58236: Make address space conversions a bit stricter.

efriedma added a comment. > I think trying to reject code that is doing something dangerous is a good > thing! Refusing to compile code which is suspicious, but not forbidden by the specification, will likely cause compatibility issues; there are legitimate reasons to use casts which look weir

[clang-tools-extra] r355132 - [clang-tidy] add OverrideMacro to modernize-use-override check

Author: paulhoad Date: Thu Feb 28 12:00:48 2019 New Revision: 355132 URL: http://llvm.org/viewvc/llvm-project?rev=355132&view=rev Log: [clang-tidy] add OverrideMacro to modernize-use-override check Summary: The usefulness of **modernize-use-override** can be reduced if you have to live in an env

[PATCH] D58743: Handle built-in when importing SourceLocation and FileID

shafik added a comment. In D58743#1413249 , @lebedev.ri wrote: > Is there a test missing here? This origin of this fix is the LLDB expression parsing issue. We were not able to reduce to a test we could put in `ASTImpoterTest.cpp` but we have a LLDB te

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 3 inline comments as done. anton-afanasyev added a comment. Ok, I'm to add tests and reviewers. Comment at: clang/lib/Sema/Sema.cpp:113 + llvm::TimeTraceProfilerEnd(); +} S->DiagnoseNonDefaultPragmaPack( RKSimon

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 188783. jkorous added a comment. - fix the linux implementation - clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h clang/lib/CMa

[libunwind] r355142 - [CMake][libunwind] Define add_target_flags which is missing

Author: phosek Date: Thu Feb 28 13:38:59 2019 New Revision: 355142 URL: http://llvm.org/viewvc/llvm-project?rev=355142&view=rev Log: [CMake][libunwind] Define add_target_flags which is missing It's use was introduced in r353084 but its definition is missing. Differential Revision: https://review

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:23 #include "clang/Sema/Lookup.h" +#include "clang/Sema/SemaInternal.h" #include "clang/Sema/Template.h" anton-afanasyev wrote: > RKSimon wrote: > > nfc change? > What do

[PATCH] D58091: Customize warnings for missing built-in type

bcain added a comment. In D58091#1409584 , @jdoerfert wrote: > I did address the comments but I will wait until I hear back on the "warning > vs warning + note question". ... > I do not have strong feelings about this, either way is fine with me. > Ho

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak updated this revision to Diff 188794. ahatanak marked 4 inline comments as done. ahatanak added a comment. Address review comments. - Preserve sugar when creating an `ObjCBoxedExpr` in `Sema::BuildObjCBoxedExpr`. - Add a test case to test/SemaObjC/boxing-illegal.m that shows clang reject

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak added inline comments. Comment at: lib/Sema/SemaExprObjC.cpp:534 +NSStringPointer, NSStringPointer); +return new (Context) ObjCBoxedExpr(SL, BoxedType, nullptr, SR); + } rjmccall wrote: > ahatanak wrote: > > rjmccall wrote: > > >

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. Hi @reuk, I'm trying to go over old reviews and see if they are still desired, I stumbled on your review and want to see if its still important. Here is some initial feedback. I know its ironic that the clang-format code isn't clang-formatted itself, but it mig

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

erik.pilkington created this revision. erik.pilkington added reviewers: george.burgess.iv, rsmith, aaron.ballman. Herald added subscribers: jdoerfert, dexonsmith, jkorous. Herald added a project: clang. These diagnose overflowing calls to subset of fortifiable functions. Some functions, like `spr

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. sorry to be critical, just trying to help get traction on your review... Comment at: lib/Format/TokenAnnotator.cpp:65 -const FormatToken &Previous = *CurrentToken->Previous; // The '<'. +const FormatToken &Previous = *CurrentToken->Pre

r355158 - [clang-format][TableGen] Don't add spaces around items in square braces.

Author: rupprecht Date: Thu Feb 28 16:12:18 2019 New Revision: 355158 URL: http://llvm.org/viewvc/llvm-project?rev=355158&view=rev Log: [clang-format][TableGen] Don't add spaces around items in square braces. Summary: clang-formatting wants to add spaces around items in square braces, e.g. [1, 2]

[PATCH] D55964: [clang-format][TableGen] Don't add spaces around items in square braces.

This revision was automatically updated to reflect the committed changes. Closed by commit rC355158: [clang-format][TableGen] Don't add spaces around items in square braces. (authored by rupprecht, committed by ). Changed prior to commit: https://reviews.llvm.org/D55964?vs=188765&id=188807#toc

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 188808. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h clang/lib/CMakeLists.txt clang/lib/DirectoryWatcher/CMakeLists.txt clang/lib/Direc

[PATCH] D57898: CodeGen: Fix PR40605 by splitting constant struct initializers

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57898/new/ https://reviews.llvm.org/D57898 ___ cfe-commits mailing list cfe-commit

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. > ClamAV recently started using clang-format. We published this blog post > about how we're using it: > https://blog.clamav.net/2019/02/clamav-adopts-clang-format.html One of the > things I called out in the blog post is that we really want this feature, and >

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

micah-s added a comment. In D28462#1413332 , @MyDeveloperDay wrote: > Would you please consider logging your struct example from your blog at > https://bugs.llvm.org, I see a large number of people using clang format > on/off in github for this and sim

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

smeenai created this revision. smeenai added reviewers: beanz, phosek, tstellar, rnk, dim. Herald added subscribers: openmp-commits, Sanitizers, jdoerfert, javed.absar, mgorny. Herald added a reviewer: serge-sans-paille. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. The current in

[PATCH] D57986: [ProfileData] Sort FuncData before iteration to remove non-determinism

mgrang updated this revision to Diff 188824. mgrang retitled this revision from "[ProfileData] Remove non-determinism: Change DenseMap to MapVector" to "[ProfileData] Sort FuncData before iteration to remove non-determinism". mgrang added a reviewer: dblaikie. Herald added a subscriber: jdoerfert

[PATCH] D58807: [CodeGen] COMDAT-fold block descriptors

DHowett-MSFT created this revision. DHowett-MSFT added a project: clang. Herald added a subscriber: cfe-commits. Without this change, linking multiple objects containing block descriptors together on Windows will generate duplicate symbol errors. Repository: rG LLVM Github Monorepo https://re

r355166 - [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

Author: vsapsai Date: Thu Feb 28 18:15:39 2019 New Revision: 355166 URL: http://llvm.org/viewvc/llvm-project?rev=355166&view=rev Log: [CodeGen] Fix calling llvm.var.annotation outside of a basic block. When we have an annotated local variable after a function returns, we generate IR that fails ve

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

vsapsai added a comment. Thanks for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58147/new/ https://reviews.llvm.org/D58147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D58147: [CodeGen] Fix calling llvm.var.annotation outside of a basic block.

This revision was automatically updated to reflect the committed changes. Closed by commit rL355166: [CodeGen] Fix calling llvm.var.annotation outside of a basic block. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D57986: [ProfileData] Sort FuncData before iteration to remove non-determinism

mgrang updated this revision to Diff 188843. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57986/new/ https://reviews.llvm.org/D57986 Files: lib/ProfileData/InstrProfWriter.cpp Index: lib/ProfileData/InstrProfWriter.cpp

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 ___

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked an inline comment as done. anton-afanasyev added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:23 #include "clang/Sema/Lookup.h" +#include "clang/Sema/SemaInternal.h" #include "clang/Sema/Template.h" RKSimon

r355175 - [Sema][ObjC] Allow silencing -Wobjc-designated-initializers warnings by

Author: ahatanak Date: Thu Feb 28 22:43:20 2019 New Revision: 355175 URL: http://llvm.org/viewvc/llvm-project?rev=355175&view=rev Log: [Sema][ObjC] Allow silencing -Wobjc-designated-initializers warnings by declaring an unavailable method in the subclass's extension that overrides the designated i

r355176 - Fix file headers. NFC

Author: maskray Date: Thu Feb 28 22:49:51 2019 New Revision: 355176 URL: http://llvm.org/viewvc/llvm-project?rev=355176&view=rev Log: Fix file headers. NFC Modified: cfe/trunk/lib/ARCMigrate/TransEmptyStatementsAndDealloc.cpp cfe/trunk/lib/ARCMigrate/TransformActions.cpp cfe/trunk/lib

[PATCH] D58724: [gnustep-objc] Make the GNUstep v2 ABI work for Windows DLLs.

DHowett-MSFT added inline comments. Comment at: clang/lib/CodeGen/CGObjCGNU.cpp:1231 +break; + +auto Storage = llvm::GlobalValue::DefaultStorageClass; After we get the `ObjCInterfaceDecl`, we have to make sure it's the one corresponding to th

<    1   2