efriedma added a comment.

> I think trying to reject code that is doing something dangerous is a good 
> thing!

Refusing to compile code which is suspicious, but not forbidden by the 
specification, will likely cause compatibility issues; there are legitimate 
reasons to use casts which look weird.

I'm not against adding some sort of address space suspicious cast warning to 
catch cases where we think the user meant to do something else.  But that's a 
separate issue, and it needs a proper cost-benefit analysis, including an 
analysis of the false-positive rate on existing code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58236/new/

https://reviews.llvm.org/D58236



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to