RKSimon added a comment.
Ideally I think you need more clang/frontend experts reviewers - many of us on
the reviewers list tend to work mainly in llvm.
Test cases would be good as well - even if its just basic sanity tests for
command line args etc.
================
Comment at: clang/lib/Sema/Sema.cpp:113
+ llvm::TimeTraceProfilerEnd();
+ }
S->DiagnoseNonDefaultPragmaPack(
----------------
remove braces
================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:24
#include "clang/Sema/Lookup.h"
+#include "clang/Sema/SemaInternal.h"
#include "clang/Sema/Template.h"
----------------
nfc change?
================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:23
#include "clang/Sema/Lookup.h"
+#include "clang/Sema/SemaInternal.h"
#include "clang/Sema/Template.h"
----------------
nfc change?
================
Comment at: clang/tools/driver/cc1_main.cpp:201
+ llvm::TimeTraceProfilerInitialize();
+ }
+
----------------
remove braces
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58675/new/
https://reviews.llvm.org/D58675
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
