r351304 - [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF

Author: mgorny Date: Wed Jan 16 00:05:13 2019 New Revision: 351304 URL: http://llvm.org/viewvc/llvm-project?rev=351304&view=rev Log: [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF Disable Python binding tests when LLVM_ENABLE_PIC is disabled, as libclang.so is not being built in that

[PATCH] D56732: [clang] [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF

This revision was automatically updated to reflect the committed changes. Closed by commit rC351304: [test] Disable Python binding tests w/ LLVM_ENABLE_PIC=OFF (authored by mgorny, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56732/new/ https://re

[clang-tools-extra] r351306 - [clangd] Fix XPC after rCTE351280

Author: maskray Date: Wed Jan 16 00:13:15 2019 New Revision: 351306 URL: http://llvm.org/viewvc/llvm-project?rev=351306&view=rev Log: [clangd] Fix XPC after rCTE351280 Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp UR

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

MaskRay added a comment. In D54428#1359333 , @tamur wrote: > This patch seems to have broken the compilation. I get the following error on > a linux platform: > [12/14] Linking CXX executable bin/clangd > FAILED: bin/clangd > : && > /usr/local/google

[clang-tools-extra] r351307 - [clang-tidy] Avoid fuchsia-overloaded-operator false positive with lambdas after r351047

Author: sammccall Date: Wed Jan 16 00:29:54 2019 New Revision: 351307 URL: http://llvm.org/viewvc/llvm-project?rev=351307&view=rev Log: [clang-tidy] Avoid fuchsia-overloaded-operator false positive with lambdas after r351047 Modified: clang-tools-extra/trunk/clang-tidy/fuchsia/OverloadedOper

[PATCH] D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.

courbet updated this revision to Diff 181985. courbet marked 2 inline comments as done. courbet added a comment. clang-format + add test Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56657/new/ https://reviews.llvm.org/D56657 Files: clang-tidy/bu

[PATCH] D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351308: [clang-tidy] bugprone-string-constructor: Catch string from nullptr. (authored by courbet, committed by ). Changed prior to commit: https://reviews.llvm.org/D56657?vs=181985&id=181986#toc Rep

[PATCH] D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.

courbet added a comment. Thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56657/new/ https://reviews.llvm.org/D56657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[clang-tools-extra] r351308 - [clang-tidy] bugprone-string-constructor: Catch string from nullptr.

Author: courbet Date: Wed Jan 16 00:36:23 2019 New Revision: 351308 URL: http://llvm.org/viewvc/llvm-project?rev=351308&view=rev Log: [clang-tidy] bugprone-string-constructor: Catch string from nullptr. Summary: Context: https://twitter.com/willkirkby/status/1084219580799741953 Subscribers: xaza

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

sammccall added a comment. Sorry for not getting back to this, but it looks good. I'm really glad about how minimal the changes are outside xpc/, because it makes it less likely we'll accidentally break something that can only be tested on mac. Repository: rCTE Clang Tools Extra CHANGES SI

r351312 - UsersManual.rst: Update the clang-cl flags section

Author: hans Date: Wed Jan 16 01:13:47 2019 New Revision: 351312 URL: http://llvm.org/viewvc/llvm-project?rev=351312&view=rev Log: UsersManual.rst: Update the clang-cl flags section Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL: http://llvm.org/viewvc

r351314 - [NewPM][TSan] Reiterate the TSan port

Author: pfaffe Date: Wed Jan 16 01:28:01 2019 New Revision: 351314 URL: http://llvm.org/viewvc/llvm-project?rev=351314&view=rev Log: [NewPM][TSan] Reiterate the TSan port Summary: Second iteration of D56433 which got reverted in rL350719. The problem in the previous version was that we dropped th

[PATCH] D56538: [NewPM][TSan] Reiterate the TSan port

This revision was automatically updated to reflect the committed changes. Closed by commit rC351314: [NewPM][TSan] Reiterate the TSan port (authored by pfaffe, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D56538?vs=181821&id=181994#to

r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

Author: sammccall Date: Wed Jan 16 01:41:26 2019 New Revision: 351316 URL: http://llvm.org/viewvc/llvm-project?rev=351316&view=rev Log: Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database. This reverts commit r351282, and re-lands r351222

[PATCH] D56429: fix python3 compability issue

serge-sans-paille accepted this revision. serge-sans-paille added inline comments. This revision is now accepted and ready to land. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(content

r351317 - [Support] Remove error return value from one overload of fs::make_absolute

Author: labath Date: Wed Jan 16 01:55:32 2019 New Revision: 351317 URL: http://llvm.org/viewvc/llvm-project?rev=351317&view=rev Log: [Support] Remove error return value from one overload of fs::make_absolute Summary: The version of make_absolute which accepted a specific directory to use as the "

[PATCH] D56599: [Support] Remove error return value from one overload of fs::make_absolute

This revision was automatically updated to reflect the committed changes. Closed by commit rC351317: [Support] Remove error return value from one overload of fs::make_absolute (authored by labath, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.l

[PATCH] D56776: [MSP430] Fix msp430-toolchain.c on Windows (added in rL351228)

krisb created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56776 Files: test/Driver/msp430-toolchain.c Index: test/Driver/msp430-toolchain.c === --- test/Driver/msp430-t

[clang-tools-extra] r351319 - Fix build breakage from llvm r351317

Author: labath Date: Wed Jan 16 02:26:52 2019 New Revision: 351319 URL: http://llvm.org/viewvc/llvm-project?rev=351319&view=rev Log: Fix build breakage from llvm r351317 The two-argument version of llvm::sys::fs::make_absolute no longer returns an error code. Modified: clang-tools-extra/tru

[PATCH] D56718: [clangd] Update docs to mention YCM integration and new LSP features

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: docs/clangd.rst:129 +`Installation section on your OS +`_ for instructions. + ilya-biryukov wrote: > I believe this does

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia marked an inline comment as done. Anastasia added a comment. In D55850#1358812 , @rjmccall wrote: > Okay, so is this ready to re-review independently? Yes, please. It should be fine to review on its own. Thanks! CHANGES SINCE LAST ACTION ht

[clang-tools-extra] r351320 - Bump the trunk version to 9.0.0svn

Author: hans Date: Wed Jan 16 02:57:02 2019 New Revision: 351320 URL: http://llvm.org/viewvc/llvm-project?rev=351320&view=rev Log: Bump the trunk version to 9.0.0svn Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk/docs/conf.py Modified: clang-tools-extra/t

r351320 - Bump the trunk version to 9.0.0svn

Author: hans Date: Wed Jan 16 02:57:02 2019 New Revision: 351320 URL: http://llvm.org/viewvc/llvm-project?rev=351320&view=rev Log: Bump the trunk version to 9.0.0svn Modified: cfe/trunk/docs/ReleaseNotes.rst cfe/trunk/docs/conf.py Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://ll

[libunwind] r351320 - Bump the trunk version to 9.0.0svn

Author: hans Date: Wed Jan 16 02:57:02 2019 New Revision: 351320 URL: http://llvm.org/viewvc/llvm-project?rev=351320&view=rev Log: Bump the trunk version to 9.0.0svn Modified: libunwind/trunk/CMakeLists.txt libunwind/trunk/docs/conf.py Modified: libunwind/trunk/CMakeLists.txt URL: http:

[libunwind] r351321 - Creating release_80 branch off revision 351319

Author: hans Date: Wed Jan 16 03:00:55 2019 New Revision: 351321 URL: http://llvm.org/viewvc/llvm-project?rev=351321&view=rev Log: Creating release_80 branch off revision 351319 Added: libunwind/branches/release_80/ - copied from r351319, libunwind/trunk/ __

[libclc] r351321 - Creating release_80 branch off revision 351319

Author: hans Date: Wed Jan 16 03:00:55 2019 New Revision: 351321 URL: http://llvm.org/viewvc/llvm-project?rev=351321&view=rev Log: Creating release_80 branch off revision 351319 Added: libclc/branches/release_80/ - copied from r351319, libclc/trunk/

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

xazax.hun accepted this revision. xazax.hun added a comment. Thanks, LGTM! It is interesting to see if we need to traverse all the super regions in `scanReachableSymbols`, but if we need to change something there, I would prefer that to be in a separate patch. If visiting the whole super region

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space coversions

Anastasia added a comment. In D56735#1358222 , @rjmccall wrote: > Is there a reason not to just do `T1.getQualifiers() == T2.getQualifiers()`? I tried this but it causes ObjC test to fail test/SemaObjCXX/arc-overloading.mm. 38 // Simple overloading

[PATCH] D55850: [OpenCL] Allow address spaces as method qualifiers

Anastasia updated this revision to Diff 182012. Anastasia added a comment. Fixed wording on the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55850/new/ https://reviews.llvm.org/D55850 Files: include/clang/Sema/ParsedAttr.h lib/Parse/ParseDecl.cpp lib/Sema/SemaOverload.c

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

Szelethus added inline comments. Comment at: test/Analysis/symbol-reaper.cpp:31 + clang_analyzer_eval(glob); // expected-warning{{TRUE}} + // expected-warning@-1{{SYMBOL DEAD}} +} NoQ wrote: > Szelethus wrote: > > N00b question: What

[PATCH] D56751: [ASTDump] Mark variadic declarations with a tag instead of child node

aaron.ballman added a comment. Can you add a test for a variadic lambda in C++ as well? I suspect it will work out of the box, but the extra test coverage would be good to have. We should probably have a K&R C function example as well to ensure it doesn't print as variadic. e.g., `void func();`

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov added a comment. Will take a look. For reference: the particular failing test was added in r351222 (D56680 ), not in this change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

aaron.ballman added a comment. Do we have any test coverage for this change? IIRC, this was one we couldn't figure out how to trigger? Comment at: lib/AST/ASTDumper.cpp:637 + if (!D->param_begin() && D->getNumParams()) +OS << " >"; +

r351334 - Set '-target' flag in the test checking the MacOS include dir

Author: ibiryukov Date: Wed Jan 16 05:18:59 2019 New Revision: 351334 URL: http://llvm.org/viewvc/llvm-project?rev=351334&view=rev Log: Set '-target' flag in the test checking the MacOS include dir To fix a buildbot failure on PS4, see http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov added a comment. r351334 should fix this. However, this is an indication that libc++ living alongside the compiler (i.e. in `/bin/../include/c++/v1`) cannot be found on PS4. I am not familiar with PS4 myself, but I believe it would be reasonable to assume finding libc++ living alon

[PATCH] D56752: [ASTDump] Mark BlockDecls which capture this with a tag

aaron.ballman added a comment. Was there no test coverage for this situation? If not, can you add some? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56752/new/ https://reviews.llvm.org/D56752 ___ cfe-commits mailing

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

aaron.ballman added inline comments. Comment at: lib/AST/ASTDumper.cpp:637 + if (!D->param_begin() && D->getNumParams()) +OS << " >"; + aaron.ballman wrote: > Extra whitespace at the start of the string literal, or is that intentional?

[libunwind] r351338 - Drop svn version suffix

Author: hans Date: Wed Jan 16 05:27:08 2019 New Revision: 351338 URL: http://llvm.org/viewvc/llvm-project?rev=351338&view=rev Log: Drop svn version suffix Modified: libunwind/branches/release_80/CMakeLists.txt Modified: libunwind/branches/release_80/CMakeLists.txt URL: http://llvm.org/viewv

r351340 - [MSP430] Fix msp430-toolchain.c on Windows (added in r351228)

Author: asl Date: Wed Jan 16 05:28:30 2019 New Revision: 351340 URL: http://llvm.org/viewvc/llvm-project?rev=351340&view=rev Log: [MSP430] Fix msp430-toolchain.c on Windows (added in r351228) Patch by Kristina Bessonova! Differential Revision: https://reviews.llvm.org/D56776 Modified: cfe/

[PATCH] D56776: [MSP430] Fix msp430-toolchain.c on Windows (added in rL351228)

This revision was automatically updated to reflect the committed changes. Closed by commit rC351340: [MSP430] Fix msp430-toolchain.c on Windows (added in r351228) (authored by asl, committed by ). Changed prior to commit: https://reviews.llvm.org/D56776?vs=181998&id=182017#toc Repository: rC

Re: r351334 - Set '-target' flag in the test checking the MacOS include dir

Merged to 8.0 in r351343. On Wed, Jan 16, 2019 at 2:22 PM Ilya Biryukov via cfe-commits wrote: > > Author: ibiryukov > Date: Wed Jan 16 05:18:59 2019 > New Revision: 351334 > > URL: http://llvm.org/viewvc/llvm-project?rev=351334&view=rev > Log: > Set '-target' flag in the test checking the MacOS

r351344 - [MSP430] Improve support of 'interrupt' attribute

Author: asl Date: Wed Jan 16 05:44:01 2019 New Revision: 351344 URL: http://llvm.org/viewvc/llvm-project?rev=351344&view=rev Log: [MSP430] Improve support of 'interrupt' attribute * Accept as an argument constants in range 0..63 (aligned with TI headers and linker scripts provided with TI GCC to

[PATCH] D56663: [MSP430] Improve support of 'interrupt' attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL351344: [MSP430] Improve support of 'interrupt' attribute (authored by asl, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D56663: [MSP430] Improve support of 'interrupt' attribute

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5388 + + if (hasFunctionProto(D) && getFunctionOrMethodNumParams(D) != 0) { +S.Diag(D->getLocation(), diag::warn_msp430_interrupt_attribute) What should happen if the function does no

Re: r351160 - [X86] Make _xgetbv/_xsetbv on non-windows platforms

v8 is fixed, feel free to land this after the release branch :) On Wed, Jan 16, 2019 at 12:57 AM Craig Topper wrote: > This isn't blocking anything. Just doing some archaeology because I > noticed we had an intrinsic in the backend, but it wasn't used by the > frontend due to a previous revert a

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

aaron.ballman added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return MakeCXType(ATT->getModifiedType(), TU); -

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On Wed, Jan 16, 2019 at 1:57 AM Akira Hatanaka wrote: > > Yes, the behavior of the compiler doesn’t match what’s explained in the > documentation anymore. > > Please take a look at the attached patch, which updates the documentation. Patch mostly LGTM, but I did have one wording suggestion. > d

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

Hi Sam, Unfortunately this trips up a variety of buildbots: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/22376 http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/15053 http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/22376 http://lab.llvm.org:801

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

Lekensteyn added a comment. Changes still look reasonable, but the preceding path (https://reviews.llvm.org/D56769) needs some work. Comment at: lib/CodeGen/CGDebugInfo.cpp:607 llvm::DIFile *CUFile = DBuilder.createFile( - remapDIPath(MainFileName), remapDIPath(getCurr

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm marked an inline comment as done. dankm added a comment. I'll update the style nit, and spend some non-tired time on the string remapping. Thanks Comment at: lib/CodeGen/CGDebugInfo.cpp:607 llvm::DIFile *CUFile = DBuilder.createFile( - remapDIPath(MainFileName)

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 182037. dankm added a comment. Update style. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Options.td in

[clang-tools-extra] r351348 - [clang-tidy] Move the macro helper function to a common location; NFC

Author: hwright Date: Wed Jan 16 06:49:32 2019 New Revision: 351348 URL: http://llvm.org/viewvc/llvm-project?rev=351348&view=rev Log: [clang-tidy] Move the macro helper function to a common location; NFC This is useful for multiple checks. Modified: clang-tools-extra/trunk/clang-tidy/abseil/

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

+Ilya who understands the test better... Some are fixed by r351334 with -target, Ilya could you take a look at windows? Otherwise we could use REQUIRES... On Wed, Jan 16, 2019, 15:16 Jeremy Morse Hi Sam, > > Unfortunately this trips up a variety of buildbots: > > http://lab.llvm.org:8011/bui

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright updated this revision to Diff 182043. hwright marked 6 inline comments as done. hwright added a comment. Address reviewer comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/ https://reviews.llvm.org/D56532 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-ti

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:47-48 // if nothing needs to be done. - if (!IsValidMacro(Result, Binop->getLHS()) || - !IsValidMacro(Result, Binop->getRHS())) + if (!isNotInMacro(Result, Binop->getLHS()) || +

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

Lekensteyn added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:607 llvm::DIFile *CUFile = DBuilder.createFile( - remapDIPath(MainFileName), remapDIPath(getCurrentDirname()), CSInfo, + MainFileName, remapDIPath(getCurrentDirname()), CSInfo, getSource

[PATCH] D56663: [MSP430] Improve support of 'interrupt' attribute

krisb added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5388 + + if (hasFunctionProto(D) && getFunctionOrMethodNumParams(D) != 0) { +S.Diag(D->getLocation(), diag::warn_msp430_interrupt_attribute) aaron.ballman wrote: > What should happen if the f

r351350 - Added a test case for dumping blocks that capture 'this'; NFC.

Author: aaronballman Date: Wed Jan 16 07:40:23 2019 New Revision: 351350 URL: http://llvm.org/viewvc/llvm-project?rev=351350&view=rev Log: Added a test case for dumping blocks that capture 'this'; NFC. Modified: cfe/trunk/test/AST/ast-dump-decl.mm Modified: cfe/trunk/test/AST/ast-dump-decl.m

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 182047. dankm added a comment. Undo accidental change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Optio

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm marked an inline comment as done. dankm added a comment. Sure, I'll (eventually) make a separate review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 ___ cfe-commits

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1359275 , @rjmccall wrote: > In D56411#1352602 , @yaxunl wrote: > > > In D56411#1352332 , @rjmccall > > wrote: > > > > > This patch still d

[PATCH] D56786: Changes to `CXXMemberExpr` matchers.

ymandel created this revision. Herald added a subscriber: cfe-commits. Assorted changes to matchers for `CXXMemberExpr`: - fixes the comments on `hasObjectExpression`, - clarifies comments on `thisPointerType` and `on`, - adds comments to `onImplicitObjectArgument` - adds new matcher `invokedAtTy

[PATCH] D56786: Changes to `CXXMemberExpr` matchers.

steveire added a comment. Can you break this up into multiple commits? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56786/new/ https://reviews.llvm.org/D56786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r351355 - Added test cases for dumping variadic-like functions; NFC.

Author: aaronballman Date: Wed Jan 16 08:12:30 2019 New Revision: 351355 URL: http://llvm.org/viewvc/llvm-project?rev=351355&view=rev Log: Added test cases for dumping variadic-like functions; NFC. Modified: cfe/trunk/test/AST/ast-dump-decl.c cfe/trunk/test/AST/ast-dump-expr.cpp cfe/t

[PATCH] D56786: Changes to `CXXMemberExpr` matchers.

ymandel added a comment. In D56786#1359879 , @steveire wrote: > Can you break this up into multiple commits? Sure, but any suggestions on granularity? E.g. i can split into two: the fixes/clarifications in one and the new matcher in another; or i could

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

lebedev.ri added a comment. In D56786#1359903 , @ymandel wrote: > In D56786#1359879 , @steveire wrote: > > > Can you break this up into multiple commits? > > > Sure, but any suggestions on granularity? E.g. i can s

[PATCH] D56731: Add -Wimplicit-ctad warning to diagnose CTAD on types with no user defined deduction guides.

gromer marked an inline comment as done. gromer added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2129 +def warn_class_template_argument_deduction_no_user_defined_guides : Warning< + "using class template argument deduction for %0 that has no user-def

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On 16 Jan 2019, at 9:13, Aaron Ballman wrote: On Wed, Jan 16, 2019 at 1:57 AM Akira Hatanaka wrote: Yes, the behavior of the compiler doesn’t match what’s explained in the documentation anymore. Please take a look at the attached patch, which updates the documentation. Patch mostly LG

[PATCH] D56790: [OpenMP] Update release notes with OpenMP related changes

gtbercea created this revision. gtbercea added reviewers: ABataev, caomhin. Herald added subscribers: cfe-commits, guansong. Update release notes with OpenMP related changes. Repository: rC Clang https://reviews.llvm.org/D56790 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst ==

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

steveire added a comment. It is always valuable to split changes which are independent. Usually you can extract NFC changes first and then look at what remains to split it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56786/new/ https://reviews.llvm.org/D56786

[PATCH] D56066: [OpenCL] Address space for default class members

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGCall.cpp:78 +RecTy = Context.getAddrSpaceQualType( +RecTy, MD->getTypeQualifiers().getAddressSpace()); return Context.getPointerType(CanQualType::CreateUnsafe(Rec

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space conversions

rjmccall added a comment. In D56735#1359590 , @Anastasia wrote: > In D56735#1358222 , @rjmccall wrote: > > > Is there a reason not to just do `T1.getQualifiers() == T2.getQualifiers()`? > > > I tried this but it cau

[PATCH] D56792: Rename getTypeQualifiers to getMethodQualifiers

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added subscribers: arphaman, eraman. Use more descriptive name for the method qualifiers getter. This change was suggested in https://reviews.llvm.org/D56066?id=179477#inline-496961 https://reviews.llvm.org/D56792 F

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

rjmccall added a comment. I think the diagnostic should come during instantiation when you find an evaluated use of a host function within a device function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56411/new/ https://reviews.llvm.org/D56411

[PATCH] D56790: [OpenMP] Update release notes with OpenMP related changes

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, but you need to commit it into release 8.0 Comment at: docs/ReleaseNotes.rst:261 + +- Flag for user to limit collapsed loop counter width when safe to do so. +

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

We do rather need this working for our downstream merging to continue, and to clear up the buildbots -- without objection I'll drop the "REQUIRES: system-darwin" line in there. Depending on what's actually supposed to be tested that might be sufficient, but please do follow up. -- Thanks, Jeremy

[PATCH] D56792: Rename getTypeQualifiers to getMethodQualifiers

rjmccall accepted this revision. rjmccall added a reviewer: rsmith. rjmccall added a comment. LGTM, but I'd like Richard to also sign off on the name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56792/new/ https://reviews.llvm.org/D56792

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov updated this revision to Diff 182078. ilya-biryukov added a comment. Herald added a subscriber: mgrang. - Rename ActionProvider to Tweak - Update an interface of Tweak - ActionInputs -> Tweak::Selection - Remove CodeAction.h, use tweak registry instead Repository: rCTE Clang Tool

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov updated this revision to Diff 182079. ilya-biryukov added a comment. - Update after changes to parent revision Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 Files: clangd/CMakeLists.txt c

r351360 - Add a REQUIRES: darwin line for a mac test.

Author: jmorse Date: Wed Jan 16 09:41:29 2019 New Revision: 351360 URL: http://llvm.org/viewvc/llvm-project?rev=351360&view=rev Log: Add a REQUIRES: darwin line for a mac test. This test, apparently for macs, fails on Windows as lit can't emulate the shell subprocess $(which...) correctly. Some o

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182080. ilya-biryukov added a comment. - Update after changes to parent revision Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clangd/CMakeLists.txt c

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov updated this revision to Diff 182082. ilya-biryukov added a comment. - Update after changes to parent revision Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56612/new/ https://reviews.llvm.org/D56612 Files: clangd/AST.cpp clangd/A

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

Platform REQUIRES added in r351360, please do revert & fix if this test is supposed to work elsewhere. -- Thanks, Jeremy ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov added inline comments. Comment at: clangd/SourceCode.h:64 +/// Turns a token range into a half-open range and checks its correctness. +/// The resulting range will have only valid source location on both sides, both jkorous wrote: > It seems to m

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space conversions

Anastasia updated this revision to Diff 182084. Anastasia added a comment. - Changed the condition to use all qualifiers except for ObjC ownership ones. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56735/new/ https://reviews.llvm.org/D56735 Files: lib/Sema/SemaOverload.cpp test/Se

[PATCH] D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl

shafik added a comment. Thank you, this looks good but perhaps some refactoring would help improve the change. Comment at: lib/AST/ASTImporter.cpp:3243 + + if (R) { +CXXDestructorDecl *ToDtor = cast(*R); a_sidorin wrote: > It's better to move this code to

Re: r344241 - [tests] Include Python binding tests in CMake rules

(Follow-up: Michał landed a fix in r351304. Thanks!) On Tue, Jan 15, 2019 at 1:21 PM Nico Weber wrote: > As long as check-all passes with LLVM_ENABLE_PIC=OFF I'm happy :-) (Note > it's .dylib on macOS and .dll on Windows, and by default > setting LLVM_ENABLE_PIC=OFF causes a static library to be

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 182092. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In D53738#1359135 , @rjmccall wrote: > I think that's the right direction, yeah. > > I thought I told you it was fine to commit this patch under that assumption > awhile ago. Did I just never click "accept"? Whoops. I don't

r351364 - [Fixed Point Arithmetic] Fixed Point Addition

Author: leonardchan Date: Wed Jan 16 10:13:59 2019 New Revision: 351364 URL: http://llvm.org/viewvc/llvm-project?rev=351364&view=rev Log: [Fixed Point Arithmetic] Fixed Point Addition This patch covers addition between fixed point types and other fixed point types or integers, using the conversio

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

This revision was automatically updated to reflect the committed changes. Closed by commit rL351364: [Fixed Point Arithmetic] Fixed Point Addition (authored by leonardchan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53738?vs=17686

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

ymandel marked 2 inline comments as done. ymandel added a comment. In D56786#1359920 , @lebedev.ri wrote: > In D56786#1359903 , @ymandel wrote: > > > In D56786#1359879 , @ste

Re: r351316 - Reapply [Tooling] Make clang-tool find libc++ dir on mac when running on a file without compilation database.

> > Unfortunately this trips up a variety of buildbots: > Platform REQUIRES added in r351360, please do revert & fix if this test is supposed to work elsewhere. Looks like the test fail just made it into the release-8.0.0 branch by a few commits. I think we'll need Jeremy's fix r351360 or/and any

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov updated this revision to Diff 182102. ilya-biryukov added a comment. - Fix a typo in the id of the SwapIfBranches Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https://reviews.llvm.org/D56611 Files: clangd/CMakeLists.txt

r351368 - [Fixed Point Arithmetic] Add APFixedPoint to APValue

Author: leonardchan Date: Wed Jan 16 10:53:05 2019 New Revision: 351368 URL: http://llvm.org/viewvc/llvm-project?rev=351368&view=rev Log: [Fixed Point Arithmetic] Add APFixedPoint to APValue This adds APFixedPoint to the union of values that can be represented with an APValue. Differential Revi

[PATCH] D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue

This revision was automatically updated to reflect the committed changes. Closed by commit rC351368: [Fixed Point Arithmetic] Add APFixedPoint to APValue (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D56746?vs=181918&id=182103#toc Repository: rC

[PATCH] D56735: [OpenCL] Fix overloading ranking rules to work correctly for address space conversions

rjmccall added a comment. Thanks, LGTM. Well, actually, could you improve the test case to verify that the right overload is called? This should be easy because C++ type-checking is bottom-up: just make the functions return something distinguishable, e.g. `struct`s that declare different memb

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3451 + case BO_Comma: +llvm_unreachable("Found unimplemented fixed point binary operation"); } rjmccall wrote: > Please create a separate case for the non-arithmetic operato

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

leonardchan updated this revision to Diff 182108. leonardchan marked 2 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55844/new/ https://reviews.llvm.org/D55844 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/fixed_point_s

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

rjmccall added a comment. I don't pay attention to "ready to land" because I assume that you're verifying that your patch actually works as promised in practice, at least as far as the tests are concerned (and presumably my review catches deeper issues). If there are substantial changes that la

  1   2   >