dankm marked an inline comment as done.
dankm added a comment.
I'll update the style nit, and spend some non-tired time on the string
remapping. Thanks
================
Comment at: lib/CodeGen/CGDebugInfo.cpp:607
llvm::DIFile *CUFile = DBuilder.createFile(
- remapDIPath(MainFileName), remapDIPath(getCurrentDirname()), CSInfo,
+ MainFileName, remapDIPath(getCurrentDirname()), CSInfo,
getSource(SM, SM.getMainFileID()));
----------------
Lekensteyn wrote:
> Any reason for dropping `remapDIPath` here? Wouldn't this result in the full
> path being included even when using:
>
> clang -fdebug-prefix-map=/full/path/= /full/path/source.c
Whoops. That probably shouldn't have been included this round. This is a
bugfix. MainFileName is already remapped from earlier in this function, this
keeps it from remapping twice if you have an empty old prefix.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D49466/new/
https://reviews.llvm.org/D49466
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
