[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

MyDeveloperDay updated this revision to Diff 181497. MyDeveloperDay added a comment. Fix review comments s/the checker will check/the check will ensure/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56563/new/ https://reviews.llvm.org/D56563 Files: docs/clang-tidy/checks/readability

[PATCH] D56066: [OpenCL] Address space for default class members

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Great, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56066/new/ https://reviews.llvm.org/D56066 ___ cfe-commits mailing list c

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

rjmccall added a comment. It's pretty unfortunate that all these fields have to be individually called out like this. Can you move all these basic layout fields into a separate `struct` (which can be a secondary base class of `TargetInfo`) which can then just be normally copied? Anything that

[PATCH] D56429: fix python3 compability issue

serge-sans-paille added inline comments. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(contents, "read"): +contents = contents.read() serge-sans-pai

r351036 - [X86] Remove mask parameter from avx512 pmultishiftqb intrinsics. Use select in IR instead.

Author: ctopper Date: Mon Jan 14 00:46:51 2019 New Revision: 351036 URL: http://llvm.org/viewvc/llvm-project?rev=351036&view=rev Log: [X86] Remove mask parameter from avx512 pmultishiftqb intrinsics. Use select in IR instead. Fixes PR40259 Modified: cfe/trunk/include/clang/Basic/BuiltinsX86

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille updated this revision to Diff 181498. Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55782/new/ https://reviews.llvm.org/D55782 Files: include/clang/Basic/SourceManager.h test/Misc/no-warn-in-system-macr

[PATCH] D53153: [OpenCL] Mark kernel functions with default visibility

rjmccall added a comment. In D53153#1353256 , @scott.linder wrote: > In D53153#1317977 , @rjmccall wrote: > > > I think `-fvisibility=hidden` isn't good enough because you want to infer > > hidden visibility even

[PATCH] D56655: [clangd] Fix mac buildbot failure.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Fix a use-after-free bug. The inner loop may add element to `Dependencies` vector, which may cause memory reallocation of the vector. Also fix an assertion

[PATCH] D56655: [clangd] Fix mac buildbot failure.

hokein updated this revision to Diff 181502. hokein added a comment. remove unrelated blank changes. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56655/new/ https://reviews.llvm.org/D56655 Files: clangd/index/Background.cpp Index: clangd/index

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

mgorny added a comment. Ping. I'd really like to merge this before the branch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47819/new/ https://reviews.llvm.org/D47819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D56592: [clangd] Do not override contents of the shards without modification

ilya-biryukov added inline comments. Comment at: clangd/index/Background.cpp:309 for (const auto &I : *Index.Sources) { +// We already have the map from uris to absolutepaths in the cache, +// therefore traverse Index.Sources rather than Files to get rid of absolute -

[PATCH] D56656: [clangd] Fix a reference invalidation

kadircet created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Fix for the breakage in http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/52811/consoleFull#-42777206a1ca8a51-895e-46c6-af87-ce24fa4cd561 Repository: rCTE Cla

[clang-tools-extra] r351041 - [clangd] Index main-file symbols (bug 39761)

Author: sammccall Date: Mon Jan 14 02:01:17 2019 New Revision: 351041 URL: http://llvm.org/viewvc/llvm-project?rev=351041&view=rev Log: [clangd] Index main-file symbols (bug 39761) Patch by Nathan Ridge! Differential Revision: https://reviews.llvm.org/D55185 Modified: clang-tools-extra/trun

[PATCH] D56656: [clangd] Fix a reference invalidation

ilya-biryukov added inline comments. Comment at: clangd/index/Background.cpp:517 +// well. +CurDependencyPath = Dependencies[CurrentDependency].Path; + } We should avoid modifying the container we're iterating over instead. I suggest we separ

[PATCH] D55185: [Clangd] Index main-file symbols (bug 39761)

This revision was automatically updated to reflect the committed changes. Closed by commit rL351041: [clangd] Index main-file symbols (bug 39761) (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D55185: [Clangd] Index main-file symbols (bug 39761)

sammccall updated this revision to Diff 181510. sammccall added a comment. Herald added a subscriber: cfe-commits. add comment about subtleties around canonical declarations and main-file check invert sense of Symbol flag (FileLocal -> VisibleOutsideFile) so Merge does the right thing test: add c

[PATCH] D56656: [clangd] Fix a reference invalidation

kadircet updated this revision to Diff 181512. kadircet added a comment. - Change traversal logic to use two different containers Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56656/new/ https://reviews.llvm.org/D56656 Files: clangd/index/Backgro

[PATCH] D55185: [Clangd] Index main-file symbols (bug 39761)

sammccall added a comment. The forward-declaration-in-main-file case: In principle, if the definition is missing, I think we should treat these differently (not index them, or treat them as visible-outside file) because they're almost certainly declared "properly" elsewhere. @ilya-biryukov convi

[libunwind] r351044 - [Sparc] Add Sparc V8 support

Author: dcederman Date: Mon Jan 14 02:15:20 2019 New Revision: 351044 URL: http://llvm.org/viewvc/llvm-project?rev=351044&view=rev Log: [Sparc] Add Sparc V8 support Summary: Adds the register class implementation for Sparc. Adds support for DW_CFA_GNU_window_save. Adds save and restore context fu

[PATCH] D56656: [clangd] Fix a reference invalidation

ilya-biryukov added inline comments. Comment at: clangd/index/Background.cpp:488 +Dependencies.push_back(std::move(ToVisit.front())); +auto &CurDependency = Dependencies.back(); +ToVisit.pop(); This reference makes it just as easy to access the vector

[PATCH] D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.

courbet created this revision. Herald added subscribers: cfe-commits, xazax.hun. Context: https://twitter.com/willkirkby/status/1084219580799741953 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56657 Files: clang-tidy/bugprone/StringConstructorCheck.cpp test/clang-tidy/bug

[PATCH] D56656: [clangd] Fix a reference invalidation

ilya-biryukov added inline comments. Comment at: clangd/index/Background.cpp:488 +Dependencies.push_back(std::move(ToVisit.front())); +auto &CurDependency = Dependencies.back(); +ToVisit.pop(); ilya-biryukov wrote: > This reference makes it just as ea

[PATCH] D56656: [clangd] Fix a reference invalidation

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, but please add a comment the vector is not modified (it might be useful as a reminder in case we want to change the code later) Repository: rCTE Clang Tools Extra CHANG

r351047 - [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

Author: sammccall Date: Mon Jan 14 02:31:42 2019 New Revision: 351047 URL: http://llvm.org/viewvc/llvm-project?rev=351047&view=rev Log: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on. Summary: This fixes ASTContext's parent map for nodes in such classes (e.g. opera

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

This revision was automatically updated to reflect the committed changes. Closed by commit rL351047: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.

courbet updated this revision to Diff 181519. courbet added a comment. Remove commented code. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56657/new/ https://reviews.llvm.org/D56657 Files: clang-tidy/bugprone/StringConstructorCheck.cpp test/cl

[PATCH] D56552: [clang-tidy] update FunctionSizeCheck for D56444

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351048: [clang-tidy] update FunctionSizeCheck for D56444 (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D56552?vs=181082&id=181520#toc Repository: rCTE Cl

[clang-tools-extra] r351048 - [clang-tidy] update FunctionSizeCheck for D56444

Author: sammccall Date: Mon Jan 14 02:40:41 2019 New Revision: 351048 URL: http://llvm.org/viewvc/llvm-project?rev=351048&view=rev Log: [clang-tidy] update FunctionSizeCheck for D56444 Reviewers: JonasToth, aaron.ballman Subscribers: xazax.hun, cfe-commits Differential Revision: https://reviews

[PATCH] D56532: [clang-tidy] Add the abseil-duration-conversion-cast check

hwright added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56532/new/ https://reviews.llvm.org/D56532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D55256: [clangd] Support clang-tidy configuration in clangd.

ilya-biryukov added a comment. Just a small comment wrt to a particular change in `ClangdLSPServer`. I haven't looked at the patch more closely, though. Comment at: clangd/ClangdLSPServer.h:132 - RealFileSystemProvider FSProvider; /// Options used for code completion ---

[PATCH] D56644: [clang-tidy] readability-container-size-empty handle std::string length()

JonasToth added a comment. Could you please run it over LLVM or another significant codebase and check if there are miss-transformations (run with fix and then compile (+ tests optimally))? You can use `clang-tidy/tool/run-clang-tidy.py` for a parallel runner. Repository: rCTE Clang Tools Ex

[clang-tools-extra] r351051 - [clangd] Unlink VFS working dir from OS working dir.

Author: sammccall Date: Mon Jan 14 03:06:48 2019 New Revision: 351051 URL: http://llvm.org/viewvc/llvm-project?rev=351051&view=rev Log: [clangd] Unlink VFS working dir from OS working dir. A lot of our previous FS manipulation was thread-unsafe in practice with the RealFS implementation. This sw

[PATCH] D56656: [clangd] Fix a reference invalidation

kadircet updated this revision to Diff 181524. kadircet added a comment. - Add a comment Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56656/new/ https://reviews.llvm.org/D56656 Files: clangd/index/Background.cpp Index: clangd/index/Background.

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:578 +bool Invalid; +StringRef Buffer = SM.getBufferData(SM.getFileID(StartLoc), &Invalid); +if (!Invalid) { malaperle wrote: > ilya-biryukov wrote: > > Unfortunately we can't get the bu

[clang-tools-extra] r351052 - [clangd] Fix a reference invalidation

Author: kadircet Date: Mon Jan 14 03:24:07 2019 New Revision: 351052 URL: http://llvm.org/viewvc/llvm-project?rev=351052&view=rev Log: [clangd] Fix a reference invalidation Summary: Fix for the breakage in http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/52811/consoleFull#-42777206a

[PATCH] D56656: [clangd] Fix a reference invalidation

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351052: [clangd] Fix a reference invalidation (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D56656?vs=181524&id=181525#toc Repository: rCTE Clang Tools Ex

[PATCH] D56597: [clangd] Add Limit parameter for xref.

sammccall added inline comments. Comment at: clangd/XRefs.cpp:724 } - + if (!Limit) +Limit = std::numeric_limits::max(); nit: move this to the top, since it's just adjusting input params? Comment at: clangd/XRefs.cpp:730 for (const a

r351053 - [OpenCL] Set generic addr space of 'this' in special class members.

Author: stulova Date: Mon Jan 14 03:44:22 2019 New Revision: 351053 URL: http://llvm.org/viewvc/llvm-project?rev=351053&view=rev Log: [OpenCL] Set generic addr space of 'this' in special class members. Set address spaces of 'this' param correctly for implicit special class members. This also cha

[PATCH] D56066: [OpenCL] Address space for default class members

This revision was automatically updated to reflect the committed changes. Closed by commit rL351053: [OpenCL] Set generic addr space of 'this' in special class members. (authored by stulova, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina updated this revision to Diff 181528. MarinaKalashina marked an inline comment as done. MarinaKalashina added a comment. files renamed: //contribution.rst// to //Contributing.rst//, // integrations.rst// to //Integrations.rst// CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina added a comment. @Eugene.Zelenko > I would suggest to rename contribution to Contributing (see LLVM > documentation) and integrations to Integrations. Sure, done. > Will be also good idea to fix D55523 script > warnings. The script warns abou

[PATCH] D56658: [MSP430] Add msp430 toochain

krisb created this revision. Herald added subscribers: cfe-commits, arichardson, mgorny, emaste. Herald added a reviewer: espindola. This is an initial implementation for msp430 toolchain including - -mmcu option support - -mhwmult options support - -integrated-as by default - msp430-elf-as as a

[PATCH] D56488: clang-cl: Align help texts for /O1 and O2

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56488/new/ https://reviews.llvm.org/D56488 ___ cfe-commits mailing list cfe-commi

[PATCH] D56489: clang-cl: Fix help text for /O: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56489/new/ https://reviews.llvm.org/D56489 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D56488: clang-cl: Align help texts for /O1 and O2

This revision was automatically updated to reflect the committed changes. Closed by commit rL351061: clang-cl: Align help texts for /O1 and O2 (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56488?vs=180832&id=181533

r351061 - clang-cl: Align help texts for /O1 and O2

Author: nico Date: Mon Jan 14 04:41:13 2019 New Revision: 351061 URL: http://llvm.org/viewvc/llvm-project?rev=351061&view=rev Log: clang-cl: Align help texts for /O1 and O2 Makes it a bit easier to see what exactly the difference is. Also use "same as" instead of "equivalent to", because that's

[PATCH] D56489: clang-cl: Fix help text for /O: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'

This revision was automatically updated to reflect the committed changes. Closed by commit rL351062: clang-cl: Fix help text for /O: '/O2y-' means '/O2 /Oy-', not '/O2 /y-' (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

r351062 - clang-cl: Fix help text for /O: '/O2y-' means '/O2 /Oy-', not '/O2 /y-'

Author: nico Date: Mon Jan 14 04:42:35 2019 New Revision: 351062 URL: http://llvm.org/viewvc/llvm-project?rev=351062&view=rev Log: clang-cl: Fix help text for /O: '/O2y-' means '/O2 /Oy-', not '/O2 /y-' Differential Revision: https://reviews.llvm.org/D56489 Modified: cfe/trunk/include/clang/

[PATCH] D56592: [clangd] Do not override contents of the shards without modification

kadircet updated this revision to Diff 181540. kadircet marked an inline comment as done. kadircet added a comment. - Change the logic to detect updated files to take new files without any symbols into account. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index

Quolyk created this revision. Quolyk added reviewers: aaron.ballman, alexfh, JonasToth, omtcyfz. Herald added subscribers: cfe-commits, arphaman, kbarton, xazax.hun, nemanjai. This patch fixes incorrect array name generation for a cppcoreguidelines-pro-bounds-constant-array-index warning. Motivat

[PATCH] D56661: [clang-tidy] Fix incorrect array name generation in cppcoreguidelines-pro-bounds-constant-array-index

Quolyk added a comment. For now I just updated tests. The problem is in `BaseRange` definition, as it holds `EndLoc` and `BeginLoc` pointing to the beginning of ArrayExpression base https://github.com/llvm-mirror/clang-tools-extra/blob/e0441f6939da38f26bea9c1d75bb33024daa4e40/clang-tidy/cppcoreg

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

kadircet added inline comments. Comment at: clangd/index/Background.cpp:309 for (const auto &I : *Index.Sources) { +// We already have the map from uris to absolutepaths in the cache, +// therefore traverse Index.Sources rather than Files to get rid of absolute --

[PATCH] D56655: [clangd] Fix mac buildbot failure.

kadircet added a comment. https://reviews.llvm.org/D56656 has landed to fix that issue Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56655/new/ https://reviews.llvm.org/D56655 ___ cfe-commits mailing li

Re: r351012 - Implement TemplateArgument dumping in terms of Visitor

On Sat, Jan 12, 2019 at 11:39 AM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Sat Jan 12 08:35:37 2019 > New Revision: 351012 > > URL: http://llvm.org/viewvc/llvm-project?rev=351012&view=rev > Log: > Implement TemplateArgument dumping in terms of Visitor > > Summary: Split the

[PATCH] D56267: [clangd] Interfaces for writing code actions

sammccall added a comment. High level comments: - this is an important concept and in hindsight it's amazing we didn't have it yet! - I don't get a clear sense of the boundaries between "code action", "refactoring", and "action". There are also "prepared actions" and "instant actions". I thi

[PATCH] D56639: NFC: Move Type Visit implementation to TextNodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: lib/AST/ASTDumper.cpp:434 +NodeDumper.Visit(T); if (!T) { return; Elide braces.

[PATCH] D56650: [lld] [ELF] Support inferring target triple from filename

arichardson added a comment. I'm happy with this approach since the triple can be set on the commandline. If this gets merged I will update CHERI lld to use the triple instead of the new emulation that we added. Comment at: ELF/Driver.cpp:757 + if (!TargetOpt.empty()) { +

[PATCH] D56640: NFC: Canonicalize handling of TypeLocInfo

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56640/new/ https://reviews.llvm.org/D56640 ___

[PATCH] D56641: NFC: Move dumping of QualType node to TextNodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56641/new/ https://reviews.llvm.org/D56641 ___

[PATCH] D56643: NFC: Move Decl node handling to TextNodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: lib/AST/ASTDumper.cpp:518 +NodeDumper.Visit(D); if (!D) { return; Elide braces.

[PATCH] D56597: [clangd] Add Limit parameter for xref.

hokein updated this revision to Diff 181543. hokein marked 14 inline comments as done. hokein added a comment. Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56597/new/ https://reviews.llvm.org/D56597 Files: clangd/ClangdLSPServe

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:578 +bool Invalid; +StringRef Buffer = SM.getBufferData(SM.getFileID(StartLoc), &Invalid); +if (!Invalid) { ilya-biryukov wrote: > malaperle wrote: > > ilya-biryukov wrote: > > > Unfort

[PATCH] D56597: [clangd] Add Limit parameter for xref.

hokein added inline comments. Comment at: unittests/clangd/DexTests.cpp:673 - std::vector Files; - RefsRequest Req; - Req.IDs.insert(Foo.ID); - Req.Filter = RefKind::Declaration | RefKind::Definition; - Dex(std::vector{Foo, Bar}, Refs).refs(Req, [&](const Ref &R) { -Fi

[PATCH] D56655: [clangd] Fix mac buildbot failure.

hokein abandoned this revision. hokein added a comment. In D56655#1356000 , @kadircet wrote: > https://reviews.llvm.org/D56656 has landed to fix that issue Thanks! I have verified that the test failure is gone after your patch. Repository: rCTE Clang

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

kadircet updated this revision to Diff 181544. kadircet added a comment. - Change FileFilter and update logic to do not care about if there are any symbols coming from a file. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56592/new/ https://reviews

[PATCH] D56592: [clangd] Fix updated file detection logic in indexing

kadircet updated this revision to Diff 181545. kadircet added a comment. - Update comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56592/new/ https://reviews.llvm.org/D56592 Files: clangd/index/Background.cpp clangd/index/Background.h u

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

aaron.ballman added a comment. Mostly looks good (a few minor nits), but I did have a design question about whether we should prefer calling a `Visit` method for type hierarchies instead of reimplementing the functionality. Comment at: lib/AST/ASTDumper.cpp:145 void Visi

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

ilya-biryukov added inline comments. Comment at: clangd/XRefs.cpp:578 +bool Invalid; +StringRef Buffer = SM.getBufferData(SM.getFileID(StartLoc), &Invalid); +if (!Invalid) { ilya-biryukov wrote: > ilya-biryukov wrote: > > malaperle wrote: > > > ilya-b

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:145 void VisitVariableArrayType(const VariableArrayType *T) { - OS << " "; - NodeDumper.dumpSourceRange(T->getBracketsRange()); - VisitArrayType(T); +

[PATCH] D56663: [MSP430] Improve support of 'interrupt' attribute

krisb created this revision. Herald added a subscriber: cfe-commits. krisb edited the summary of this revision. krisb added a reviewer: asl. krisb edited the summary of this revision. - Accept as an argument constants in range 0..63 (aligned with TI headers and linker scripts provided with TI GCC

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

aaron.ballman added inline comments. Comment at: lib/AST/ASTDumper.cpp:145 void VisitVariableArrayType(const VariableArrayType *T) { - OS << " "; - NodeDumper.dumpSourceRange(T->getBracketsRange()); - VisitArrayType(T); + dumpTypeAsChild(T->getElementType

[PATCH] D56663: [MSP430] Improve support of 'interrupt' attribute

grimar added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5381 + // MSP430 'interrupt' attribute is applied to + // a function with no parameters and void return type + if (!isFunctionOrMethod(D)) { nit: code comments usually have a dot `.` at the en

[PATCH] D56665: [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes).

sammccall created this revision. sammccall added reviewers: bkramer, klimek. Herald added a subscriber: cfe-commits. Prior to r351069, lambda classes were traversed or not depending on the {Function, Class, Namespace, TU} DeclContext containing them. If it was a function (common case) they were no

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:3780 +represent an implicit "this" pointer in class methods. If there is no implicit +"this" pointer it shall not be referenced. The index '-1', or the name "?", +represents an unknown callback calle

[PATCH] D56665: [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes).

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: unittests/Tooling/RecursiveASTVisitorTests/LambdaExpr.cpp:72 + Visitor.ExpectMatch("", 1, 10); + Visitor.ExpectMatch("", 1, 14); + EXPECT_TRUE(Visitor.runOver("auto x = []{ [] {}; };", ---

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny updated this revision to Diff 181552. mgorny retitled this revision from "[lld] [ELF] Support inferring target triple from filename" to "[lld] [ELF] Support customizing behavior on target triple". mgorny edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: ELF/Driver.cpp:757 + if (!TargetOpt.empty()) { +// TODO: do we want to verify it and fail on unsupported? +Config->TargetTriple = llvm::Triple(TargetOpt); arichardson wrot

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny updated this revision to Diff 181554. mgorny marked an inline comment as done. mgorny added a comment. Fixed leaving triple unset on invalid `--target`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56650/new/ https://reviews.llvm.org/D56650 Files: ELF/Config.h ELF/Driver.cp

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

baloghadamsoftware added a comment. This seems to be an important fix. Thank you! Did you measure decrease in the false-positive rate or an increase in the true-positive rate on real code? I expect some. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h

[PATCH] D56267: [clangd] Interfaces for writing code actions

sammccall added a comment. To be a bit more concrete... One approach which won't win any OO design points but might be quite easy to navigate: combine the ActionProvider and PreparedAction into one class. class SwapIfBranches : public MiniRefactoringThing { SwapIfBranches(); // must have

[PATCH] D56267: [clangd] Interfaces for writing code actions

sammccall added a comment. Name ideas: - "Refactoring" - I think the main drawback is the conflicts with potential global-refactorings that we do in clangd. I don't think the conflict with `tooling/refactor` is bad enough to avoid this. I also don't think "some of these don't look like refacto

[PATCH] D56597: [clangd] Add Limit parameter for xref.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/DexTests.cpp:684 + } + { +Req.Limit = 1; instead of splitting scopes here, might be more obvious just to `Files.

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Awesome detective work! I glanced over the code, it looks great. I'd love to dedicate more time to your liveness-related patches, but university is a thing, so finding typos and the like

[PATCH] D55394: Re-order type param children of ObjC nodes

steveire marked an inline comment as done. steveire added inline comments. Comment at: test/AST/ast-dump-decl.m:90 // CHECK-NEXT: -ObjCProtocol {{.+}} 'P' +// CHECK-NEXT: -ObjCTypeParamDecl {{.+}} col:33 T 'id':'id' dblaikie wrote: > steveire wrote: > > a

[PATCH] D56665: [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes).

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This makes sense to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56665/new/ https://reviews.llvm.org/D56665 _

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 181562. dankm added a comment. Restored original test case file names. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466 Files: include/clang/Basic/DiagnosticDriverKinds.td include/cl

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm marked 3 inline comments as done. dankm added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:612 +if (Map.find('=') == StringRef::npos) + D.Diag(diag::err_drv_invalid_argument_to_fdebug_prefix_map) << Map; +else Lekensteyn wrote:

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc updated this revision to Diff 181563. russellmcc added a comment. Respond to feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54881/new/ https://reviews.llvm.org/D54881 Files: lib/Format/UnwrappedLineFormatter.cpp lib/Format/UnwrappedLineFormatter.h lib/Format/Wh

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

russellmcc marked 2 inline comments as done. russellmcc added a comment. Thanks for the feedback! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54881/new/ https://reviews.llvm.org/D54881 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

russellmcc added a comment. Ping! Thanks for your consideration. I'm still quite motivated to land this, please let me know if there's anything I can do, or if it's an unwanted patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

lebedev.ri added a comment. https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options comes into mind. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54881/new/ https://reviews.llvm.org/D54881 ___ cfe-commits

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

lebedev.ri added a comment. https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options comes into mind. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40988/new/ https://reviews.llvm.org/D40988 ___ cfe-commits

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

Lekensteyn accepted this revision. Lekensteyn added a comment. Still fine by me, thanks! As for the commit message, perhaps reference: https://bugs.llvm.org/show_bug.cgi?id=38135 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

xazax.hun added a comment. I really like all this detective work and it would be sad to have it forgotten. I would love to see some of your comments in the documentation of symbol reaper. More specifically: > When a memory region is live, all its sub-regions and super-regions are > automaticall

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

peter.smith added a comment. I think we need to be very careful here. If I've understood this correctly then if this functionality is used for anything critical then a manually supplied target will be needed when doing cross-linking. For example my host LLD is x86_64, is just called ld.lld and

[PATCH] D56631: [MSVC Compat] Fix typo correction for inclusion directives.

christylee accepted this revision. christylee added a comment. This revision is now accepted and ready to land. Thanks for catching that! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56631/new/ https://reviews.llvm.org/D56631 ___ cfe-commi

[PATCH] D55394: Re-order type param children of ObjC nodes

aaron.ballman added a reviewer: rjmccall. aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. Adding @rjmccall as an Obj-C expert to see if he has opinions on the output changes. Also, pinging @rsmith in case he'd like to weigh in. I think the change in behavior here is re

[PATCH] D56241: expose a control flag for interger to pointer ext warning

Kader added a comment. friendly ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56241/new/ https://reviews.llvm.org/D56241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

r351075 - [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes).

Author: sammccall Date: Mon Jan 14 09:16:00 2019 New Revision: 351075 URL: http://llvm.org/viewvc/llvm-project?rev=351075&view=rev Log: [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes). Summary: Prior to r351069, lambda classes were traversed or not depending on the

[PATCH] D56665: [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes).

This revision was automatically updated to reflect the committed changes. Closed by commit rL351075: [AST] Fix double-traversal of code in top-level lambdas in RAV(implicit = yes). (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

  1   2   3   >