baloghadamsoftware added a comment. This seems to be an important fix. Thank you!
Did you measure decrease in the false-positive rate or an increase in the true-positive rate on real code? I expect some. ================ Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:390 - // FIXME: Remove when we migrate over to just using ValueManager. SymbolManager &getSymbolManager() { return SymMgr; } ---------------- Is this comment intentionally deleted? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56632/new/ https://reviews.llvm.org/D56632 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits