sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: unittests/clangd/DexTests.cpp:684
+ }
+ {
+ Req.Limit = 1;
----------------
instead of splitting scopes here, might be more obvious just to `Files.clear()`
between?
================
Comment at: unittests/clangd/IndexTests.cpp:306
+ {
+ Request.Limit = 1;
+ size_t RefsCount = 0;
----------------
hokein wrote:
> sammccall wrote:
> > why new scope here?
> To align with the case above.
FWIW I'd find it easier to read if neither this nor the one above used new
scopes, which tend to suggest some spooky scoped object side effects to me.
Up to you, though.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56597/new/
https://reviews.llvm.org/D56597
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
