Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
Awesome detective work! I glanced over the code, it looks great. I'd love to
dedicate more time to your liveness-related patches, but university is a thing,
so finding typos and the like is the best I can do for a while.
Wild thought, would `debug.DumpLiveStmts` be of any use here?
================
Comment at: test/Analysis/symbol-reaper.cpp:1
+// RUN: %clang_analyze_cc1 -analyzer-checker=debug.ExprInspection -verify %s
+
----------------
Core intentionally left out?
================
Comment at: test/Analysis/symbol-reaper.cpp:31
+ clang_analyzer_eval(glob); // expected-warning{{TRUE}}
+ // expected-warning@-1{{SYMBOL DEAD}}
+}
----------------
N00b question: What does `SYMBOL DEAD` mean here exactly?
================
Comment at: unittests/StaticAnalyzer/CMakeLists.txt:8
RegisterCustomCheckersTest.cpp
+ SymbolReaperTest.cpp
)
----------------
Woohoo!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56632/new/
https://reviews.llvm.org/D56632
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
