[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

ebevhan added a comment. In D53738#1308314 , @leonardchan wrote: > > Generally I think it's good! One final note; I assume we could technically > > reuse/rename the EmitFixedPointAdd function and use it to emit other binops > > when those are added? > >

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175412. kadircet added a comment. - Rebase to get changes in background index. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54817/new/ https://reviews.llvm.org/D54817 Files: clangd/index/Background.cpp cl

[PATCH] D54934: [libclang] Fix clang_Cursor_getNumArguments and clang_Cursor_getArgument for CXXConstructExpr

yvvan created this revision. yvvan added reviewers: nik, marcobubke. Herald added a subscriber: arphaman. Constructors have the same methods for arguments as call expressions. Let's provide a way to get their arguments the same way. https://reviews.llvm.org/D54934 Files: test/Index/print-typ

[PATCH] D54796: [clangd] C++ API for emitting file status

sammccall added inline comments. Comment at: clangd/ClangdLSPServer.cpp:787 +void ClangdLSPServer::onFileUpdated(const FileStatus &FStatus) { + notify("window/showMessage", FStatus); +} notifying via `showMessage` looks sensible at first glance as a fallback. La

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours}, hwright w

[PATCH] D54630: Move detection of libc++ include dirs to Driver on MacOS

ilya-biryukov added a comment. In D54630#1308671 , @dexonsmith wrote: > I'm a little skeptical that splitting this logic between cc1 and the driver > will simplify things, but I haven't looked in detail and I'll defer to your > (collective) judgement.

[PATCH] D54781: [clangd] Add 'Switch header/source' command in clangd-vscode

ilya-biryukov added a comment. +1 to the new release D52311 (documentSymbol) needs a bump of the dependencies' versions. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54781/new/ https://reviews.llvm.org/D54781

Re: Dumping AST information to other formats

On 26/11/2018 19:20, Aaron Ballman via cfe-commits wrote: Once upon a time, there was -ast-print-xml. This -cc1 option was dropped because it was frequently out of sync with the AST data. It is right to ask: why would JSON, etc be any different? This is still an open question, but a goal of this

[PATCH] D53693: [ASTImporter] Typedef import brings in the complete type

This revision was automatically updated to reflect the committed changes. Closed by commit rL347648: [ASTImporter] Typedef import brings in the complete type (authored by martong, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53693?v

r347648 - [ASTImporter] Typedef import brings in the complete type

Author: martong Date: Tue Nov 27 01:51:36 2018 New Revision: 347648 URL: http://llvm.org/viewvc/llvm-project?rev=347648&view=rev Log: [ASTImporter] Typedef import brings in the complete type Summary: When we already have an incomplete underlying type of a typedef in the "To" context, and the "Fro

[PATCH] D54938: [clangd] Prevent thread starvation in tests on loaded systems.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Background index deliberately runs low-priority, but for tests this may stop them making progress. Repository: rCTE Clang Tools

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire updated this revision to Diff 175429. steveire added a comment. Refactor Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54405/new/ https://reviews.llvm.org/D54405 Files: include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/Dynamic/Registry

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:85 +using DerivedT = typename ast_matchers::internal::VariadicAllOfMatcher::Type; +registerIfNodeMatcher(ASTNodeKind::getFromNodeKind(), Descripto

[PATCH] D54900: [Sema] Avoid CallExpr::setNumArgs in Sema::BuildCallToObjectOfClassType

riccibruno updated this revision to Diff 175431. riccibruno marked 3 inline comments as done. riccibruno added a comment. fixed the formatting Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54900/new/ https://reviews.llvm.org/D54900 Files: lib/Sema/SemaOverload

[PATCH] D54902: [AST][Sema] Remove CallExpr::setNumArgs

riccibruno updated this revision to Diff 175434. riccibruno marked 9 inline comments as done. riccibruno added a comment. style fixes Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54902/new/ https://reviews.llvm.org/D54902 Files: include/clang/AST/Expr.h inc

[PATCH] D54902: [AST][Sema] Remove CallExpr::setNumArgs

riccibruno added a comment. added inline comments Comment at: include/clang/AST/ExprCXX.h:168 public: - CXXMemberCallExpr(ASTContext &C, Expr *fn, ArrayRef args, -QualType t, ExprValueKind VK, SourceLocation RP) - : CallExpr(C, CXXMemberCallExprClass,

Re: r347417 - Re-Reinstate 347294 with a fix for the failures.

We're hitting test failures due to this in Chromium: https://crbug.com/908372 I'm still not sure what's going on, just wanted to give a heads up in case someone else is seeing issues. On Wed, Nov 21, 2018 at 9:44 PM, Bill Wendling via cfe-commits wrote: > Author: void > Date: Wed Nov 21 12:44:18

[PATCH] D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

malcolm.parsons created this revision. malcolm.parsons added reviewers: alexfh, aaron.ballman, hokein. Herald added subscribers: cfe-commits, xazax.hun. There is no ambiguity / information loss in this conversion Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54941 Files: cla

[clang-tools-extra] r347652 - [clang-tidy] Avoid inconsistent notes in readability-container-size-empty

Author: alexfh Date: Tue Nov 27 02:53:44 2018 New Revision: 347652 URL: http://llvm.org/viewvc/llvm-project?rev=347652&view=rev Log: [clang-tidy] Avoid inconsistent notes in readability-container-size-empty When a warning is issued in a template instantiation, the check would previously use templ

[clang-tools-extra] r347651 - [clang-tidy] Minor fixes in a test

Author: alexfh Date: Tue Nov 27 02:53:38 2018 New Revision: 347651 URL: http://llvm.org/viewvc/llvm-project?rev=347651&view=rev Log: [clang-tidy] Minor fixes in a test Use CHECK-FIXES where it was intended instead of CHECK-MESSAGES. Fixed compiler warnings to pacify YouCompleteMe. Modified:

[PATCH] D54918: Apply clang-format to GenericTaintChecker.cpp

gerazo accepted this revision. gerazo added a comment. This revision is now accepted and ready to land. Looks correct clang-format to me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54918/new/ https://reviews.llvm.org/D54918 _

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth updated this revision to Diff 175444. JonasToth added a comment. reabse to master + ping :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 Files: clang-tidy/performance/ForRangeCopyCheck.cpp c

[PATCH] D52690: [clang-tidy] NFC use CHECK-NOTES in tests for misc-misplaced-const

JonasToth abandoned this revision. JonasToth added a comment. not so relevant and spams my view Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52690/new/ https://reviews.llvm.org/D52690 ___ cfe-commits m

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 175445. JonasToth added a comment. - Merge branch 'master' into check_const Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45444/new/ https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMake

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

lebedev.ri added a comment. Looks reasonable to me (or at least all these tests make this look good :)), but i'm not sure i can fully review this. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 _

[PATCH] D54938: [clangd] Prevent thread starvation in tests on loaded systems.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clangd/tool/ClangdMain.cpp:356 + if (Test) +preventThreadStarvationInTests(); std::unique_ptr StaticIdx; Can we move this to the

r347654 - [libclang] Fix clang_Cursor_getNumArguments and clang_Cursor_getArgument for CXXConstructExpr

Author: yvvan Date: Tue Nov 27 04:02:39 2018 New Revision: 347654 URL: http://llvm.org/viewvc/llvm-project?rev=347654&view=rev Log: [libclang] Fix clang_Cursor_getNumArguments and clang_Cursor_getArgument for CXXConstructExpr Constructors have the same methods for arguments as call expressions.

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth created this revision. JonasToth added reviewers: alexfh, aaron.ballman, hokein, shuaiwang, lebedev.ri. Herald added subscribers: cfe-commits, kbarton, xazax.hun, mgorny, nemanjai. This patch connects the check for const-correctness with the new general utility to add const to variables.

[PATCH] D54934: [libclang] Fix clang_Cursor_getNumArguments and clang_Cursor_getArgument for CXXConstructExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC347654: [libclang] Fix clang_Cursor_getNumArguments and clang_Cursor_getArgument for… (authored by yvvan, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5493

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth added a comment. In D54395#1309423 , @lebedev.ri wrote: > Looks reasonable to me (or at least all these tests make this look good :)), > but i'm not sure i can fully review this. No problem ;) Repository: rCTE Clang Tools Extra CHANGES SI

[clang-tools-extra] r347655 - [clangd] Prevent thread starvation in tests on loaded systems.

Author: sammccall Date: Tue Nov 27 04:09:13 2018 New Revision: 347655 URL: http://llvm.org/viewvc/llvm-project?rev=347655&view=rev Log: [clangd] Prevent thread starvation in tests on loaded systems. Summary: Background index deliberately runs low-priority, but for tests this may stop them making

[PATCH] D54938: [clangd] Prevent thread starvation in tests on loaded systems.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rCTE347655: [clangd] Prevent thread starvation in tests on loaded systems. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

MarinaKalashina created this revision. MarinaKalashina added a reviewer: asl. Herald added subscribers: cfe-commits, arphaman. Proposing changes to //clang-tools-extra/docs/clang-tidy/index.rst// 'Using clang-tidy' was split into 2 chapters: - 'Standalone tool' (the previous content of 'Using cl

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

JonasToth added subscribers: sammccall, JonasToth. JonasToth added a comment. I like the overview, maybe a link to `clangd` here might help, as there is currently a lot of effort of integrating `clang-tidy` into it. (@sammccall WDYT?) Comment at: docs/clang-tidy/index.rst:23

[PATCH] D54529: [clangd] Add USR to textDocument/definition response

jkorous abandoned this revision. jkorous added a comment. Morphed into https://reviews.llvm.org/D54799 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54529/new/ https://reviews.llvm.org/D54529 ___ cfe-co

[PATCH] D54872: [clangd] Add ability to not use -resource-dir at all

ilya-biryukov added a comment. In D54872#1309075 , @malaperle wrote: > In D54872#1307775 , @ilya-biryukov > wrote: > > > We have to point clangd into the resource dir, corresponding to the version > > of the heade

[PATCH] D54589: [clang][UBSan] Sanitization for alignment assumptions.

lebedev.ri updated this revision to Diff 175407. lebedev.ri marked 11 inline comments as done. lebedev.ri added a comment. Address @rjmccall review notes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54589/new/ https://reviews.llvm.org/D54589 Files: docs/Rele

[PATCH] D54817: [clangd] Put direct headers into srcs section.

sammccall added a comment. structure and serialization stuff looks great! still some questions around the auto-index logic and organization of the extraction code, let's chat offline. May make sense to split. Comment at: clangd/index/Background.cpp:329 +llvm::StringMap +Includ

[PATCH] D54799: [clangd][WIP] textDocument/SymbolInfo method

sammccall accepted this revision. sammccall marked an inline comment as done. sammccall added a comment. Tests look great, thanks! Comment at: clangd/ClangdServer.cpp:529 + + WorkScheduler.runWithAST("CursorInfo", File, Bind(Action, std::move(CB))); +} jkorous

[PATCH] D54900: [Sema] Avoid CallExpr::setNumArgs in Sema::BuildCallToObjectOfClassType

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54900/new/ https://reviews.llvm.org/D54900 ___

[PATCH] D54902: [AST][Sema] Remove CallExpr::setNumArgs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from two small NFC nits. Comment at: include/clang/AST/ExprCXX.h:168 public: - CXXMemberCallExpr(ASTContext &C, Expr *fn, ArrayRef args, -

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

JonasToth updated this revision to Diff 175459. JonasToth added a comment. - after countless attempts of fixing the unicode problem, it is finally done. - Remove all unnecessary whitespace - remove the `xxx warnings generated.` as well This setup now runs in my BB and is a good approximation (for

[PATCH] D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/readability-implicit-bool-conversion.rst:77-78 -- boolean expression/literal to integer, +- boolean expression/literal to integer (conversion from boolean to a single + bit bitfield is explicitly allowed)

[PATCH] D54947: [OpenCL][CodeGen] Fix replacing memcpy with addrspacecast

sidorovd created this revision. sidorovd added reviewers: yaxunl, Anastasia. Herald added a subscriber: cfe-commits. If a function argument is byval and RV is located in default or alloca address space an optimization of creating addrspacecast instead of memcpy is performed. That is not correct

[PATCH] D54817: [clangd] Put direct headers into srcs section.

sammccall added a comment. To summarize offline discussion: I think we need to split this patch up, as the scope is growing. (In a really useful direction I think!) The first patch should add the include graph data structure. (I think the right place for it is probably Headers.h, as we want to

[PATCH] D54405: Record whether a AST Matcher constructs a Node

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please commit with whatever patch makes use of `nodeConstructors()` (as this functionality doesn't stand on its own). Repository: rC Clang CHANGES SINCE LAST ACTION h

[PATCH] D54903: [WIP][Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175465. courbet added a comment. Handle all std type traits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cpp Index

[PATCH] D54845: [clangd] Canonicalize file path in URIForFile.

ioeric updated this revision to Diff 175466. ioeric marked 7 inline comments as done. ioeric added a comment. address comments and rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54845/new/ https://reviews.llvm.org/D54845 Files: clangd/Clang

[PATCH] D54845: [clangd] Canonicalize file path in URIForFile.

ioeric added a comment. Thanks for the review! PTAL Comment at: clangd/Protocol.h:74 + /// \p AbsPath is resolved to a canonical path corresponding to its URI. + URIForFile(llvm::StringRef AbsPath, llvm::StringRef HintPath = ""); + sammccall wrote: > sammccal

r347656 - Revert r347417 "Re-Reinstate 347294 with a fix for the failures."

Author: hans Date: Tue Nov 27 06:01:40 2018 New Revision: 347656 URL: http://llvm.org/viewvc/llvm-project?rev=347656&view=rev Log: Revert r347417 "Re-Reinstate 347294 with a fix for the failures." This caused a miscompile in Chrome (see crbug.com/908372) that's illustrated by this small reduction

Re: r347417 - Re-Reinstate 347294 with a fix for the failures.

I've reverted this and the follow-ups in r347656 and included a reduced repro for the miscompile. On Tue, Nov 27, 2018 at 11:36 AM, Hans Wennborg wrote: > We're hitting test failures due to this in Chromium: > https://crbug.com/908372 I'm still not sure what's going on, just > wanted to give a he

[clang-tools-extra] r347657 - Revert r347419 "Update call to EvaluateAsInt() to the new syntax."

Author: hans Date: Tue Nov 27 06:15:37 2018 New Revision: 347657 URL: http://llvm.org/viewvc/llvm-project?rev=347657&view=rev Log: Revert r347419 "Update call to EvaluateAsInt() to the new syntax." It's pre-requisite was reverted in r347656. Modified: clang-tools-extra/trunk/clang-tidy/bugpr

[PATCH] D54845: [clangd] Canonicalize file path in URIForFile.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Mostly just places that should be updated HintPath -> TUPath. Changing the whole codebase doesn't seem important, but in places that are touched... Comment at:

Re: Dumping AST information to other formats

On Tue, Nov 27, 2018 at 4:50 AM Stephen Kelly via cfe-commits wrote: > > On 26/11/2018 19:20, Aaron Ballman via cfe-commits wrote: > > Once upon a time, there was -ast-print-xml. This -cc1 option was > > dropped because it was frequently out of sync with the AST data. It is > > right to ask: why w

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175469. kadircet marked 2 inline comments as done. kadircet added a comment. - Only keep the build graph structures and {de,}serialization logic. - Rename a few structures, move to more relavant places. Repository: rCTE Clang Tools Extra CHANGES SINCE LA

[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/AST/ExternalASTMerger.cpp:154 ToContainer->setHasExternalLexicalStorage(); - ToContainer->setMustBuildLookupTable(); + ToContainer->getPrimaryContext()->setMustBuildLookupTab

[PATCH] D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

malcolm.parsons marked an inline comment as done. malcolm.parsons added inline comments. Comment at: docs/clang-tidy/checks/readability-implicit-bool-conversion.rst:77-78 -- boolean expression/literal to integer, +- boolean expression/literal to integer (conversion from boolea

[PATCH] D54799: [clangd][WIP] textDocument/SymbolInfo method

jkorous updated this revision to Diff 175475. jkorous added a comment. Finished tests and fixed operator<<(SymbolDetails) for containerNames that aren't part of fully qualified name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54799/new/ https://reviews.llvm.org/D54799 Files: clan

r347658 - Derive builtin return type from its definition

Author: mantognini Date: Tue Nov 27 06:54:58 2018 New Revision: 347658 URL: http://llvm.org/viewvc/llvm-project?rev=347658&view=rev Log: Derive builtin return type from its definition Summary: Prior to this patch, OpenCL code such as the following would attempt to create a BranchInst with a non-b

[PATCH] D52879: Derive builtin return type from its definition

This revision was automatically updated to reflect the committed changes. Closed by commit rC347658: Derive builtin return type from its definition (authored by mantognini, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52879/new/ https://reviews.ll

[PATCH] D54799: [clangd] textDocument/SymbolInfo method

jkorous added a comment. Going to split `SymbolID.h ` as a NFC commit per Alex's suggestion and land this. Thanks everyone! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54799/new/ https://reviews.llvm.org/D54799 ___ cfe-commits mailing li

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours}, JonasToth w

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

hwright updated this revision to Diff 175476. hwright marked 10 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54737/new/ https://reviews.llvm.org/D54737 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/Duratio

[PATCH] D54817: [clangd] Put direct headers into srcs section.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Only really significant thing is I think the name "build graph" is confusing, and we should specifically mention includes. Rest is just nits to take or leave... Commen

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

sammccall added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours}, hwright w

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours}, sammc

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

sammccall added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours}, aaron.bal

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

mikael marked an inline comment as done. mikael added inline comments. Comment at: lib/CodeGen/CGCall.cpp:4035 + V = Builder.CreatePointerBitCastOrAddrSpaceCast(V, DestTy); +} rjmccall wrote: > Always use the `performAddrSpaceConversion` target

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours}, sammc

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong marked 20 inline comments as done. martong added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:1169 +/// matches 'a'. +extern const internal::VariadicDynCastAllOfMatcher +indirectFieldDecl; aaron.ballman wrote: > Be sure to up

[PATCH] D53655: [ASTImporter] Fix redecl chain of classes and class templates

martong updated this revision to Diff 175482. martong marked 5 inline comments as done. martong added a comment. - Address several minor review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53655/new/ https://reviews.llvm.org/D53655 Files: docs/LibAST

[PATCH] D52879: Derive builtin return type from its definition

riccibruno added a comment. I see plenty of `TheCall->setType` left in `Sema::CheckBuiltinFunctionCall` (`Builtin::BI__builtin_classify_type`, `Builtin::BI__builtin_constant_p`, `Builtin::BI__builtin_dump_struct` and so on...). Is there a reason for not removing them ? Repository: rC Clang C

[PATCH] D54817: [clangd] Put direct headers into srcs section.

kadircet updated this revision to Diff 175483. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments. - Move digest and digestFile into SourceCode.h Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54817/new/ https://r

[PATCH] D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: docs/clang-tidy/checks/readability-implicit-bool-conversion.rst:77-78 -- boolean expression/literal to integer, +- boolean expression/literal to integer (co

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

cameron.mcinally added a comment. Digressing a bit, but has anyone given thought to how this implementation will play out with libraries? When running with traps enabled, libraries must be compiled for trap-safety. E.g. optimizations on a lib's code could introduce a NaN or cause a trap that do

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh added a comment. Should this chapter be a separate page linked from index.md? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 ___ cfe-commits mailing list

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

sammccall added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:25 +static llvm::Optional getScaleForInverse(llvm::StringRef Name) { + static const std::unordered_map ScaleMap( + {{"ToDoubleHours", DurationScale::Hours}, aaron.bal

[libclc] r347665 - amdgcn: Consolidate atomic minmax helpers

Author: jvesely Date: Tue Nov 27 08:01:13 2018 New Revision: 347665 URL: http://llvm.org/viewvc/llvm-project?rev=347665&view=rev Log: amdgcn: Consolidate atomic minmax helpers Removes most overrides Signed-off-by: Jan Vesely Reviewer: Aaron Watry Removed: libclc/trunk/amdgcn/lib/OVERRIDES

[libclc] r347664 - configure: Add target specific asm rule.

Author: jvesely Date: Tue Nov 27 08:01:10 2018 New Revision: 347664 URL: http://llvm.org/viewvc/llvm-project?rev=347664&view=rev Log: configure: Add target specific asm rule. Run the file through target specific preprocessing stage. Signed-off-by: Jan Vesely Reviewer: Aaron Watry Modified:

[libclc] r347663 - configure: provide llvm_as helper variable

Author: jvesely Date: Tue Nov 27 08:01:01 2018 New Revision: 347663 URL: http://llvm.org/viewvc/llvm-project?rev=347663&view=rev Log: configure: provide llvm_as helper variable Signed-off-by: Jan Vesely Reviewer: Aaron Watry Modified: libclc/trunk/configure.py Modified: libclc/trunk/config

[libclc] r347666 - r600: Remove empty OVERRIDES file

Author: jvesely Date: Tue Nov 27 08:01:16 2018 New Revision: 347666 URL: http://llvm.org/viewvc/llvm-project?rev=347666&view=rev Log: r600: Remove empty OVERRIDES file Signed-off-by: Jan Vesely Reviewer: Aaron Watry Removed: libclc/trunk/r600/lib/OVERRIDES Removed: libclc/trunk/r600/lib/OV

[PATCH] D54817: [clangd] Put direct headers into srcs section.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE347669: [clangd] Put direct headers into srcs section. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D54817?vs=175483&id=175486#toc Repository: rCTE Clang

[clang-tools-extra] r347669 - [clangd] Put direct headers into srcs section.

Author: kadircet Date: Tue Nov 27 08:08:53 2018 New Revision: 347669 URL: http://llvm.org/viewvc/llvm-project?rev=347669&view=rev Log: [clangd] Put direct headers into srcs section. Summary: Currently, there's no way of knowing about header files using compilation database, since it doesn't conta

[libclc] r347667 - Add cmake build system

Author: jvesely Date: Tue Nov 27 08:07:19 2018 New Revision: 347667 URL: http://llvm.org/viewvc/llvm-project?rev=347667&view=rev Log: Add cmake build system Add cmake support for CLC and ll asm language, the latter includes clang preprocessing stage. Add ctests to check for external function call

[libclc] r347668 - travis: Add cmake build

Author: jvesely Date: Tue Nov 27 08:07:21 2018 New Revision: 347668 URL: http://llvm.org/viewvc/llvm-project?rev=347668&view=rev Log: travis: Add cmake build Reviewer: Aaron Watry Signed-off-by: Jan Vesely Modified: libclc/trunk/.travis.yml Modified: libclc/trunk/.travis.yml URL: http://

[PATCH] D54862: [OpenCL] Add generic AS to 'this' pointer

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:4035 + V = Builder.CreatePointerBitCastOrAddrSpaceCast(V, DestTy); +} mikael wrote: > rjmccall wrote: > > Always use the `performAddrSpaceConversion` target hook if there's a >

[PATCH] D54952: [clangd] DO NOT SUBMIT. Draft interfaces for build system integration.

ilya-biryukov created this revision. ilya-biryukov added reviewers: klimek, sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. A proposal for the interface of the new build system integration. Similar to CompilationDatabase, but will provide more functionality and l

[PATCH] D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/readability-implicit-bool-conversion.rst:77-78 -- boolean expression/literal to integer, +- boolean expression/literal to integer (conversion from boolean to a single + bit bitfield is explicitly allowed)

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationComparisonCheck.cpp:50 + static const std::unordered_map> + InverseMap( hwright wrote: > hwright wrote: > > JonasToth wrote: > > > This variable is a little hard to read. Could you make

[clang-tools-extra] r347671 - [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

Author: malcolm.parsons Date: Tue Nov 27 08:23:39 2018 New Revision: 347671 URL: http://llvm.org/viewvc/llvm-project?rev=347671&view=rev Log: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion Summary: There is no ambiguity / information loss in th

[PATCH] D54941: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability-implicit-bool-conversion

This revision was automatically updated to reflect the committed changes. Closed by commit rL347671: [clang-tidy] Ignore bool -> single bit bitfield conversion in readability… (authored by malcolm.parsons, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SIN

[PATCH] D53329: Generate DIFile with main program if source is not available

scott.linder added a comment. See https://reviews.llvm.org/D54953 for the Verifier work. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53329/new/ https://reviews.llvm.org/D53329 ___ cfe-commits mailing list cfe-commi

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationRewriter.h:62 + +AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher, + DurationConversionFunction) { I think you can even make this an `AST_MATCHER(FunctionDecl, duratio

[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationRewriter.h:62 + +AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher, + DurationConversionFunction) { JonasToth wrote: > I think you can even make this an `AST_MATCHER(Fun

[PATCH] D53708: [ASTImporter] Add importer specific lookup

martong marked 18 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:7605 + +ASTImporter::ASTImporter(ASTImporterLookupTable *LookupTable, + ASTContext &ToContext, FileManager &ToFileManager, a_sido

[PATCH] D53708: [ASTImporter] Add importer specific lookup

martong updated this revision to Diff 175495. martong marked 5 inline comments as done. martong added a comment. - Address Alexei's comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53708/new/ https://reviews.llvm.org/D53708 Files: include/clang/AST/ASTIm

[clang-tools-extra] r347674 - [clangd][NFC] Move SymbolID to a separate file

Author: jkorous Date: Tue Nov 27 08:40:34 2018 New Revision: 347674 URL: http://llvm.org/viewvc/llvm-project?rev=347674&view=rev Log: [clangd][NFC] Move SymbolID to a separate file Prerequisity for textDocument/SymbolInfo Differential Revision: https://reviews.llvm.org/D54799 Added: clang-t

[clang-tools-extra] r347675 - [clangd] textDocument/SymbolInfo extension

Author: jkorous Date: Tue Nov 27 08:40:46 2018 New Revision: 347675 URL: http://llvm.org/viewvc/llvm-project?rev=347675&view=rev Log: [clangd] textDocument/SymbolInfo extension New method returning symbol info for given source position. Differential Revision: https://reviews.llvm.org/D54799 rda

[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. In D52879#1309734 , @riccibruno wrote: > I see plenty of `TheCall->setType` left in `Sema::CheckBuiltinFunctionCall` > (`Builtin::BI__builtin_classify_type`, `Builtin::BI__builtin_constant_p`, > `Builtin::BI__builtin_dump_stru

[PATCH] D54799: [clangd] textDocument/SymbolInfo method

This revision was automatically updated to reflect the committed changes. Closed by commit rL347674: [clangd][NFC] Move SymbolID to a separate file (authored by jkorous, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54799?vs=175475&i

  1   2   >