sammccall accepted this revision. sammccall marked an inline comment as done. sammccall added a comment.
Tests look great, thanks! ================ Comment at: clangd/ClangdServer.cpp:529 + + WorkScheduler.runWithAST("CursorInfo", File, Bind(Action, std::move(CB))); +} ---------------- jkorous wrote: > sammccall wrote: > > sammccall wrote: > > > nit: SymbolInfo > > (This still says CursorInfo in the runWithAST call) > I sent my comments first and updated the diff a minute after. You are > probably just too fast and saw the stale version :) Haha, then I reloaded and saw your changes, but couldn't find my comment to delete it... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54799/new/ https://reviews.llvm.org/D54799 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits