[PATCH] D54737: [clang-tidy] Add the abseil-duration-comparison check

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added inline comments.

================
Comment at: clang-tidy/abseil/DurationRewriter.h:62
+
+AST_MATCHER_FUNCTION(ast_matchers::internal::Matcher<FunctionDecl>,
+                     DurationConversionFunction) {
----------------
I think you can even make this an `AST_MATCHER(FunctionDecl, 
durationConversionFunction) { ... }`, or was there an issue with it? (`git grep 
-n AST_MATCHER` in clang-tidy for other examples)
With this, the wrapping with `functionDecl()` should not be necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54737/new/

https://reviews.llvm.org/D54737



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits