JonasToth added a comment.
Thank you very much :)
Am 12.08.2018 um 00:17 schrieb Shuai Wang via Phabricator:
> shuaiwang added a comment.
>
> In https://reviews.llvm.org/D45444#1196271, @JonasToth wrote:
>
>> Always the same with the templates ;) So uninstantiated templates should
>>
>> jus
Merged both of these to 7.0 in r339538.
On Sat, Aug 11, 2018 at 10:34 AM, David Chisnall via cfe-commits
wrote:
> Thanks,
>
> That fix looks exactly what is needed - and is something I didn’t realise
> FileCheck could do! The order of those matters in the linked binary, but not
> in the IR - t
hokein added inline comments.
Comment at: clang-tidy/abseil/DurationDivisionCheck.cpp:24
+
+ const auto IsDuration =
+ expr(hasType(cxxRecordDecl(hasName("::absl::Duration";
maybe call it `DurationExpr` since you have declared the variable as
`expr(...
hokein added a comment.
The check is missing its document, please add one in `docs/clang-tidy/checks/`.
Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:23
+
+ Finder->addMatcher(namespaceDecl(hasName("absl")).bind("absl_namespace"),
+ this);
sepavloff updated this revision to Diff 160298.
sepavloff added a comment.
Rebased the patch
Repository:
rC Clang
https://reviews.llvm.org/D21508
Files:
include/clang/AST/DeclBase.h
lib/Sema/SemaDecl.cpp
lib/Sema/SemaTemplateInstantiateDecl.cpp
test/Modules/friend-definition.cpp
te
kadircet updated this revision to Diff 160299.
kadircet added a comment.
- Resolve discussions.
- Fix typo.
Repository:
rC Clang
https://reviews.llvm.org/D50443
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/Preprocessor.cpp
Index: lib/Lex/Preprocessor.cpp
hokein added inline comments.
Comment at: docs/clang-tidy/checks/abseil-no-internal-deps.rst:6
+
+Gives a warning if code using Abseil depends on internal details. If something
is in a namespace or filename/path that includes the word “internal”, code is
not allowed to depend u
Author: kadircet
Date: Mon Aug 13 01:13:35 2018
New Revision: 339540
URL: http://llvm.org/viewvc/llvm-project?rev=339540&view=rev
Log:
[clang] Store code completion token range in preprocessor.
Summary:
This change is to support a new fature in clangd, tests will be send
toclang-tools-extra with
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339540: [clang] Store code completion token range in
preprocessor. (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50443
F
Quuxplusone added a comment.
Long-delayed ping!
Repository:
rCXX libc++
https://reviews.llvm.org/D47111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kbobyrev updated this revision to Diff 160302.
kbobyrev marked an inline comment as done.
kbobyrev edited the summary of this revision.
kbobyrev added a comment.
Address the post-LGTM comment.
https://reviews.llvm.org/D50517
Files:
clang-tools-extra/clangd/index/dex/Iterator.h
clang-tools-e
kadircet updated this revision to Diff 160303.
kadircet added a comment.
- Rebase.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50449
Files:
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/SourceCode.cpp
clangd/SourceCode.h
unittests/clan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339543: [clangd] Support textEdit in addition to insertText.
(authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50449
Files:
Author: kadircet
Date: Mon Aug 13 01:23:01 2018
New Revision: 339543
URL: http://llvm.org/viewvc/llvm-project?rev=339543&view=rev
Log:
[clangd] Support textEdit in addition to insertText.
Summary:
Completion replies contains textEdits as well. Note that this change
relies on https://reviews.llvm.
kadircet updated this revision to Diff 160306.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Rebase & Resolve discussions.
- Resolve discussions.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50555
Files:
clangd/CodeComplete.cpp
clangd/Quality.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE339547: [clangd] Introduce scoring mechanism for
SignatureInformations. (authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50555?vs=160306&id=160307#toc
Reposit
Author: kadircet
Date: Mon Aug 13 01:40:05 2018
New Revision: 339547
URL: http://llvm.org/viewvc/llvm-project?rev=339547&view=rev
Log:
[clangd] Introduce scoring mechanism for SignatureInformations.
Reviewers: ilya-biryukov
Reviewed By: ilya-biryukov
Subscribers: mgrang, ioeric, MaskRay, jkorou
ilya-biryukov added inline comments.
Comment at: clangd/Diagnostics.h:40
DiagnosticsEngine::Level Severity = DiagnosticsEngine::Note;
+ unsigned Category;
// Since File is only descriptive, we store a separate flag to distinguish
Maybe store the string nam
jmorse added a comment.
ping
Repository:
rC Clang
https://reviews.llvm.org/D48072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Mon Aug 13 01:57:06 2018
New Revision: 339548
URL: http://llvm.org/viewvc/llvm-project?rev=339548&view=rev
Log:
[clangd] Generate incomplete trigrams for the Dex index
This patch handles trigram generation "short" identifiers and queries.
Trigram generator produces incomplet
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339548: [clangd] Generate incomplete trigrams for the Dex
index (authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50517?vs
theraven updated this revision to Diff 160312.
theraven added a comment.
- Add a test case.
Repository:
rC Clang
https://reviews.llvm.org/D50559
Files:
lib/CodeGen/CGObjCGNU.cpp
test/CodeGenObjC/gnu-deterministic-selectors.m
Index: test/CodeGenObjC/gnu-deterministic-selectors.m
===
hans added a comment.
The reason we noticed this was that it caused a *50 GB* size increase of the
build output on our buildbots, which was enough to cause infrastructure
problems.
This change was also committed shortly before the 7.0 branch, so it's part of
the 7.0.0 release candidates.
Shou
miyuki updated this revision to Diff 160317.
miyuki added a comment.
Handle return of homogeneous aggregates
https://reviews.llvm.org/D50507
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/arm-vfp16-arguments.c
test/CodeGen/arm_neon_intrinsics.c
Index: test/CodeGen/arm_neon_intrinsics.c
=
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, javed.absar.
clangd maintains the last good preamble for each TU and clang treats an empty
preamble as an error, therefore, clangd will use the stale preamble for
a
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Empty preamble is valid for source file which doesn't have any
preprocessor and #includes.
This patch makes clang treat an empty preamble as a normal preamble.
Check: ninja check-clang
A testcase is added in https://reviews.l
riccibruno created this revision.
riccibruno added reviewers: erichkeane, rjmccall.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.
The current static_assert only checks that ObjCObjectTypeBitfields
fits into an unsigned. However it turns out that FunctionTypeBitfields
d
riccibruno created this revision.
riccibruno added reviewers: erichkeane, rjmccall.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.
Since FunctionTypeBitfields is already > 32 bits wide we might
as well stuff the remaining bits from FunctionProtoType into it.
The patch
ilya-biryukov added a comment.
Maybe also add a test for find-definition that was broken before? (non-empty
preamble -> empty preamble -> bad gotodef that goes to included file instead of
the local variable)
To have a regression test against similar failures.
Comment at: unit
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D50628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
ilya-biryukov added inline comments.
Comment at: clangd/XRefs.cpp:71
+struct DeclInfo {
+ const Decl *D;
NIT: maybe call `Occurence` instead? As this is actually a `Decl` with some
extra data, computed based on the expression it originated from. Occurence
se
Merged to 7.0 in r339555.
On Wed, Aug 8, 2018 at 5:53 PM, Simon Pilgrim via cfe-commits
wrote:
> Author: rksimon
> Date: Wed Aug 8 08:53:14 2018
> New Revision: 339264
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339264&view=rev
> Log:
> [CGObjCGNU] Rename GetSelector helper method to fix -W
aaron.ballman added inline comments.
Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:23
+
+ Finder->addMatcher(namespaceDecl(hasName("absl")).bind("absl_namespace"),
+ this);
hokein wrote:
> aaron.ballman wrote:
> > I think this needs a `n
Merged to 7.0 in r339554.
On Tue, Aug 7, 2018 at 12:37 AM, Stella Stamenova via cfe-commits
wrote:
> Author: stella.stamenova
> Date: Mon Aug 6 15:37:45 2018
> New Revision: 339074
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339074&view=rev
> Log:
> [lit, python] Always add quotes around th
Author: rksimon
Date: Mon Aug 13 05:24:48 2018
New Revision: 339557
URL: http://llvm.org/viewvc/llvm-project?rev=339557&view=rev
Log:
Fix MSVC 'std::min: no matching overloaded function found' error.
Modified:
clang-tools-extra/trunk/clangd/index/dex/Trigram.cpp
Modified: clang-tools-extra/t
ldionne added a comment.
In https://reviews.llvm.org/D49240#1196878, @hans wrote:
> The reason we noticed this was that it caused a *50 GB* size increase of the
> build output on our buildbots, which was enough to cause infrastructure
> problems.
>
> This change was also committed shortly befor
Author: hokein
Date: Mon Aug 13 05:50:30 2018
New Revision: 339558
URL: http://llvm.org/viewvc/llvm-project?rev=339558&view=rev
Log:
Revert "Allow relockable scopes with thread safety attributes."
This reverts commit r339456.
The change introduces a new crash, see
class SCOPED_LOCKABLE FileLock
hokein added a comment.
Hello, this patch seems introduce a new crash, and I have reverted it in
r339558.
Here is the minimal test case:
class SCOPED_LOCKABLE FileLock {
public:
explicit FileLock()
EXCLUSIVE_LOCK_FUNCTION(file_);
~FileLock() UNLOCK_FUNCTION(file_);
//vo
balazske updated this revision to Diff 160335.
balazske added a comment.
- replaced ASSERT in test
Repository:
rC Clang
https://reviews.llvm.org/D50516
Files:
lib/AST/ASTImporter.cpp
unittests/AST/ASTImporterTest.cpp
Index: unittests/AST/ASTImporterTest.cpp
=
deannagarcia added inline comments.
Comment at: test/clang-tidy/abseil-duration-division.cpp:58
+ // CHECK-MESSAGES: [[@LINE-4]]:45: warning: operator/ on absl::Duration
objects
+ // CHECK-FIXES: double DoubleDivision(T t1, T t2) {return
+ // absl::FDivDuration(t1, t2);}
deannagarcia updated this revision to Diff 160336.
deannagarcia marked 6 inline comments as done.
https://reviews.llvm.org/D50389
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/DurationDivisionCheck.cpp
clang-tidy/abseil/DurationDivisionCh
erichkeane added inline comments.
Comment at: include/clang/AST/Type.h:1639
+
+static_assert(sizeof(TypeBitfields) <= 4,
+ "TypeBitfields is larger than 4 bytes!");
I don't really see value in ensuring that TypeBitfields is <= 4 bytes, it see
deannagarcia updated this revision to Diff 160338.
https://reviews.llvm.org/D50389
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/DurationDivisionCheck.cpp
clang-tidy/abseil/DurationDivisionCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy
erichkeane added a subscriber: rsmith.
erichkeane added inline comments.
Comment at: include/clang/AST/Type.h:1527
+/// The number of parameters this function has, not counting '...'.
+unsigned NumParams : 12;
+
This concerns me a bit with variadic templa
Author: balazske
Date: Mon Aug 13 06:08:37 2018
New Revision: 339560
URL: http://llvm.org/viewvc/llvm-project?rev=339560&view=rev
Log:
[ASTImporter] Improved import of friend templates.
Summary:
When importing a friend class template declaration,
this declaration should not be merged with any oth
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339560: [ASTImporter] Improved import of friend templates.
(authored by balazske, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50516
Files:
riccibruno added inline comments.
Comment at: include/clang/AST/Type.h:1530
+/// The number of types in the exception spec, if any.
+unsigned NumExceptions : 9;
+
erichkeane wrote:
> IMO (and @rsmith should respond here instead), if we were looking to ste
riccibruno marked an inline comment as done.
riccibruno added inline comments.
Comment at: include/clang/AST/Type.h:1639
+
+static_assert(sizeof(TypeBitfields) <= 4,
+ "TypeBitfields is larger than 4 bytes!");
erichkeane wrote:
> I don't real
mboehme updated this revision to Diff 160347.
mboehme added a comment.
Rebase to head.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49910
Files:
clang-tidy/bugprone/UseAfterMoveCheck.cpp
docs/clang-tidy/checks/bugprone-use-after-move.rst
test/clang-tidy/bugprone-use-aft
mboehme updated this revision to Diff 160348.
mboehme marked 2 inline comments as done.
mboehme added a comment.
Rebase to head.
Repository:
rC Clang
https://reviews.llvm.org/D49911
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib/Sema/SemaDeclAttr.cpp
test/Sema
mboehme added a comment.
Thank you for the review!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D49910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
In https://reviews.llvm.org/D49240#1197052, @ldionne wrote:
> In https://reviews.llvm.org/D49240#1196878, @hans wrote:
>
> > The reason we noticed this was that it caused a *50 GB* size increase of
> > the build output on our buildbots, which was enough to cause infrastruct
Author: abataev
Date: Mon Aug 13 07:05:43 2018
New Revision: 339568
URL: http://llvm.org/viewvc/llvm-project?rev=339568&view=rev
Log:
[OPENMP] Fix emission of the loop doacross constructs.
The number of loops associated with the OpenMP loop constructs should
not be considered as the number loops
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50635
Files:
test/clangd/completion-snippets.test
test/clangd/completion.test
Index: te
Author: mboehme
Date: Mon Aug 13 07:11:03 2018
New Revision: 339569
URL: http://llvm.org/viewvc/llvm-project?rev=339569&view=rev
Log:
Summary:Add clang::reinitializes attribute
Summary:
This is for use by clang-tidy's bugprone-use-after-move check -- see
corresponding clang-tidy patch at https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339569: Summary:Add clang::reinitializes attribute (authored
by mboehme, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49911?vs=160348&id=160351#toc
Repository:
rC Clang
https:/
ldionne added a comment.
In https://reviews.llvm.org/D49240#1197149, @hans wrote:
> In https://reviews.llvm.org/D49240#1197052, @ldionne wrote:
>
> > In https://reviews.llvm.org/D49240#1196878, @hans wrote:
> >
> > > The reason we noticed this was that it caused a *50 GB* size increase of
> > >
Author: mboehme
Date: Mon Aug 13 07:24:52 2018
New Revision: 339571
URL: http://llvm.org/viewvc/llvm-project?rev=339571&view=rev
Log:
[clang-tidy] Recognize [[clang::reinitializes]] attribute in
bugprone-use-after-move
Summary:
This allows member functions to be marked as reinitializing the obje
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339571: [clang-tidy] Recognize [[clang::reinitializes]]
attribute in bugprone-use-after… (authored by mboehme, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://revie
MTC added a comment.
kindly ping!
Repository:
rC Clang
https://reviews.llvm.org/D48027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50635
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
Author: kadircet
Date: Mon Aug 13 07:32:19 2018
New Revision: 339572
URL: http://llvm.org/viewvc/llvm-project?rev=339572&view=rev
Log:
Fix lint tests for D50449
Reviewers: ilya-biryukov, hokein
Reviewed By: hokein
Subscribers: hokein, ioeric, jkorous, arphaman, cfe-commits
Differential Revisio
Author: krasimir
Date: Mon Aug 13 07:32:29 2018
New Revision: 339573
URL: http://llvm.org/viewvc/llvm-project?rev=339573&view=rev
Log:
[clang-format] Fix comment, NFC
Modified:
cfe/trunk/unittests/Format/FormatTestTextProto.cpp
Modified: cfe/trunk/unittests/Format/FormatTestTextProto.cpp
URL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339572: Fix lint tests for D50449 (authored by kadircet,
committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D50635
Files:
clang-tools-extra/trunk/t
Author: abataev
Date: Mon Aug 13 07:42:18 2018
New Revision: 339574
URL: http://llvm.org/viewvc/llvm-project?rev=339574&view=rev
Log:
Revert "[OPENMP] Fix emission of the loop doacross constructs."
This reverts commit r339568 because of the problems with the buildbots.
Modified:
cfe/trunk/in
hugoeg marked 8 inline comments as done.
hugoeg added inline comments.
Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:2
+// RUN: %check_clang_tidy %s abseil-no-internal-deps %t
+
+
hokein wrote:
> nit: please make sure the code follow LLVM code style, ev
hugoeg updated this revision to Diff 160363.
hugoeg added a comment.
most corrections from comments have been applied
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoInternalDepsCheck.cpp
clang-tidy/absei
acoomans added a comment.
Can anyone confirm the `-debug-info-macro` command line option is unavailable
with the PS4 SDK?
Repository:
rC Clang
https://reviews.llvm.org/D50410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
mikerice created this revision.
Herald added a subscriber: cfe-commits.
This clang-cl driver change removes the PCH options when we are only generating
preprocessed output. This is similar to the behavior of Y-.
Repository:
rC Clang
https://reviews.llvm.org/D50640
Files:
lib/Driver/Driv
riccibruno updated this revision to Diff 160368.
riccibruno marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D50630
Files:
include/clang/AST/Type.h
Index: include/clang/AST/Type.h
===
--- include
jkorous created this revision.
jkorous added reviewers: sammccall, ilya-biryukov.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, arphaman, dexonsmith, MaskRay, ioeric.
There's a small typo in tests - causing that we aren't sending exit LSP message
to clangd but
JonasToth added inline comments.
Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:2
+// RUN: %check_clang_tidy %s abseil-no-internal-deps %t
+
+
hugoeg wrote:
> hokein wrote:
> > nit: please make sure the code follow LLVM code style, even for test code :)
JonasToth added inline comments.
Comment at: clang-tidy/abseil/NoInternalDepsCheck.h:21
+/// against doing so. This check should not be run on internal Abseil files or
+///Abseil source code.
+///
double blank
Comment at: docs/clang-tidy/ch
hugoeg updated this revision to Diff 160371.
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoInternalDepsCheck.cpp
clang-tidy/abseil/NoInternalDepsCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/ab
JonasToth added a comment.
Please add a test for the same usecase as in Sema.
template
struct SizeIndicator {
constexpr int value = 8;
};
template <>
struct SizeIndicator {
constexpr int value = 4;
};
template
void fooFunction() {
char Characters[SizeIndicator::value
riccibruno updated this revision to Diff 160369.
riccibruno marked 5 inline comments as done.
riccibruno edited the summary of this revision.
riccibruno added a comment.
Bumped the number of bits for parameters from 12 to 14,
stealing from NumExceptions. This means that now (unless
limited by some
JonasToth added inline comments.
Comment at: unittests/clang-tidy/ExprMutationAnalyzerTest.cpp:454
+
+ AST =
+ tooling::buildASTFromCode("template void f() { T x; x.y.z; }");
JonasToth wrote:
> Is there already a test for a method from a templated type?
>
jfb added a comment.
CC some sanitizer folks.
https://reviews.llvm.org/D50549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hugoeg added inline comments.
Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:2
+// RUN: %check_clang_tidy %s abseil-no-internal-deps %t
+
+
JonasToth wrote:
> hugoeg wrote:
> > hokein wrote:
> > > nit: please make sure the code follow LLVM code style, ev
Author: epilk
Date: Mon Aug 13 09:37:47 2018
New Revision: 339580
URL: http://llvm.org/viewvc/llvm-project?rev=339580&view=rev
Log:
[itanium demangler] Add llvm::itaniumFindTypesInMangledName()
This function calls a callback whenever a is parsed.
This is necessary to implement FindAlternateFunc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339581: [SEMA] add more -Wfloat-conversion to compound
assigment analysis (authored by nickdesaulniers, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm
Author: brunoricci
Date: Mon Aug 13 09:40:57 2018
New Revision: 339582
URL: http://llvm.org/viewvc/llvm-project?rev=339582&view=rev
Log:
[AST] Update/correct the static_asserts for the bit-fields in Type
The current static_assert only checks that ObjCObjectTypeBitfields
fits into an unsigned. How
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339582: [AST] Update/correct the static_asserts for the
bit-fields in Type (authored by brunoricci, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50630
Files:
include/clang/AST/Type
nickdesaulniers added a comment.
Thank you for the code review.
Repository:
rL LLVM
https://reviews.llvm.org/D50467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nickdesaulniers
Date: Mon Aug 13 09:38:07 2018
New Revision: 339581
URL: http://llvm.org/viewvc/llvm-project?rev=339581&view=rev
Log:
[SEMA] add more -Wfloat-conversion to compound assigment analysis
Summary: Fixes Bug: https://bugs.llvm.org/show_bug.cgi?id=27061
Reviewers: aaron.ballman
dvyukov added inline comments.
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73
assert(!t0.joinable());
while (!done) {}
assert(G::op_run);
I don't immediately see how the race on n
riccibruno created this revision.
riccibruno added a reviewer: erichkeane.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.
Type has enough space for two members of
TemplateSpecializationType. Mechanical patch.
Repository:
rC Clang
https://reviews.llvm.org/D50643
Fi
hugoeg updated this revision to Diff 160380.
hugoeg marked 3 inline comments as done.
https://reviews.llvm.org/D50542
Files:
clang-tidy/abseil/AbseilTidyModule.cpp
clang-tidy/abseil/CMakeLists.txt
clang-tidy/abseil/NoInternalDepsCheck.cpp
clang-tidy/abseil/NoInternalDepsCheck.h
docs/Rel
erichkeane added a comment.
I think that this causes UB. The Type baseclass will use the TypeBitfields
active member, but this uses the TemplateSpecializationTypeBits, right? I know
we take advantage of this elsewhere, but I'm tentative about this one...
Repository:
rC Clang
https://revie
BillyONeal added inline comments.
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73
assert(!t0.joinable());
while (!done) {}
assert(G::op_run);
dvyukov wrote:
> I don't immediately s
ilya-biryukov created this revision.
ilya-biryukov added reviewers: hokein, ioeric, kadircet.
Herald added subscribers: arphaman, jkorous, MaskRay.
To avoid producing very verbose output in substitutions involving
typedefs, e.g.
T -> std::vector::iterator
gets turned into an unreadable mess wh
BillyONeal added inline comments.
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73
assert(!t0.joinable());
while (!done) {}
assert(G::op_run);
BillyONeal wrote:
> dvyukov wrote:
> >
riccibruno added a comment.
All of these bitfields (ab)use are already UB I think...
I don't see what is special in this case...
Repository:
rC Clang
https://reviews.llvm.org/D50643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
dvyukov added inline comments.
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73
assert(!t0.joinable());
while (!done) {}
assert(G::op_run);
BillyONeal wrote:
> BillyONeal wrote:
> >
nickdesaulniers created this revision.
nickdesaulniers added reviewers: aaron.ballman, gkistanova.
Herald added a subscriber: cfe-commits.
Fixes commit 6bbde717f7fb ("[SEMA] add more -Wfloat-conversion to
compound assigment analysis").
This test case was caught in postsubmit testing.
Repository
On Mon, Aug 13, 2018 at 1:08 PM, Nick Desaulniers via Phabricator
wrote:
> nickdesaulniers created this revision.
> nickdesaulniers added reviewers: aaron.ballman, gkistanova.
> Herald added a subscriber: cfe-commits.
>
> Fixes commit 6bbde717f7fb ("[SEMA] add more -Wfloat-conversion to
> compound
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Ah, right. I missed that the others already do it. Fine I guess...
Repository:
rC Clang
https://reviews.llvm.org/D50643
___
cfe-comm
BillyONeal added inline comments.
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73
assert(!t0.joinable());
while (!done) {}
assert(G::op_run);
dvyukov wrote:
> BillyONeal wrote:
> >
BillyONeal added inline comments.
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73
assert(!t0.joinable());
while (!done) {}
assert(G::op_run);
BillyONeal wrote:
> dvyukov wrote:
> >
dvyukov added inline comments.
Comment at:
test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73
assert(!t0.joinable());
while (!done) {}
assert(G::op_run);
BillyONeal wrote:
> BillyONeal wrote:
> >
1 - 100 of 222 matches
Mail list logo
