JonasToth added inline comments.
================
Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:2
+// RUN: %check_clang_tidy %s abseil-no-internal-deps %t
+
+
----------------
hugoeg wrote:
> hokein wrote:
> > nit: please make sure the code follow LLVM code style, even for test code :)
> what is this in reference too?
> Will the test still work if I wrap the CHECK MESSAGE lines?
CHECK-MESSAGE can be on one line, even if its longer (that is common in the
clang-tidy tests).
But dont use many empty lines and respect naming conventions and run
clang-format over the code (except there is a valid reason that the formatting
would infer with the tested logic).
================
Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:11
+
+namespace absl {
+std::string StringsFunction (std::string s1){
----------------
hugoeg wrote:
> hokein wrote:
> > Since we have multiple abseil checks that might use these fake abseil
> > declarations, I'd suggest pull out these to a common header, and include it
> > in this test file.
> do I just put the header file in test/clang-tidy ?
yes, there is one other similar case `hicpp-signed-bitwise-standard-types.h`
https://reviews.llvm.org/D50542
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
