On Mon, Aug 13, 2018 at 1:08 PM, Nick Desaulniers via Phabricator <revi...@reviews.llvm.org> wrote: > nickdesaulniers created this revision. > nickdesaulniers added reviewers: aaron.ballman, gkistanova. > Herald added a subscriber: cfe-commits. > > Fixes commit 6bbde717f7fb ("[SEMA] add more -Wfloat-conversion to > compound assigment analysis").
Thank you for fixing this, but in the future, can you please put the SVN revision number into the commit message rather than a git hash (for code archaeology purposes)? Not everyone is on git yet. :-) r339581 is the amended revision in this case. ~Aaron > > This test case was caught in postsubmit testing. > > > Repository: > rC Clang > > https://reviews.llvm.org/D50647 > > Files: > test/Sema/conversion.c > > > Index: test/Sema/conversion.c > =================================================================== > --- test/Sema/conversion.c > +++ test/Sema/conversion.c > @@ -359,7 +359,7 @@ > void test_7676608(void) { > float q = 0.7f; > char c = 5; > - f7676608(c *= q); > + f7676608(c *= q); // expected-warning {{conversion}} > } > > // <rdar://problem/7904686> > > _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits