ldionne added a comment.
In https://reviews.llvm.org/D50205#1188454, @EricWF wrote:
> How does this work when a user provides their own definitions? Does the
> attribute from the declaration still produce a warning? If so, then I think
> an in-compiler approach is better.
Yes. I do agree that
Author: ldionne
Date: Mon Aug 6 07:29:47 2018
New Revision: 339016
URL: http://llvm.org/viewvc/llvm-project?rev=339016&view=rev
Log:
[clang] Fix broken include_next in float.h
Summary:
The code defines __FLOAT_H and then includes the next , which is
guarded on __FLOAT_H so it gets skipped entire
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339016: [clang] Fix broken include_next in float.h (authored
by ldionne, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50276?vs=159109&id=15
Author: brunoricci
Date: Mon Aug 6 07:33:45 2018
New Revision: 339017
URL: http://llvm.org/viewvc/llvm-project?rev=339017&view=rev
Log:
[AST] Move the enum in ObjCMethodDeclBitfields
Move the enum { ObjCMethodFamilyBitWidth = 4 } to the top of
the class. For some dark reason having the enum betw
I can't seem to reproduce the ASan failure locally, even after building
a clang with the latest compiler-rt, and then rebuilding my patch with
LLVM_USE_SANITIZER=Address
I am pretty confident the problem should be fixed with a one-line change
to my patch:
-auto CreateArrayForSizeVar = [=
Author: martong
Date: Mon Aug 6 07:38:37 2018
New Revision: 339018
URL: http://llvm.org/viewvc/llvm-project?rev=339018&view=rev
Log:
[ASTmporter] SourceRange-free function parameter checking for declarations
Summary: The previous code which avoided infinite recursion (because of
reparsing decla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339018: [ASTmporter] SourceRange-free function parameter
checking for declarations (authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
martong added a comment.
Ping.
Manuel, I still don't see how could we apply `match(anyOf(node),
hasDescendant(node))` to the problem of general subtree traversal.
(I'd like to have support for not just `decl()` but other kind of nodes too.)
Could you please advise how to move on? Also, could yo
ldionne abandoned this revision.
ldionne added a comment.
Nevermind, it looks like this patch is not necessary anymore since
https://reviews.llvm.org/D45015 landed.
Repository:
rCXX libc++
https://reviews.llvm.org/D50205
___
cfe-commits mailing
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: arphaman, mgrang, jkorous, MaskRay, mgorny.
This patch is a proof-of-concept Dex index implementation. It has several
flaws, which don't allow re
Author: brunoricci
Date: Mon Aug 6 08:17:32 2018
New Revision: 339024
URL: http://llvm.org/viewvc/llvm-project?rev=339024&view=rev
Log:
[AST] Add individual size info for Types in -print-stats
This mirrors what is done for Decls and Stmts in the -print-stats
output, ie instead of printing "57426
kbobyrev planned changes to this revision.
kbobyrev added a comment.
The patch is currently in preview-mode; I have to make few changes:
- Improve testing infrastructure; one possible way would be to use exactly the
same code `MemIndex` currently does as it is meant to be a drop-in replacement.
theraven updated this revision to Diff 159312.
theraven added a comment.
- Fix failing test.
Repository:
rC Clang
https://reviews.llvm.org/D50144
Files:
include/clang/Driver/Options.td
lib/AST/MicrosoftMangle.cpp
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGException.cpp
lib/CodeGen/CGOb
leonardchan marked an inline comment as done.
leonardchan added inline comments.
Comment at: lib/AST/Expr.cpp:788
FixedPointValueToString(
- S, llvm::APSInt::getUnsigned(getValue().getZExtValue()), Scale, Radix);
+ S, llvm::APSInt::getUnsigned(getValue().getZExtValue
Author: leonardchan
Date: Mon Aug 6 09:05:08 2018
New Revision: 339026
URL: http://llvm.org/viewvc/llvm-project?rev=339026&view=rev
Log:
[Fixed Point Arithmetic] Fix for FixedPointValueToString
- Print negative numbers correctly
- Handle APInts of different sizes
- Add formal unit tests for Fixe
This revision was automatically updated to reflect the committed changes.
leonardchan marked an inline comment as done.
Closed by commit rC339026: [Fixed Point Arithmetic] Fix for
FixedPointValueToString (authored by leonardchan, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D4
leonardchan updated this revision to Diff 159315.
leonardchan added reviewers: ebevhan, rjmccall.
leonardchan removed a subscriber: ebevhan.
leonardchan added a comment.
- Changed diff such that an error is dumped instead. The code shouldn't compile
in the first place since it involves conversion
leonardchan updated this revision to Diff 159320.
leonardchan marked an inline comment as done.
leonardchan added a comment.
- Fixed `Accumum` names
Repository:
rC Clang
https://reviews.llvm.org/D48661
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/FixedPoint.h
include/clang
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339028: [Fixed Point Arithmetic] Fixed Point Constant
(authored by leonardchan, committed by ).
Herald added a subscriber:
Author: leonardchan
Date: Mon Aug 6 09:42:37 2018
New Revision: 339028
URL: http://llvm.org/viewvc/llvm-project?rev=339028&view=rev
Log:
[Fixed Point Arithmetic] Fixed Point Constant
This patch proposes an abstract type that represents fixed point numbers,
similar to APInt or APSInt that was di
Author: brunoricci
Date: Mon Aug 6 09:47:31 2018
New Revision: 339030
URL: http://llvm.org/viewvc/llvm-project?rev=339030&view=rev
Log:
[AST] Remove unnecessary indirections in DeclarationNameTable
DeclarationNameTable currently hold 3 "void *" to
FoldingSet, FoldingSet
and FoldingSet.
CXXSpeci
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339030: [AST] Remove unnecessary indirections in
DeclarationNameTable (authored by brunoricci, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/
saar.raz updated this revision to Diff 159323.
saar.raz added a comment.
Herald added a subscriber: jfb.
Adjusted to switch to ASTTemplateArgumentListInfo
Repository:
rC Clang
https://reviews.llvm.org/D41910
Files:
include/clang/AST/DeclTemplate.h
include/clang/Basic/DiagnosticSemaKinds.
Have you tried setting detect_stack_use_after_return in ASAN_OPTIONS? The
ASan buildbot sets the following ASAN_OPTIONS prior to running tests:
export
ASAN_OPTIONS="check_initialization_order=true:detect_stack_use_after_return=1:detect_leaks=1"
On Mon, Aug 6, 2018 at 7:34 AM wrote:
> I can't see
Author: d0k
Date: Mon Aug 6 09:53:21 2018
New Revision: 339031
URL: http://llvm.org/viewvc/llvm-project?rev=339031&view=rev
Log:
[Fixed Point Arithmetic] Remove unused include.
lib/Basic cannot depend on lib/AST.
Modified:
cfe/trunk/lib/Basic/FixedPoint.cpp
Modified: cfe/trunk/lib/Basic/Fi
bricci added a comment.
Just a nit but could you please add new-lines to your commit messages.
Also the 3 bools in FixedPointSemantics are a little bit wasteful.
Repository:
rL LLVM
https://reviews.llvm.org/D48661
___
cfe-commits mailing list
cfe
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
Great, thanks a lot!
https://reviews.llvm.org/D49438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
bricci added a comment.
And using the name Sema is a bad idea IMHO since this has a totally different
meaning in clang.
Repository:
rL LLVM
https://reviews.llvm.org/D48661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
leonardchan added a comment.
In https://reviews.llvm.org/D48661#1189537, @bricci wrote:
> Just a nit but could you please add new-lines to your commit messages.
My bad, will remember this for future commits.
> Also the 3 bools in FixedPointSemantics are a little bit wasteful.
> I don't know h
pirama updated this revision to Diff 159330.
pirama added a comment.
Rebase
Repository:
rC Clang
https://reviews.llvm.org/D37302
Files:
lib/Headers/float.h
test/Headers/float.c
Index: test/Headers/float.c
===
--- test/Head
pirama added a comment.
Sorry this fell of my radar. I've rebased the patch.
Since this has been inactive for a while, lets wait for a couple of days to see
if there are any other comments. If there are no objections, I'll submit this
on Wednesday.
Repository:
rC Clang
https://reviews.ll
ldionne added a comment.
In https://reviews.llvm.org/D37302#1189576, @pirama wrote:
> Sorry this fell of my radar. I've rebased the patch.
>
> Since this has been inactive for a while, lets wait for a couple of days to
> see if there are any other comments. If there are no objections, I'll sub
a.sidorin accepted this revision.
a.sidorin added a comment.
Hi Balazs,
I have only two nits. Otherwise, the patch is OK and can be committed without
additional approval after the comments are fixed. Thank you!
Comment at: lib/AST/ASTStructuralEquivalence.cpp:1500
+bool Stru
saar.raz updated this revision to Diff 159331.
saar.raz added a comment.
- Fix bad handling of checking of deduced arguments in function templates
Repository:
rC Clang
https://reviews.llvm.org/D41910
Files:
include/clang/AST/DeclTemplate.h
include/clang/Basic/DiagnosticSemaKinds.td
inc
ldionne created this revision.
ldionne added a reviewer: vsapsai.
Herald added a reviewer: EricWF.
Herald added subscribers: cfe-commits, dexonsmith, christof.
Since r338934, Clang emits an error when aligned allocation functions are
used in conjunction with a system libc++ dylib that does not sup
Author: greened
Date: Mon Aug 6 10:35:44 2018
New Revision: 339036
URL: http://llvm.org/viewvc/llvm-project?rev=339036&view=rev
Log:
Force test/Driver/fuchsia.c(pp) to use lld
The Fuchsia driver relies on lld so invoke clang with
-fuse-ld=lld. This gets the test passing when the clang default li
gtbercea updated this revision to Diff 159335.
gtbercea added a comment.
Fix function call.
Repository:
rC Clang
https://reviews.llvm.org/D47849
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChains/Clang.cpp
lib/Driver/ToolChains/Cuda.cpp
lib/Driver/ToolChains/Cuda.h
lib
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339036: Force test/Driver/fuchsia.c(pp) to use lld (authored
by greened, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49899?vs=157689&id=15
greened added a comment.
Ping...
Repository:
rC Clang
https://reviews.llvm.org/D49244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
greened added a comment.
In https://reviews.llvm.org/D49897#1180338, @sbc100 wrote:
> How do you configure clang to use a different linker? It looks like
> getDefaultLinker() is hardcoded, but maybe I'm missing something.
I pass -fuse-ld in the test RUN lines.
Repository:
rC Clang
https:
kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
kzhuravl accepted this revision.
kzhuravl added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D50320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
emmettneyman created this revision.
emmettneyman added reviewers: morehouse, kcc.
Herald added a subscriber: cfe-commits.
Changed the structure of the generated IR to make it easier to vectorize
Repository:
rC Clang
https://reviews.llvm.org/D50342
Files:
clang/tools/clang-fuzzer/proto-to-l
Author: leonardchan
Date: Mon Aug 6 10:55:38 2018
New Revision: 339037
URL: http://llvm.org/viewvc/llvm-project?rev=339037&view=rev
Log:
Fix for failing test from sanitizer-x86_64-linux-fast where there was a
left shift on a negative value.
Modified:
cfe/trunk/unittests/Basic/FixedPointTest.
2018-07-13 10:07 GMT-05:00 Erich Keane via cfe-commits
:
> -class AttributeList { // TODO: This should really be called ParsedAttribute
> +class ParsedAttr { // TODO: This should really be called ParsedAttribute
Should this TODO be removed/ParsedAttr really be called ParsedAttribute?
Michael
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
https://reviews.llvm.org/D50199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: leonardchan
Date: Mon Aug 6 11:02:16 2018
New Revision: 339038
URL: http://llvm.org/viewvc/llvm-project?rev=339038&view=rev
Log:
Removed the OverflowConversionsToFract tests for now. Will add them back
in once I figure out why this doesn't work on windows.
Modified:
cfe/trunk/unittes
Author: erichkeane
Date: Mon Aug 6 11:11:48 2018
New Revision: 339039
URL: http://llvm.org/viewvc/llvm-project?rev=339039&view=rev
Log:
[NFC] Remove TODO comment that no longer applies (ParsedAttr)
Modified:
cfe/trunk/include/clang/Sema/ParsedAttr.h
Modified: cfe/trunk/include/clang/Sema/Pa
Good grief... I even made a note to remove this 'TODO' on my whiteboard!
I discussed the name with AaronBallman who preferred ParsedAttr over
ParsedAttribute (since ParsedAttributes is also a type).
Fixed in r339039.
-Original Message-
From: meiners...@googlemail.com [mailto:meiners...@
scott.linder added a comment.
When I went to mark these as static I noticed they use
`CGDebugInfo::CreateMemberType` which uses a couple other non-static member
functions, and it starts to become difficult to tease things out into nice
clean static functions.
Comment at: lib
rnk added a comment.
Neat, thanks for the optimization. My only concern would be to find a way to
avoid including Type.h, but it's already a very popular and very necessary
header, so I don't think there is any issue here.
Repository:
rL LLVM
https://reviews.llvm.org/D50261
_
echristo added a comment.
In https://reviews.llvm.org/D50099#1189667, @scott.linder wrote:
> When I went to mark these as static I noticed they use
> `CGDebugInfo::CreateMemberType` which uses a couple other non-static member
> functions, and it starts to become difficult to tease things out in
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:125
std::ostream &operator<<(std::ostream &os, const LoopFunction &x) {
- return os << "define void @foo(i32* %a, i32* %b, i32* noalias %c, i64 %s)
{\n"
-<< "
rnk added a comment.
In https://reviews.llvm.org/D50055#1188479, @chandlerc wrote:
> Maybe double check with Reid and/or Hal to make sure we've all ended up on
> the same page before landing though.
lgtm, thanks
https://reviews.llvm.org/D50055
_
scott.linder added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:997
llvm::DINode::DIFlags Flags = llvm::DINode::FlagAppleBlock;
unsigned LineNo = 0;
echristo wrote:
> scott.linder wrote:
> > echristo wrote:
> > > Just noticed that LineNo is 0.
sbc100 added a comment.
But in the CL description you say "..when configuring clang to use a different
linker by default". How is this possible?i.e. do you have a config where
these tests are currently failing?
Repository:
rC Clang
https://reviews.llvm.org/D49897
___
riccibruno added a comment.
Yes it would be nice indeed. IIRC it is only needed for
QualType in one of the moved class.
This patch is especially nice since it both cleanup the code and
speed up clang :)
Repository:
rL LLVM
https://reviews.llvm.org/D50261
__
That's what I was missing; I should have looked more closely at the
buildbot logs, I see the export there now.
Thanks!
Scott
On 2018-08-06 12:51, Vlad Tsyrklevich wrote:
Have you tried setting detect_stack_use_after_return in ASAN_OPTIONS?
The ASan buildbot sets the following ASAN_OPTIONS prio
ldionne created this revision.
ldionne added a reviewer: vsapsai.
Herald added a reviewer: EricWF.
Herald added subscribers: cfe-commits, dexonsmith, christof.
The current code enables aligned allocation functions when compiling in C++17
and later. This is a problem because aligned allocation func
saar.raz updated this revision to Diff 159349.
saar.raz added a comment.
Herald added a subscriber: jfb.
- Fix bad diagnostic detection and suppression
Repository:
rC Clang
https://reviews.llvm.org/D43357
Files:
include/clang/AST/Decl.h
include/clang/AST/DeclCXX.h
include/clang/AST/Rec
Szelethus added a comment.
I think what pointer chasing should do, is check whether that pointer owns the
pointee. In that case, it should be fine to analyze it. Do you mind if I put a
TODO around flag's description stating that this should be implemented and
pointer chasing should be enabled b
Author: leonardchan
Date: Mon Aug 6 12:31:00 2018
New Revision: 339044
URL: http://llvm.org/viewvc/llvm-project?rev=339044&view=rev
Log:
Fix for broken build on clang-hexagon-elf for ambiguous call to
std::abs.
Modified:
cfe/trunk/lib/Basic/FixedPoint.cpp
Modified: cfe/trunk/lib/Basic/Fixed
george.karpenkov added a comment.
> I think what pointer chasing should do, is check whether that pointer owns
> the pointee
But ownership is a convention, and it's not always deducible from a codebase.
I think of those as two separate checks, and I think we should only talk about
enabling the
bviyer updated this revision to Diff 159353.
https://reviews.llvm.org/D49952
Files:
lib/CodeGen/CGExprConstant.cpp
test/CodeGenCXX/empty-struct-init-list.cpp
Index: test/CodeGenCXX/empty-struct-init-list.cpp
===
--- /dev/null
+
bviyer marked an inline comment as done.
bviyer added a comment.
John, I have updated the test case as you requested (I think). I am a bit new
to Clang, so apologize if I mistook your request.
https://reviews.llvm.org/D49952
___
cfe-commits mailing
steveire created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50346
Files:
include/clang/AST/Comment.h
include/clang/AST/Decl.h
include/clang/AST/DeclBase.h
include/clang/AST/DeclCXX.h
include/clang/AST/DeclObjC.h
include/cla
steveire created this revision.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50348
Files:
include/clang/AST/Comment.h
include/clang/AST/Decl.h
include/clang/AST/DeclBase.h
include/clang/AST/DeclCXX.h
include/clang/AST/DeclObjC.h
include/cla
steveire created this revision.
Herald added a reviewer: teemperor.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50349
Files:
include/clang/AST/Decl.h
lib/AST/ASTImporter.cpp
lib/Analysis/CloneDetection.cpp
lib/CodeGen/CoverageMappingGen.cpp
steveire created this revision.
Herald added a reviewer: teemperor.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D50347
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/Stmt.h
include/clang/Analysis/CloneDetection.h
lib/CodeGen/CoverageMappi
steveire created this revision.
Herald added subscribers: cfe-commits, jfb, whisperity, jholewinski.
Herald added a reviewer: teemperor.
Repository:
rC Clang
https://reviews.llvm.org/D50350
Files:
docs/RAVFrontendAction.rst
include/clang/AST/Comment.h
include/clang/AST/Decl.h
include/c
steveire created this revision.
Herald added a reviewer: teemperor.
Herald added a subscriber: cfe-commits.
Herald added a reviewer: teemperor.
Repository:
rC Clang
https://reviews.llvm.org/D50353
Files:
include/clang/AST/Comment.h
include/clang/AST/Decl.h
include/clang/AST/DeclBase.h
steveire created this revision.
Herald added subscribers: cfe-commits, kbarton, ioeric, nemanjai.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50355
Files:
change-namespace/ChangeNamespace.cpp
clang-move/ClangMove.cpp
clang-tidy/android/CloexecCheck.cpp
clang-tidy/bugpr
Author: mstorsjo
Date: Mon Aug 6 12:48:44 2018
New Revision: 339048
URL: http://llvm.org/viewvc/llvm-project?rev=339048&view=rev
Log:
[MinGW] Predefine UNICODE if -municode is specified during compilation
Differential Revision: https://reviews.llvm.org/D50199
Modified:
cfe/trunk/lib/Driver/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC339048: [MinGW] Predefine UNICODE if -municode is specified
during compilation (authored by mstorsjo, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D50199
Files:
lib/Driver/ToolChain
teemperor resigned from this revision.
teemperor added a comment.
This revision now requires review to proceed.
Woops, I wanted to resign actually (and not accept this).
Repository:
rC Clang
https://reviews.llvm.org/D50347
___
cfe-commits mailing
emmettneyman added inline comments.
Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:125
std::ostream &operator<<(std::ostream &os, const LoopFunction &x) {
- return os << "define void @foo(i32* %a, i32* %b, i32* noalias %c, i64 %s)
{\n"
-<
emmettneyman updated this revision to Diff 159373.
emmettneyman added a comment.
Changed pc to unknown
Repository:
rC Clang
https://reviews.llvm.org/D50342
Files:
clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp
Index: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llv
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Sure, that's fine.
https://reviews.llvm.org/D49952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
rjmccall added a comment.
I would expect this to replace the existing warning, not to appear together
with it.
Repository:
rC Clang
https://reviews.llvm.org/D50278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
rjmccall added inline comments.
Comment at: test/Sema/conditional-expr.c:78
+ // expected-error@-1{{converting
'__attribute__((address_space(2))) int *' to type 'void *' changes address
space of pointer}}
+ // expected-error@-2{{conve
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1630
+if (const CXXDestructorDecl *DD = RD->getDestructor())
+ if (const auto FPT = DD->getType()->getAs())
+// Conservatively assume the destructor can throw if the exception
I
morehouse added inline comments.
Comment at: clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp:129
+<< "br i1 %5, label %6, label %8\n"
+<< "; :6:\n"
+<< "br label %9\n"
emmettneyman wrote:
> morehouse wrote:
> > Do
saar.raz updated this revision to Diff 159378.
saar.raz added a comment.
Split TryParseConstrainedParameter and ParseConstrainedTemplateParameter in
preparation for requries expressions.
Repository:
rC Clang
https://reviews.llvm.org/D44352
Files:
include/clang/AST/DeclTemplate.h
include
teemperor added a comment.
I don't think Clang/LLVM use `[[deprecated]]` anywhere. Just change the API and
people have to migrate their code.
Repository:
rC Clang
https://reviews.llvm.org/D50352
___
cfe-commits mailing list
cfe-commits@lists.llv
leonardchan added a comment.
In https://reviews.llvm.org/D50278#1189919, @rjmccall wrote:
> I would expect this to replace the existing warning, not to appear together
> with it.
Will do.
Comment at: test/Sema/conditional-expr.c:78
+ // expected-error@
Szelethus added a comment.
In https://reviews.llvm.org/D49438#1189772, @george.karpenkov wrote:
> > I think what pointer chasing should do, is check whether that pointer owns
> > the pointee
>
> But ownership is a convention, and it's not always deducible from a codebase.
How about the followi
rjmccall added inline comments.
Comment at: test/Sema/conditional-expr.c:78
+ // expected-error@-1{{converting
'__attribute__((address_space(2))) int *' to type 'void *' changes address
space of pointer}}
+ // expected-error@-2{{conve
pirama created this revision.
Herald added a subscriber: mgorny.
The current libclang.so exports only the symbols required for the stable
C api. This is opposed to libLLVM.so, which exports all the symbols
from the LLVM libraries, including those from the C++ API. This patch
adds libclang-cxx.so
Szelethus added a comment.
If we ignore references, check whether the pointee was constructed within the
constructor, and maybe add some other clever heuristics, I'm very much in favor
of enabling pointer chasing by enabled. But I totally support disabling it for
now.
https://reviews.llvm.org
pirama added a comment.
This implements the new library proposed in
http://lists.llvm.org/pipermail/cfe-dev/2018-August/058736.html.
Repository:
rC Clang
https://reviews.llvm.org/D50359
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
ahatanak added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1643
+if (Ctx.getBlockVarCopyInits(VD))
+ return true;
+ return false;
rjmccall wrote:
> Can you just ask Sema to check `canThrow` for the expression and pass it down?
Since this chang
ahatanak updated this revision to Diff 159388.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Address review comments.
Repository:
rC Clang
https://reviews.llvm.org/D50152
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGBlocks.h
lib/CodeGen/CGDecl.cpp
lib/CodeGen/
emmettneyman updated this revision to Diff 159389.
emmettneyman added a comment.
Added back more descriptive variable and loop names
Repository:
rC Clang
https://reviews.llvm.org/D50342
Files:
clang/tools/clang-fuzzer/proto-to-llvm/loop_proto_to_llvm.cpp
Index: clang/tools/clang-fuzzer/p
JonasToth marked an inline comment as done.
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:147
+ // Example: `int i = 10`, `int i` (will be used if program is correct)
+ const auto LocalValDecl = varDecl(unless(anyOf(
+
JonasToth marked an inline comment as done.
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp:183
+ // TODO Implement automatic code transformation to add the 'const'.
+ diag(Variable->getLocStart(), "variable %0 of type %1 can
JonasToth updated this revision to Diff 159390.
JonasToth marked 4 inline comments as done.
JonasToth added a comment.
- address review issues, todos/fixmes and diag nit
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45444
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
ahatanak added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1643
+if (Ctx.getBlockVarCopyInits(VD))
+ return true;
+ return false;
ahatanak wrote:
> rjmccall wrote:
> > Can you just ask Sema to check `canThrow` for the expression and pass it
>
JonasToth added a comment.
In https://reviews.llvm.org/D45444#1189262, @aaron.ballman wrote:
> However, I'm wondering how this should integrate with other const-correctness
> efforts like `readability-non-const-parameter`?
I think this check/functionality will kinda replace the
`readability-n
rsmith added a comment.
+Hans (release manager for LLVM 7)
Hans, this patch series will affect the API of common Clang classes, resulting
in patches to Clang SVN needing some (mechanical) modifications to be applied
to the Clang 7 release branch if we land it now. What do you think about that?
Thank you.
Michael
2018-08-06 13:13 GMT-05:00 Keane, Erich :
> Good grief... I even made a note to remove this 'TODO' on my whiteboard!
>
> I discussed the name with AaronBallman who preferred ParsedAttr over
> ParsedAttribute (since ParsedAttributes is also a type).
>
> Fixed in r339039.
>
> -
1 - 100 of 193 matches
Mail list logo
