ahatanak added inline comments.

================
Comment at: lib/CodeGen/CGBlocks.cpp:1643
+    if (Ctx.getBlockVarCopyInits(VD))
+      return true;
+  return false;
----------------
rjmccall wrote:
> Can you just ask Sema to check `canThrow` for the expression and pass it down?
Since this changes the existing behavior, I made changes to 
test/CodeGenCXX/block-byref-cxx-objc.cpp to test it. Previously, IRGen would 
emit an invoke to call `_Block_object_assign` when the constructor was marked 
as noexcept.


Repository:
  rC Clang

https://reviews.llvm.org/D50152



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to