a.sidorin accepted this revision.
a.sidorin added a comment.
Hi Balazs,
I have only two nits. Otherwise, the patch is OK and can be committed without
additional approval after the comments are fixed. Thank you!
================
Comment at: lib/AST/ASTStructuralEquivalence.cpp:1500
+bool StructuralEquivalenceContext::CommonCheckAtFinish(Decl *D1, Decl *D2) {
+ // Check for equivalent described template.
----------------
CheckCommonEquivalence/CheckKindSpecificEquivalence?
================
Comment at: lib/AST/ASTStructuralEquivalence.cpp:1643
bool Equivalent = true;
----------------
`Equivalent = CommonCheckAtFinish(D1, D2) && SpecialCheckAtFinish(D1, D2))`?
Repository:
rC Clang
https://reviews.llvm.org/D49223
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
