Author: yrnkrn
Date: Thu Aug 13 02:12:03 2015
New Revision: 244871
URL: http://llvm.org/viewvc/llvm-project?rev=244871&view=rev
Log:
Remove superfluous private:, TypeCache is private by default.
Modified:
cfe/trunk/lib/CodeGen/CodeGenTypes.h
Modified: cfe/trunk/lib/CodeGen/CodeGenTypes.h
UR
Hello!
> If the subset of cases where this warning fires on parameters to virtual
> functions produces more noise (if a significant % of cases just result in
> commenting out the parameter name rather than removing the parameter) than
> signal, it's certainly within the realm of discussion tha
klimek added inline comments.
Comment at: ../llvm/tools/clang/lib/Tooling/JSONCompilationDatabase.cpp:295
@@ +294,3 @@
+if (CommandFound) {
+ ErrorMessage = "Multiple command and arguments found";
+ return false;
You're probably right. I
klimek added a comment.
In http://reviews.llvm.org/D11944#222975, @rsmith wrote:
> In principle, normalizing slashes on Windows makes sense here. But we
> shouldn't use `llvm::sys::path::native`, because it's just too broken.
Ok, so if I understand you correctly it would make sense to create a
angelgarcia updated this revision to Diff 32036.
angelgarcia marked 4 inline comments as done.
angelgarcia added a comment.
Set IncludeStyle as an option. Fix comments.
http://reviews.llvm.org/D11946
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/modernize/CMakeLists.txt
Hi Richard,
Thanks for reviewing. Agree, that was a bit confusing. More specifically,
the warning message was confusing (i.e. wrong). This patch is for compiling .c
input in C++ mode. The new flag should be ignored for C++ *input*, and indeed
not when it is in C++ *mode* as the warning message said
yaron.keren added inline comments.
Comment at: lib/Basic/FileManager.cpp:221-222
@@ -220,1 +220,4 @@
+ SmallString<1024> NativeFilename;
+ llvm::sys::path::native(Filename, NativeFilename);
+
rsmith wrote:
> I have two concerns with this:
>
> 1) It's needless
Author: klimek
Date: Thu Aug 13 04:09:28 2015
New Revision: 244876
URL: http://llvm.org/viewvc/llvm-project?rev=244876&view=rev
Log:
Fix formatting.
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h
Modified: clang-tools-extra/trunk/unittests/clang-tidy/ClangTidyTest.h
U
chapuni added a comment.
I wish, in clang/llvm, internal path separator would be slash.
It'd be better to use backslash where it'd be really required, for example
interface to cmd.exe or MS toolchain.
For me, native-ization is nightmare.
http://reviews.llvm.org/D11944
__
On 13 August 2015 at 07:15, Yaron Keren via cfe-commits
wrote:
> CHECK-EIGHT is failing bots, see
>
> http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24306/steps/check-all/logs/FAIL%3A%20Clang%3A%3Adependency-gen.c
That check only works if compiler-rt is built in, and support
andreybokhanko added a comment.
John,
Thank you for the quick reply!
Let me make sure I understand what you said, using my test as an example (BTW,
sorry if this is a dumb question -- I asked our local Clang experts, but no-one
seems to be 100% sure what to do):
1: struct T {
2: ~T() {}
klimek added a comment.
In http://reviews.llvm.org/D11944#223597, @chapuni wrote:
> I wish, in clang/llvm, internal path separator would be slash.
> It'd be better to use backslash where it'd be really required, for example
> interface to cmd.exe or MS toolchain.
>
> For me, native-ization is n
yaron.keren added a comment.
I think she wishes your second option.
Note that windows API actually do accept slash as seperator and need no
conversion.
https://en.wikipedia.org/wiki/Path_(computing)#MS-DOS.2FMicrosoft_Windows_style
The issues are with apps that interpret slash as switch, ma
Author: yrnkrn
Date: Thu Aug 13 07:42:25 2015
New Revision: 244888
URL: http://llvm.org/viewvc/llvm-project?rev=244888&view=rev
Log:
Remove raw_svector_ostream::resync and users. It's no-op after r244870.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetI
On Wed, Aug 12, 2015 at 07:18:05PM -0500, Hal Finkel via cfe-commits wrote:
> I could say the same thing about many optimizations -- I spend a lot
> of time tracking down bugs they expose -- the real thing to investigate
> here are the potential benefits to real code from performing the
> optimizat
Author: djasper
Date: Thu Aug 13 08:37:08 2015
New Revision: 244890
URL: http://llvm.org/viewvc/llvm-project?rev=244890&view=rev
Log:
clang-format: Fix incorrect lambda-detection.
Before:
[ a, a ]() -> a<1>{};
After:
[a, a]() -> a<1> {};
Modified:
cfe/trunk/lib/Format/UnwrappedLineParse
Author: djasper
Date: Thu Aug 13 08:43:51 2015
New Revision: 244891
URL: http://llvm.org/viewvc/llvm-project?rev=244891&view=rev
Log:
clang-format: Inside decltype(), there is an expression.
Before:
decltype(a* b) F();
After:
decltype(a * b) F();
Modified:
cfe/trunk/lib/Format/TokenAnno
Author: emaste
Date: Thu Aug 13 08:45:45 2015
New Revision: 244892
URL: http://llvm.org/viewvc/llvm-project?rev=244892&view=rev
Log:
Correct sense of unwind return address register range assertion
I encountered this on FreeBSD/arm64, and then found the same issue was
reported by Daniil Troshkov.
On Wed, Aug 12, 2015 at 4:03 PM, Dan Albert wrote:
> My testing was varied. I could not get GCC or clang to optimize it away
> for Linux, but both did for ARM Android.
>
Then I don't understand your objection to this change, then.
On your platform, the effect of this change is (therefore) a com
Author: emaste
Date: Thu Aug 13 09:21:03 2015
New Revision: 244893
URL: http://llvm.org/viewvc/llvm-project?rev=244893&view=rev
Log:
Enable zero-cost exceptions on non-Apple arm64 platforms
Use the canonical __aarch64__ predefined macro for 64-bit ARM. Apple-
specific cases are left as __arm64__.
majnemer added a comment.
In http://reviews.llvm.org/D7642#223489, @compnerd wrote:
> Okay, if thats the general pattern, then we can stick it in the triple.
> Though, that means that the use of the triple for determining the MS
> compatibility needs to be undone. If the version in the triple
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thanks for the updates.
Looks good with a couple of nits.
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:83
@@ +82,3 @@
+ public:
+ExactlyOneUsageVisitor
alexfh added inline comments.
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:131
@@ +130,3 @@
+ : ClangTidyCheck(Name, Context) {
+std::string IncludeStyleStr = Options.get("IncludeStyle", "llvm");
+if (IncludeStyleStr == "llvm") {
alexfh wrote:
>
angelgarcia updated this revision to Diff 32055.
angelgarcia marked 3 inline comments as done.
angelgarcia added a comment.
Make IncludeStyle constant, initialize it with StringSwitch. Fix indentation.
http://reviews.llvm.org/D11946
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
cla
alexfh added inline comments.
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:134
@@ +133,3 @@
+: ClangTidyCheck(Name, Context),
+ IncludeStyle(StringSwitch(
+ Options.get("IncludeStyle", "llvm"))
Thinking a bit more of this, w
angelgarcia updated this revision to Diff 32059.
angelgarcia added a comment.
Remove StringSwitch.
http://reviews.llvm.org/D11946
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/Makefile
clang-tidy/modernize/ModernizeTidyMo
alexfh added inline comments.
Comment at: clang-tidy/modernize/PassByValueCheck.cpp:87
@@ +86,3 @@
+/// \brief Whether or not the parameter variable is referred only once in
+/// the
+/// given constructor.
nit: clang-format doesn't properly reflow com
angelgarcia updated this revision to Diff 32061.
angelgarcia added a comment.
Remove StringSwitch.
http://reviews.llvm.org/D11946
Files:
clang-tidy/CMakeLists.txt
clang-tidy/Makefile
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/Makefile
clang-tidy/modernize/ModernizeTidyMo
Author: martell
Date: Thu Aug 13 10:41:04 2015
New Revision: 244902
URL: http://llvm.org/viewvc/llvm-project?rev=244902&view=rev
Log:
Driver: Fix include directories when not using libgcc under mingw
Summary:
When we want to use mingw-w64 and clang with compiler-rt we should not
need to have libg
This revision was automatically updated to reflect the committed changes.
Closed by commit rL244902: Driver: Fix include directories when not using
libgcc under mingw (authored by martell).
Changed prior to commit:
http://reviews.llvm.org/D11808?vs=32007&id=32062#toc
Repository:
rL LLVM
htt
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
I patched this in and the tests fail for me:
clang/tools/extra/test/clang-tidy/modernize-pass-by-value.cpp:4:17: error:
expected string not found in input
// CHECK-FIXES: #includ
//=== TypeChecks.cpp - Insert runtime type checks
-===//
//
// The LLVM Compiler Infrastructure
//
// This file was developed by the LLVM research group and is distributed
under
// the University of Illinois Open Source License. See LICENSE.TXT for
det
Hello ,
i have tried to solve but after removing the lib/PoolAllocate
code doesn't compile with LLVM mainline, and you don't need it for
SAFECode. You can remove PoolAllocate from the list of directories to
compile in poolalloc/lib/Makefile. also am not able to compile this in
Windows i
davidxl added a subscriber: davidxl.
Comment at: include/clang/Driver/Options.td:685
@@ -684,1 +684,3 @@
def fno_lto : Flag<["-"], "fno-lto">, Group;
+def fthinlto : Flag<["-"], "fthinlto">, Flags<[CC1Option]>, Group;
+def fno_thinlto : Flag<["-"], "fno-thinlto">, Group;
Author: benlangmuir
Date: Thu Aug 13 12:13:33 2015
New Revision: 244912
URL: http://llvm.org/viewvc/llvm-project?rev=244912&view=rev
Log:
[Modules] Add Darwin-specific compatibility module map parsing hacks
This preserves backwards compatibility for two hacks in the Darwin
system module map files
benlangmuir closed this revision.
benlangmuir added a comment.
Any regression to code completion was below the noise level in my testing.
r244912
Comment at: include/clang/Basic/Module.h:363
@@ +362,3 @@
+ /// This is more efficient than getFullModuleName().
+ bool fullModule
tejohnson added inline comments.
Comment at: include/clang/Driver/Options.td:685
@@ -684,1 +684,3 @@
def fno_lto : Flag<["-"], "fno-lto">, Group;
+def fthinlto : Flag<["-"], "fthinlto">, Flags<[CC1Option]>, Group;
+def fno_thinlto : Flag<["-"], "fno-thinlto">, Group;
Author: benlangmuir
Date: Thu Aug 13 12:30:07 2015
New Revision: 244917
URL: http://llvm.org/viewvc/llvm-project?rev=244917&view=rev
Log:
Attempt to fix build after r244912
Some compilers were less happy about converting a lambda to a comparator
function for array_pod_sort.
Modified:
cfe/tru
rsmith added a comment.
I would think most Windows users would be surprised if we showed them paths
with /s instead of \s, but I'm fine with us using / internally if it doesn't
leak out to the user.
klimek: if we want to nativize, I think the right thing to do is to remove the
wrong "normaliza
angelgarcia created this revision.
angelgarcia added a reviewer: alexfh.
angelgarcia added subscribers: cfe-commits, klimek.
angelgarcia changed the visibility of this Differential Revision from "Public
(No Login Required)" to "All Users".
If there weren't any includes in the file, or all of them
Thank you, Yaron.
Sorry for breaking the build, it obviously passed locally and I didn't
think about all the variety of the supported configs. :(
Does LLVM have try bots, so that I can run the tests with my patch before
committing it?
krasin
On Thu, Aug 13, 2015 at 3:40 AM, Renato Golin
wrote:
diltsman updated this revision to Diff 32082.
diltsman marked an inline comment as done.
diltsman added a comment.
Arguments and Command can now be in the same compilation database for the same
file. Arguments are preferred when both are present.
http://reviews.llvm.org/D10365
Files:
../llv
Author: rsmith
Date: Thu Aug 13 12:57:10 2015
New Revision: 244923
URL: http://llvm.org/viewvc/llvm-project?rev=244923&view=rev
Log:
[modules] Change the way we deal with .d output for explicitly-specified module
files: include the .pcm file itself in the .d output, rather than including its
own i
Author: rnk
Date: Thu Aug 13 12:56:49 2015
New Revision: 244922
URL: http://llvm.org/viewvc/llvm-project?rev=244922&view=rev
Log:
Turn off __has_feature(cxx_rtti) when -fno-rtti-data is present
-fno-rtti-data makes it so that vtables emitted in the current TU lack
RTTI data. This means that dynam
There is great variety of OSs, compilers, configs in the bots. You can't
get the smae with try bots unless everything is duplicated which is a
waste. You test locally, commit, watch the bots here:
http://lab.llvm.org:8011/grid
or wait for buildbot failure e-mails which arrive a bit slower.
Break
Author: rnk
Date: Thu Aug 13 13:10:34 2015
New Revision: 244926
URL: http://llvm.org/viewvc/llvm-project?rev=244926&view=rev
Log:
Try to fix the build after r244923
Modified:
cfe/trunk/lib/Frontend/DependencyFile.cpp
Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp
URL:
http://llvm.org/v
Author: rnk
Date: Thu Aug 13 13:10:32 2015
New Revision: 244925
URL: http://llvm.org/viewvc/llvm-project?rev=244925&view=rev
Log:
Try to fix new.cpp after r244920 to make it pass
Modified:
cfe/trunk/test/CodeGenCXX/new.cpp
Modified: cfe/trunk/test/CodeGenCXX/new.cpp
URL:
http://llvm.org/vie
rsmith added inline comments.
Comment at: lib/CodeGen/CGCXXABI.h:349-357
@@ -348,1 +348,11 @@
+ virtual bool
+ isVirtualOffsetNeededForVTableField(CodeGenFunction &CGF,
+ const CXXRecordDecl *NearestVBase) = 0;
+
+ virtual bool canInitiali
Author: rsmith
Date: Thu Aug 13 13:11:20 2015
New Revision: 244927
URL: http://llvm.org/viewvc/llvm-project?rev=244927&view=rev
Log:
Fix wrong expected test output in r244923.
Modified:
cfe/trunk/test/Modules/dependency-gen.modulemap
Modified: cfe/trunk/test/Modules/dependency-gen.modulemap
Author: yrnkrn
Date: Thu Aug 13 13:12:56 2015
New Revision: 244928
URL: http://llvm.org/viewvc/llvm-project?rev=244928&view=rev
Log:
Remove and forbid raw_svector_ostream::flush() calls.
After r244870 flush() will only compare two null pointers and return,
doing nothing but wasting run time. The c
On Thu, Aug 13, 2015 at 11:10 AM, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Thu Aug 13 13:10:34 2015
> New Revision: 244926
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244926&view=rev
> Log:
> Try to fix the build after r244923
>
Thanks! I thoug
On Thu, Aug 13, 2015 at 1:52 AM, Sjoerd Meijer
wrote:
> Hi Richard,
>
> Thanks for reviewing. Agree, that was a bit confusing. More specifically,
>
> the warning message was confusing (i.e. wrong). This patch is for
> compiling .c
>
> input in C++ mode. The new flag should be ignored for C++ **in
Author: rsmith
Date: Thu Aug 13 13:30:25 2015
New Revision: 244931
URL: http://llvm.org/viewvc/llvm-project?rev=244931&view=rev
Log:
[modules] For explicit module file dependencies, only list direct dependency
module files.
Modified:
cfe/trunk/lib/Frontend/CompilerInvocation.cpp
cfe/trun
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
LG with a happy path test.
Comment at: ../llvm/tools/clang/unittests/Tooling/CompilationDatabaseTest.cpp:45
@@ -41,1 +44,3 @@
+ expectFailure
Author: nmusgrave
Date: Thu Aug 13 13:35:11 2015
New Revision: 244933
URL: http://llvm.org/viewvc/llvm-project?rev=244933&view=rev
Log:
Fix previous commit: poison only class members, simpler tests
Summary: Poisoning applied to only class members, and before dtors for base
class invoked
Impleme
klimek added a comment.
Please add a regression test.
http://reviews.llvm.org/D12017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
diltsman added a comment.
Where/how does documentation
(http://clang.llvm.org/docs/JSONCompilationDatabase.html) get updated?
http://reviews.llvm.org/D10365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
sepavloff updated this revision to Diff 32085.
sepavloff added a comment.
Updated patch
Thanks to all for fruitful discussion!
The new version tries to addresses review notes. It differs from the previous
version in:
- Method tryParseMisplacedModuleImport now depends only on current token and
Thank you, Yaron. Understood.
On Thu, Aug 13, 2015 at 11:04 AM, Yaron Keren wrote:
> There is great variety of OSs, compilers, configs in the bots. You can't
> get the smae with try bots unless everything is duplicated which is a
> waste. You test locally, commit, watch the bots here:
>
> http:
Because we consider the fact that clang and gcc do this when those
functions are not marked with nonnull by the libc to be a bug. Adding it to
libc++ would just make another place that we have to fix that bug.
What is the objection to using _Nullable instead of __attribute__(nonnull)?
The original
Please make such programs crash early and often. They are a nightmare to
maintain. Make them blow in the face of the original authors; not after
they are gone.
-- Gaby
On Thu, Aug 13, 2015 at 11:18 AM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Aug 13, 2015 at
I don't see anywhere in the C standard that says that a memcpy() with NULL
for either pointer is UB (which would only be valid for the case where n ==
0). This seems like a particularly aggressive (mis)optimization in the
general case. It should only be acceptable if the length is guaranteed to
be
On Thu, Aug 13, 2015 at 4:53 PM, Stephen Hines via cfe-commits
wrote:
> I don't see anywhere in the C standard that says that a memcpy() with NULL
> for either pointer is UB (which would only be valid for the case where n ==
> 0). This seems like a particularly aggressive (mis)optimization in the
David Majnemer writes:
> majnemer created this revision.
> majnemer added a reviewer: rsmith.
> majnemer added a subscriber: cfe-commits.
>
> We risk iterator invalidation issues if we use DenseMap structures for
> MaterializedTemporaryExprs. Use a std::map to ensure that they don't
> move around
Author: dblaikie
Date: Thu Aug 13 16:15:23 2015
New Revision: 244956
URL: http://llvm.org/viewvc/llvm-project?rev=244956&view=rev
Log:
Wdeprecated: Replace deprecated throw() with LLVM_NOEXCEPT which expands to
'noexcept' where available (and throw() otherwise)
Modified:
cfe/trunk/include/cl
chandlerc added a comment.
I agree with both Marshall and Hal.
However, I'm also not opposed to platforms opting out if this if they want to.
If a particular platform wants to define the behavior of null pointers passed
to these functions, that seems like a reasonable thing to support here. The
Author: dblaikie
Date: Thu Aug 13 16:23:08 2015
New Revision: 244957
URL: http://llvm.org/viewvc/llvm-project?rev=244957&view=rev
Log:
Wdeprecated: LambdaScopeInfos are copied in TreeTransform, so make sure they're
copyable.
Partly addressed by r244843, but the explicit dtor in LambdaScopeInfo
w
Author: dblaikie
Date: Thu Aug 13 16:24:08 2015
New Revision: 244958
URL: http://llvm.org/viewvc/llvm-project?rev=244958&view=rev
Log:
Wdeprecated: CommentVerifiers are returned by value, make sure they're
correctly copy/moveable
Modified:
cfe/trunk/unittests/Tooling/CommentHandlerTest.cpp
Author: echristo
Date: Thu Aug 13 16:34:35 2015
New Revision: 244959
URL: http://llvm.org/viewvc/llvm-project?rev=244959&view=rev
Log:
Fix some coding standard issues and delete a dead conditional.
Modified:
cfe/trunk/lib/Sema/SemaDeclAttr.cpp
Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp
UR
Author: brad
Date: Thu Aug 13 16:45:57 2015
New Revision: 244961
URL: http://llvm.org/viewvc/llvm-project?rev=244961&view=rev
Log:
[SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/Preprocessor/init.c
Modified: cfe/t
On Thu, Aug 13, 2015 at 2:45 PM, Brad Smith via cfe-commits
wrote:
> Author: brad
> Date: Thu Aug 13 16:45:57 2015
> New Revision: 244961
>
> URL: http://llvm.org/viewvc/llvm-project?rev=244961&view=rev
> Log:
> [SPARC] Fix types of size_t, intptr_t, and ptrdiff_t on OpenBSD.
>
> Modified:
> c
Author: brad
Date: Thu Aug 13 17:00:53 2015
New Revision: 244962
URL: http://llvm.org/viewvc/llvm-project?rev=244962&view=rev
Log:
Removed one too many braces.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
On Thu, Aug 13, 2015 at 5:15 PM, Justin Bogner
wrote:
> David Majnemer writes:
> > majnemer created this revision.
> > majnemer added a reviewer: rsmith.
> > majnemer added a subscriber: cfe-commits.
> >
> > We risk iterator invalidation issues if we use DenseMap structures for
> > MaterializedT
rsmith added inline comments.
Comment at: include/clang/AST/ASTContext.h:180
@@ -179,3 +179,3 @@
/// that appear in constant initializers to their evaluated values.
- llvm::DenseMap
+ std::map
MaterializedTemporaryValues;
I would prefer a `DenseMap`, wit
Author: dblaikie
Date: Thu Aug 13 17:12:21 2015
New Revision: 244968
URL: http://llvm.org/viewvc/llvm-project?rev=244968&view=rev
Log:
Wdeprecated: Make BumpVectorContext movable
Turns out the one place that relied on the implicit copy ctor was safe
because it created an object in a state where t
Author: chapuni
Date: Thu Aug 13 17:17:34 2015
New Revision: 244970
URL: http://llvm.org/viewvc/llvm-project?rev=244970&view=rev
Log:
clang/test/Frontend/dependency-gen.c: Add explicit -target x86_64-linux-gnu for
-fsanitize.
Modified:
cfe/trunk/test/Frontend/dependency-gen.c
Modified: cfe/
Author: dblaikie
Date: Thu Aug 13 17:20:14 2015
New Revision: 244971
URL: http://llvm.org/viewvc/llvm-project?rev=244971&view=rev
Log:
Wdeprecated: StoredDiagnostics are stored in a SmallVector, so make sure
they're copy/movable
Removing the no-op dtor makes these objects safely implicitly
copya
Author: dblaikie
Date: Thu Aug 13 17:23:53 2015
New Revision: 244973
URL: http://llvm.org/viewvc/llvm-project?rev=244973&view=rev
Log:
Wdeprecated: PathPieces are copied, make them safely implicitly copyable by
removing the unnecessary user declared dtor.
Modified:
cfe/trunk/include/clang/St
diltsman updated this revision to Diff 32099.
diltsman marked an inline comment as done.
diltsman added a comment.
Added test for command and arguments in same object.
Fixed bug where parse failed if command and argument resolved to empty lists.
http://reviews.llvm.org/D10365
Files:
../llvm/t
Author: dblaikie
Date: Thu Aug 13 17:33:24 2015
New Revision: 244974
URL: http://llvm.org/viewvc/llvm-project?rev=244974&view=rev
Log:
Wdeprecated: RegionBindingsRef are copy constructed, make sure that's safe by
removing the unnecessary user-declared copy assignment operator
The user-defined co
majnemer updated this revision to Diff 32100.
majnemer added a comment.
- Address Justin's review comments.
- Address Richard's review comments.
http://reviews.llvm.org/D11629
Files:
include/clang/AST/ASTContext.h
lib/AST/ASTContext.cpp
lib/CodeGen/CodeGenModule.h
test/CodeGenCXX/PR2428
Author: dblaikie
Date: Thu Aug 13 17:50:09 2015
New Revision: 244975
URL: http://llvm.org/viewvc/llvm-project?rev=244975&view=rev
Log:
Wdeprecated: CollectReachableSymbolsCallback are move constructed/returned by
value, so make sure they're copy/moveable
(return by value is in ExprEngine::proces
kulpreet updated this revision to Diff 32102.
kulpreet added a comment.
Fixed memory corruption bug with temporary std::string - found with address
sanitizer.
Now, all regression tests pass with MallocScribble on.
http://reviews.llvm.org/D11572
Files:
lib/StaticAnalyzer/Checkers/CMakeLists.
rsmith added inline comments.
Comment at: lib/AST/ASTContext.cpp:8557
@@ +8556,3 @@
+ if (MayCreate) {
+auto *MTVI = &MaterializedTemporaryValues[E];
+if (*MTVI == nullptr) {
Maybe use a reference here rather than a pointer.
Comment at:
Author: dblaikie
Date: Thu Aug 13 17:58:37 2015
New Revision: 244979
URL: http://llvm.org/viewvc/llvm-project?rev=244979&view=rev
Log:
Wdeprecated: BugReporterVisitors are copied for cloning
(BugReporterVisitorImpl), make sure such copies are safe
Make the copy/move ctors defaulted in the base c
Author: dblaikie
Date: Thu Aug 13 17:58:35 2015
New Revision: 244978
URL: http://llvm.org/viewvc/llvm-project?rev=244978&view=rev
Log:
Follow up r244975: The ctors of an abstract class don't need to be protected -
the object isn't directly constructible/doesn't present a slicing risk
Modified:
Author: dblaikie
Date: Thu Aug 13 18:05:58 2015
New Revision: 244980
URL: http://llvm.org/viewvc/llvm-project?rev=244980&view=rev
Log:
Fix the MSVC build which cannot manifest default move ops
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitor.h
Modified:
c
Tweaked a test in r244970.
Could you split it out if you would like to run it for the default target?
On Fri, Aug 14, 2015 at 5:07 AM Ivan Krasin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Thank you, Yaron. Understood.
>
> On Thu, Aug 13, 2015 at 11:04 AM, Yaron Keren
> wrote:
>
>> Th
Author: dblaikie
Date: Thu Aug 13 18:09:18 2015
New Revision: 244981
URL: http://llvm.org/viewvc/llvm-project?rev=244981&view=rev
Log:
Wdeprecated: Make the SecKeychainBugVisitor copyable (for the clone support in
the CRTP base) my removing the user-declared dtor
The implicit dtor is just as goo
Hi there,
I will remove both test cases, which rely on the existence of the default
blacklist. It's handled by the driver anyway, and the code I changed is in
the frontend; at this point, there's no such a thing, as a default
blacklist, all of them are explicit.
Just a sec.
krasin
On Thu, Aug 13
Author: dblaikie
Date: Thu Aug 13 18:15:20 2015
New Revision: 244983
URL: http://llvm.org/viewvc/llvm-project?rev=244983&view=rev
Log:
Wdeprecated: Make Filter safely move constructible.
makeFilter returns Filters by value which seems to be only safe when the
copy doesn't occur and RVO kicks in.
majnemer updated this revision to Diff 32106.
majnemer added a comment.
- Address Richard's latest review comments.
http://reviews.llvm.org/D11629
Files:
include/clang/AST/ASTContext.h
lib/AST/ASTContext.cpp
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/PR24289.cpp
Index: test/CodeGenC
krasin created this revision.
krasin added a reviewer: chapuni.
krasin added subscribers: pcc, cfe-commits.
http://reviews.llvm.org/D12021
Files:
test/Frontend/dependency-gen.c
Index: test/Frontend/dependency-gen.c
===
--- test/Fr
I have created http://reviews.llvm.org/D12021, please take a look.
On Thu, Aug 13, 2015 at 4:13 PM, Ivan Krasin wrote:
> Hi there,
>
> I will remove both test cases, which rely on the existence of the default
> blacklist. It's handled by the driver anyway, and the code I changed is in
> the fron
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D11629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
pcc added a comment.
You could create a fake resource directory which contains only the
`asan_blacklist.txt` file. See `test/Driver/Inputs/resource_dir` for an example
of this kind of thing.
http://reviews.llvm.org/D12021
___
cfe-commits mailing l
krasin added a comment.
In http://reviews.llvm.org/D12021#224102, @pcc wrote:
> You could create a fake resource directory which contains only the
> `asan_blacklist.txt` file. See `test/Driver/Inputs/resource_dir` for an
> example of this kind of thing.
I believe it's unnecessary. The default
pcc accepted this revision.
pcc added a reviewer: pcc.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Yes, this can be a separate driver test.
http://reviews.llvm.org/D12021
___
cfe-commits mailing list
cfe-commits@lists
Author: krasin
Date: Thu Aug 13 18:37:28 2015
New Revision: 244985
URL: http://llvm.org/viewvc/llvm-project?rev=244985&view=rev
Log:
Remove test cases, which rely on the default sanitizer blacklists.
Summary:
The default blacklists may vary across different architectures and
configurations. It wa
Author: dblaikie
Date: Thu Aug 13 18:38:46 2015
New Revision: 244986
URL: http://llvm.org/viewvc/llvm-project?rev=244986&view=rev
Log:
Wdeprecated: Ensure CheckNames are copy assignable (used in
setCurrentCheckName) by removing the unnecessary copy ctor
Modified:
cfe/trunk/include/clang/Stat
1 - 100 of 141 matches
Mail list logo
