klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. This revision is now accepted and ready to land.
LG with a happy path test. ================ Comment at: ../llvm/tools/clang/unittests/Tooling/CompilationDatabaseTest.cpp:45 @@ -41,1 +44,3 @@ + expectFailure("[{\"directory\":\"\",\"arguments\":\"\",\"file\":\"\"}]", "Arguments not array"); + expectFailure("[{\"directory\":\"\",\"command\":[],\"file\":\"\"}]", "Command not string"); } ---------------- Please add a happy path test, too. http://reviews.llvm.org/D10365 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits