Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL277729: [clang-tidy] misc-argument-comment non-strict mode (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D23135?vs=66806&id=66807#toc Repository: rL LLVM https://reviews.ll

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

alexfh added a comment. hokein: I'm committing the patch; if you have more comments, I'm happy to address them in a follow-up. https://reviews.llvm.org/D23135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

On Thu, Aug 4, 2016 at 10:45 AM, Alexander Kornienko wrote: > alexfh added inline comments. > > > Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124 > @@ +123,3 @@ > + InDecl = InDecl.trim('_'); > + return InComment.compare_lower(InDecl) == 0; > +} > > aar

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

alexfh added inline comments. Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124 @@ +123,3 @@ + InDecl = InDecl.trim('_'); + return InComment.compare_lower(InDecl) == 0; +} aaron.ballman wrote: > alexfh wrote: > > aaron.ballman wrote: > > > Correct, which

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D23135 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

alexfh updated this revision to Diff 66806. alexfh added a comment. - Added a FIXME. https://reviews.llvm.org/D23135 Files: clang-tidy/ClangTidy.h clang-tidy/misc/ArgumentCommentCheck.cpp clang-tidy/misc/ArgumentCommentCheck.h docs/clang-tidy/checks/misc-argument-comment.rst test/clan

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

aaron.ballman added inline comments. Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124 @@ +123,3 @@ + InDecl = InDecl.trim('_'); + return InComment.compare_lower(InDecl) == 0; +} alexfh wrote: > aaron.ballman wrote: > > Correct, which means this won't beh

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

alexfh added inline comments. Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124 @@ +123,3 @@ + InDecl = InDecl.trim('_'); + return InComment.compare_lower(InDecl) == 0; +} aaron.ballman wrote: > Correct, which means this won't behave properly in some loca

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

aaron.ballman added inline comments. Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124 @@ +123,3 @@ + InDecl = InDecl.trim('_'); + return InComment.compare_lower(InDecl) == 0; +} Correct, which means this won't behave properly in some locales with UTF-8

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

alexfh updated this revision to Diff 66796. alexfh marked 2 inline comments as done. alexfh added a comment. - Documented the StrictMode option, added a couple of consts. https://reviews.llvm.org/D23135 Files: clang-tidy/ClangTidy.h clang-tidy/misc/ArgumentCommentCheck.cpp clang-tidy/misc

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

alexfh marked an inline comment as done. Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124 @@ +123,3 @@ + InDecl = InDecl.trim('_'); + return InComment.compare_lower(InDecl) == 0; +} aaron.ballman wrote: > I think this is going to do the wrong thing for n

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

aaron.ballman added a subscriber: aaron.ballman. Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124 @@ +123,3 @@ + InDecl = InDecl.trim('_'); + return InComment.compare_lower(InDecl) == 0; +} I think this is going to do the wrong thing for non-ASCII identi

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

hokein added inline comments. Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:29 @@ +28,3 @@ +void ArgumentCommentCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) { + Options.store(Opts, "StrictMode", StrictMode); +} I think we should add a `StringMode

Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

Prazek added a subscriber: Prazek. Prazek added a comment. LG(TM) https://reviews.llvm.org/D23135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

alexfh created this revision. alexfh added a reviewer: hokein. alexfh added a subscriber: cfe-commits. The misc-argument-comment check now ignores leading and trailing underscores and case. The new `StrictMode` local/global option can be used to switch back to strict checking. Add getLocalOrGloba