Re: [PATCH] D23135: [clang-tidy] misc-argument-comment non-strict mode

[Haojian Wu via cfe-commits]

hokein added inline comments.

================
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:29
@@ +28,3 @@
+void ArgumentCommentCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
+  Options.store(Opts, "StrictMode", StrictMode);
+}
----------------
I think we should add a `StringMode` description in `ArgumentCommentCheck`'s 
document. 

================
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:180
@@ -165,3 +179,3 @@
   const Expr *E = Result.Nodes.getNodeAs<Expr>("expr");
-  if (auto Call = dyn_cast<CallExpr>(E)) {
+  if (auto *Call = dyn_cast<CallExpr>(E)) {
     const FunctionDecl *Callee = Call->getDirectCallee();
----------------
`const auto *`

================
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:188
@@ -173,3 +187,3 @@
   } else {
-    auto Construct = cast<CXXConstructExpr>(E);
+    auto *Construct = cast<CXXConstructExpr>(E);
     checkCallArgs(
----------------
`const auto *`


https://reviews.llvm.org/D23135



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits