aaron.ballman added a subscriber: aaron.ballman.
================
Comment at: clang-tidy/misc/ArgumentCommentCheck.cpp:124
@@ +123,3 @@
+ InDecl = InDecl.trim('_');
+ return InComment.compare_lower(InDecl) == 0;
+}
----------------
I think this is going to do the wrong thing for non-ASCII identifiers
containing characters for which lowercase comparisons make no sense. I'm okay
with that behavior (I don't think it should be a common occurrence), but would
like to see a test demonstrating a failure case with a FIXME.
https://reviews.llvm.org/D23135
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
