[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424105. python3kgae added a comment. Committed. Updated line number check for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/B

[PATCH] D123907: [HLSL] Add shader attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb02d88d5afb5: [HLSL] Add shader attribute (authored by python3kgae). Changed prior to commit: https://reviews.llvm.org/D123907?vs=424093&id=424104

[PATCH] D123907: [HLSL] Add shader attribute

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6391 +where the string literal is one of: "pixel", "vertex", "geometry", "hull", + "domain", "compute", "raygeneration", "intersection", "anyhit", "closesthit", + "mis

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424093. python3kgae added a comment. Add comment for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td clang/incl

[PATCH] D123907: [HLSL] Add shader attribute

MaskRay added inline comments. Comment at: clang/test/SemaHLSL/shader_type_attr.hlsl:1 +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -ast-dump -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -ast-dump -o - %s -DFAIL

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 424019. python3kgae added a comment. Fix doc again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td clang/include/cla

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6390 + ``[shader(string-literal)]`` +where the string literal is one of: . +Normally the shader type is set by shader target with the ``-T`` option like bogner wrote: > I'm gues

[PATCH] D123907: [HLSL] Add shader attribute

bogner added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6390 + ``[shader(string-literal)]`` +where the string literal is one of: . +Normally the shader type is set by shader target with the ``-T`` option like I'm guessing you meant to act

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added a comment. Thanks for the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D123907: [HLSL] Add shader attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:6389-6391 +Normally the shader type is set by shader target with the -T option like +-Tps_6_1. +When compiling to a library target like lib_6_3, the shader type attribute can aar

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 423448. python3kgae added a comment. Fix doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Bas

[PATCH] D123907: [HLSL] Add shader attribute

aaron.ballman added a comment. Mostly looks good, just some nits with the documentation. Comment at: clang/include/clang/Basic/AttrDocs.td:6388 +identify the shader type for the entry function. +The format is [shader("shadertype")]. +Normally the shader type is set by shader ta

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae updated this revision to Diff 423428. python3kgae added a comment. Add more detail to the doc. Update the attribute name according to the doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 F

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3978 +"compute", "raygeneration", "intersection", +"anyhit", "closestHit", "miss", "callable", "mesh", +"amplificat

[PATCH] D123907: [HLSL] Add shader attribute

aaron.ballman added a reviewer: beanz. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3978 +"compute", "raygeneration", "intersection", +"anyhit", "closestHit", "miss", "callable", "mesh",

[PATCH] D123907: [HLSL] Add shader attribute

python3kgae created this revision. python3kgae added reviewers: aaron.ballman, rnk, jdoerfert, MaskRay, rsmith. Herald added a subscriber: StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.