MaskRay accepted this revision. MaskRay added inline comments.
================ Comment at: clang/include/clang/Basic/AttrDocs.td:6391 +where the string literal is one of: "pixel", "vertex", "geometry", "hull", + "domain", "compute", "raygeneration", "intersection", "anyhit", "closesthit", + "miss", "callable", "mesh", "amplification". ---------------- The one-space indentation seems unneeded ================ Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6956 + + // FIXME: check function match the shader stage. + ---------------- Not performing a check is at most a TODO, not a FIXME, unless it may crash in a later pass without the check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123907/new/ https://reviews.llvm.org/D123907 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
