[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

Maetveis accepted this revision. Maetveis added a comment. This revision is now accepted and ready to land. I don't see anything in here that would block later extension for supporting offloading, so LGTM from my POV. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D150282: [Driver] -ftime-trace: derive trace file names from -o and -dumpdir

Maetveis added a comment. LGTM, but I don't feel like I have the experience to "formally" approve. I left a nice-to have suggestion too, but feel free to ignore, if you feel its out of scope. Comment at: clang/lib/Driver/Driver.cpp:5514 BaseInput); +

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Maetveis added a comment. In D131469#3808758 , @dongjunduo wrote: > I'm sorry that I didn't see the comments until now because of some personal > work... Thank you for your kindness and suppot, I will improve this part of > work according to your idea

[PATCH] D131469: [Clang] change default storing path of `-ftime-trace`

Maetveis requested changes to this revision. Maetveis added a comment. As discussed with @jamieschmeiser on D133662 , I have left suggestions regarding the approach I took for handling `-o` and passing the option to the jobs. I'm really happy to see this area g

[PATCH] D133662: [Clang] Change -ftime-trace storing path and support multiple compilation jobs

Maetveis added a comment. In D133662#3798276 , @jamieschmeiser wrote: > I had an email exchange with @dongjunduo about this situation. He was a GSoC > student that @Whitney and I were mentoring for the past summer. He agrees > that your approach is c

[PATCH] D133662: [Clang] Change -ftime-trace storing path and support multiple compilation jobs

Maetveis updated this revision to Diff 460507. Maetveis retitled this revision from "[Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs" to "[Clang] Change -ftime-trace storing path and support multiple compilation jobs". Maetveis added a comment. Remove inline e

[PATCH] D133662: [Clang] WIP: Change -ftime-trace storing path and support multiple compilation jobs

Maetveis added a comment. In D133662#3787250 , @jamieschmeiser wrote: > I'm a little confused as to what is being proposed here. Is this building on > D131469 or is it an alternative? It seems > that there are porti

[PATCH] D133662: [Clang] Change -ftime-trace storing path and support multiple compilation jobs

Maetveis created this revision. Maetveis added a reviewer: clang. Herald added a project: All. Maetveis requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This is an alternative approach for [D131469

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis added a comment. Sorry, I somehow missed the big obvious checkbox to mark the comments, fixed now. I don't have commit access could you commit if the last change seems okay to you? Name: Gergely Meszaros Email: meszaros.gergel...@gmail.com Repository: rG LLVM Github Monorepo CHANG

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis updated this revision to Diff 451584. Maetveis marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130108/new/ https://reviews.llvm.org/D130108 Files: clang/tools/clang-format/git-clang-format Index: clang/too

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis updated this revision to Diff 451257. Maetveis added a comment. Address formatting and stylistic comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130108/new/ https://reviews.llvm.org/D130108 Files: clang/tools/clang-format/git-cl

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis added a comment. In D130108#3706550 , @MyDeveloperDay wrote: > So trying to understand the problem statement, is it: > > 1. you have some files staged > 2. and then you have to change them locally (review comment) > 3. but forget to git add them

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis added a comment. Friendly Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130108/new/ https://reviews.llvm.org/D130108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis updated this revision to Diff 448563. Maetveis added a comment. Updated to add missing comma after 'git ls-tree'. It broke normal (non staged) operation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130108/new/ https://reviews.llvm.org/D130108 Files: clang/tools/clang-form

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis added a comment. In D130108#3685620 , @owenpan wrote: > Can you open an issue at https://github.com/llvm/llvm-project/issues? See > https://github.com/llvm/llvm-project/issues/56736 for an example. Of course, here it is: https://github.com/llvm

[PATCH] D130108: git-clang-format: format index not worktree when using --staged

Maetveis created this revision. Maetveis added a project: clang-format. Herald added a subscriber: arphaman. Herald added a project: All. Maetveis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When --staged (or --cached) use the index for