Maetveis added a comment.
LGTM, but I don't feel like I have the experience to "formally" approve. I left
a nice-to have suggestion too, but feel free to ignore, if you feel its out of
scope.
================
Comment at: clang/lib/Driver/Driver.cpp:5514
BaseInput);
+ handleTimeTrace(C, Args, JA, BaseInput, Result);
}
----------------
One thing D133662 had that this change doesn't is that `--ftime-trace` was
reported as unused when there was no job that invoked clang (e.g. if using the
driver to link object files only).
I am not sure its worth the effort, but it would be nice. IIRC in D133662 I did
this by having a method (`supportsTimeTrace`) on Tools to query support.
I can also do this if you feel its out of scope here, and if there's no
objection to it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150282/new/
https://reviews.llvm.org/D150282
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
