Maetveis added a comment. In D133662#3798276 <https://reviews.llvm.org/D133662#3798276>, @jamieschmeiser wrote:
> I had an email exchange with @dongjunduo about this situation. He was a GSoC > student that @Whitney and I were mentoring for the past summer. He agrees > that your approach is cleaner. There appears to be two parts to your work. > First, you implemented the determining and passing of the options > differently, and secondly, you improved the handling of off-loading and > system specific file handling. Based on your earlier response, we proposed > to him the following and he agrees that it seems appropriate. Could you > please add comments to https://reviews.llvm.org/D131469 and he will work with > you to change his code to reflect searching for -o and using the virtual > functions. Then, if @MaskRay agrees, he can land his code and finish up his > GSoC work. You can then add your extensions of off-loading and > file-handling. Is this acceptable to you? Yes, I can gladly do that. I'm sorry for the confusion this must have caused for you and @dongjunduo, my intention was not judgment on the code he posted, rather seeing his code motivated me to post my own changes, that I've been working on beforehand., Some of his code gave me the right ideas, so I'm happy to share the credit for it. Let's make this contribution better together! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133662/new/ https://reviews.llvm.org/D133662 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
