[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 527591. fahadnayyar added a comment. Edits in comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/te

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar marked 2 inline comments as done. fahadnayyar added inline comments. Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:119 // RUN: -nostdinc++ \ -// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr \ +// RUN: | FileCheck -DSYSROOT=%S/Inpu

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 527512. fahadnayyar added a comment. Simplifying the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files: clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

fahadnayyar accepted this revision. fahadnayyar added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 _

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 527407. fahadnayyar added a comment. Rebasing to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files: clang/lib/Driver/ToolChains/Darwin.cpp cl

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 527241. fahadnayyar added a comment. Passing -L /bin/../lib/ unconditionally to the linker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files: clang/lib/Dri

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

fahadnayyar updated this revision to Diff 526596. fahadnayyar added a comment. Rebasing to main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

fahadnayyar updated this revision to Diff 525791. fahadnayyar added a comment. Adding 1 more test chage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files: clang/include/clang/Basic/DiagnosticDriver

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 514699. fahadnayyar added a comment. Fixing some more regression test errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files: clang-tools-extra/test/cla

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 514397. fahadnayyar added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: clang-tools-extra. Fixed regression error in clang-tidy test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:432 if (sysroot != "") { CmdArgs.push_back("-syslibroot"); CmdArgs.push_back(C.getArgs().MakeArgString(sysroot)); ldionne wrote: > ldionne wrote: > > Where do we se

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 514037. fahadnayyar added a comment. Herald added a subscriber: ormris. Added test case. Now checking the existence of libc++ headers in the toolchain when including the libc++.dylib form toolchain and vice versa. Also checking the absence of -nostdinc,

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar created this revision. Herald added a project: All. fahadnayyar requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When libc++ is bootstrapped with clang using the cmake options -DLLVM_ENABLE_PROJECTS="clang;llvm;lldb" and

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e5d901feb3c: [Clang] [Sema] Removed a fix-it for system headers (authored by fahadnayyar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

fahadnayyar marked 3 inline comments as done. fahadnayyar added a comment. In D141868#4060757 , @NoQ wrote: > Looks great! Sounds like you're looking for a more permanent fix, I guess > `ConversionFixItGenerator` could try to avoid adding fixits to syste

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

fahadnayyar updated this revision to Diff 490618. fahadnayyar added a comment. Added release notes and changed a normal for-loop to range-based for-loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141868/new/ https://reviews.llvm.org/D141868 Fi

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar added a comment. @aaron.ballman do you think that we should call ```CheckImplicitConversion``` only for arithemetic compound assignment operators like +=, -=, /=, *= and %= ? For bitwiseAssign operators (|=, &=, ^=) and shiftAssign operators (<<= and >>=) we may have to check the s

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

fahadnayyar created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fahadnayyar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Disabled an invalid fix-it which suggested fixes to be applied in system heade

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c37671a7c94: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment… (authored by fahadnayyar). Repository: rG LLVM Github Mono

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 488632. fahadnayyar marked an inline comment as done. fahadnayyar added a comment. Refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114 Files: clang/doc

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar added a comment. Moved the libunwind change to this separate patch: https://reviews.llvm.org/D141515 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114 __

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 488246. fahadnayyar added a comment. Moving the libunwind change to a separate patch and some refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114 Files:

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 487955. fahadnayyar retitled this revision from "[Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator. " to "[Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.". fahadnayyar added a comment.

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13402 + // intergral operands. + if (E->getLHS()->getType()->isIntegerType() && + E->getRHS()->getType()->isIntegerType() && !E->isShiftAssignOp()) arichardson wrote: > Why is t

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 486930. fahadnayyar marked an inline comment as done. fahadnayyar added a comment. Added summary in clang release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D1

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar marked 2 inline comments as done. fahadnayyar added a comment. In D139114#4023456 , @aaron.ballman wrote: > It looks like this change breaks libc++ (see the precommit CI failures) by > making more changes than expected. I'm now seeing `impli

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 486897. fahadnayyar marked an inline comment as done. fahadnayyar added a comment. Herald added a project: libunwind. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libunwind. Fixed libcxx failure and added test case for expected warni

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar marked an inline comment as done. fahadnayyar added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:14115 +/// Analyze the given compound assignment for the possible losing of +/// floating-point precision. aaron.ballman wrote: > Moving

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 482102. fahadnayyar added a comment. Added forward declare for CheckImplicitConversion to make the diff look clean. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139114/new/ https://reviews.llvm.org/D139114

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 479626. fahadnayyar retitled this revision from "[Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator. " to "[Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator.". fahadnayyar added a comment. Fixing clang-format er

[PATCH] D139114: [Clang][Sema] Enabled Wshorten-64-to-32 for CompoundAssignment operator. This change enables Wshorten-64-to-32 waring for compound assignment statements which has implicit conversion

fahadnayyar created this revision. Herald added a project: All. fahadnayyar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...://10466193 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139114 Files: clang/lib/Sema/Se

[PATCH] D138434: [Clang][Sema] Added space after ',' in a warning

fahadnayyar created this revision. Herald added a project: All. fahadnayyar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change fixes a typo in a warning message. rdar://79707705 Repository: rG LLVM Github Monorepo https://rev