fahadnayyar marked 3 inline comments as done. fahadnayyar added a comment. In D141868#4060757 <https://reviews.llvm.org/D141868#4060757>, @NoQ wrote:
> Looks great! Sounds like you're looking for a more permanent fix, I guess > `ConversionFixItGenerator` could try to avoid adding fixits to system header > functions? It probably requires some larger rearchitecturing of the FixItGeneration implementation to avoid system headers for all kinds of FixitHints like `ConversionFixIt`. We can do that later as a separate patch after getting some more examples where fixits are suggested for system headers. In D141868#4065287 <https://reviews.llvm.org/D141868#4065287>, @aaron.ballman wrote: > You should also add a release note for the changes. Done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141868/new/ https://reviews.llvm.org/D141868 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
