fahadnayyar marked an inline comment as done.
fahadnayyar added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:14115
 
+/// Analyze the given compound assignment for the possible losing of
+/// floating-point precision.
----------------
aaron.ballman wrote:
> Moving this function to another spot in the file makes comparing the new and 
> old code pretty hard -- would it make more sense to forward declare the 
> needed static functions so this can stay where it was and it's easier to see 
> what's changed?
@aaron.ballman I've made the required changes. Please have a look, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139114/new/

https://reviews.llvm.org/D139114

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to