[PATCH] D157586: [clang][AVR] Restrict IntMaxType to 16-bit signed integer

benshi001 added a comment. A better fix is https://reviews.llvm.org/D157584 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157586/new/ https://reviews.llvm.org/D157586 ___ cfe-commits mailing list cfe-com

[PATCH] D157586: [clang][AVR] Restrict IntMaxType to 16-bit signed integer

benshi001 created this revision. benshi001 added reviewers: jacquesguan, aykevl, Patryk27. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes bug https://g

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 closed this revision. benshi001 added a comment. Closed by https://reviews.llvm.org/rG80cd505914dfc2f38f57341f9bef9d208fdc238e https://github.com/llvm/llvm-project/commit/80cd505914dfc2f38f57341f9bef9d208fdc238e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 545952. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 Files: llvm/lib/Target/CSKY/CSKYISelLowering.cpp llvm/lib/Target/CSKY/CSKYInstrInfo.td llvm/test/CodeGen

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 added inline comments. Comment at: llvm/test/CodeGen/CSKY/intrinsic.ll:36 +define i16 @bswap16(i16 %x) { +; CHECK-LABEL: bswap16: +; CHECK: # %bb.0: # %entry zixuan-wu wrote: > Again. It's related to cttz? I have made another patch for these addit

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:67 + return __builtin_bswap64(x); +} zixuan-wu wrote: > Those are target-independent intrinsics/builtins. I think it's no more need

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 545158. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 Files: llvm/lib/Target/CSKY/CSKYISelLowering.cpp llvm/lib/Target/CSKY/CSKYInstrInfo.td llvm/test/CodeGen/CSKY/intrinsic.ll Index: llvm/test/C

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 545152. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 Files: llvm/lib/Target/CSKY/CSKYISelLowering.cpp llvm/lib/Target/CSKY/CSKYInstrInfo.td llvm/test/CodeGen

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

benshi001 added a comment. In D153197#4483230 , @Patryk27 wrote: > ping ping, @benshi001 👀 Could you please upload your final version of this patch ? I see you have made some changes, but only mentioned in your comment. Repository: rG LLVM Github Mo

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 added inline comments. Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:1 +// RUN: %clang_cc1 -triple csky -emit-llvm -o - %s | FileCheck %s + This file is pure test, has nothing to do with `llvm.cttz`, just to avoid another patch. Repository: r

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 538356. benshi001 set the repository for this revision to rG LLVM Github Monorepo. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:2207 + MF->push_back(LoopBB); + MachineBasicBlock *ExitBB = EntryBB->splitAt(MI, false); + Patryk27 wrote: > Alright, this is wrong, after all - I've just tested it on a more e

[PATCH] D148908: [Driver][NFC] Simplify code.

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148908/new/ https://reviews.llvm.org/D148908 _

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 added a comment. In D145646#4213975 , @MaskRay wrote: > In D145646#4213547 , @gulfem wrote: > >> We started seeing a test failure in `avr-ld.c`. >> >> /b/s/w/ir/x/w/llvm-llvm-project/clang/test/Driver/

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d37efdbc599: [clang][driver] Enable '-flto' on AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D145646?vs=503607&i

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96cc2d07e15a: [clang] Add AVR specific inline assembly escaped characters (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:433 +AVRTargetInfo::handleAsmEscapedChar(char EscChar) const { + char C; + switch (EscChar) { jacquesguan wrote: > redundant variable? Remov

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

benshi001 updated this revision to Diff 504631. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145659/new/ https://reviews.llvm.org/D145659 Files: clang/lib/Basic/Targets/AVR.cpp clang/lib/Basic/Targets/AVR.h clang/test/CodeGen/avr/avr-inline-asm-constraints.c Index: clang/test/Co

[PATCH] D145659: [clang] Add AVR specific inline assembly escaped characters

benshi001 created this revision. benshi001 added reviewers: jacquesguan, aykevl. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 updated this revision to Diff 503607. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145646/new/ https://reviews.llvm.org/D145646 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/avr-ld.c

[PATCH] D145646: [clang][driver] Enable '-flto' on AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl. Herald added subscribers: Jim, inglorion, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Fixes http

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c112897b202: [clang][driver] Do not emit default '-Tdata' for AVR devices (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D144533?vs=499360&id=501386#toc Repository: rG LL

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

benshi001 added a comment. In D144533#4160297 , @MaskRay wrote: > This change is an improvement but why is `__DATA_REGION_ORIGIN__` defined? Because, 1. Different AVR devices have different SRAM address range (start & length), and `__DATA_REGION_ORIGIN

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:548 +// '-mrelax' is default unless '-mno-relax' is specified. +if (Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax, true)) MaskRay wrote: > The comment just repea

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

This revision was automatically updated to reflect the committed changes. benshi001 marked an inline comment as done. Closed by commit rG91610433907e: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D144620?vs=

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

benshi001 updated this revision to Diff 499757. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144620/new/ https://reviews.llvm.org/D144620 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-ld.c clang/test/Driver/avr-toolchain.c

[PATCH] D144620: [clang][driver] Handle '-mrelax' and '-mno-relax' for AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

benshi001 added a comment. Different AVR device families have different default linker scripts in avr-ld, but they have 95% similarity and look like as following, we can use `--defsym=__DATA_REGION_ORIGIN__` to decide the default data region range instead of current `-Tdata`. /* Script for l

[PATCH] D144533: [clang][driver] Do not emit default '-Tdata' for AVR devices

benshi001 created this revision. benshi001 added reviewers: aykevl, MaskRay. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Different AVR devices

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added a comment. In D142595#4092435 , @MaskRay wrote: > How does avr-gcc know whether the user provides a linker script? > > I really don't like adding a default `-Tdata=` when it can interfere with > common uses of specifying a linker script.

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added a comment. In D142595#4092435 , @MaskRay wrote: > How does avr-gcc know whether the user provides a linker script? > > I really don't like adding a default `-Tdata=` when it can interfere with > common uses of specifying a linker script.

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added a comment. In D142595#4091176 , @MaskRay wrote: > In D142595#4089391 , @benshi001 > wrote: > >> In D142595#4089124 , @MaskRay >> wrote: >> >>> OK. If thi

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:544 + if (SectionAddressData) { +CmdArgs.push_back(Args.MakeArgString( +"-Tdata=0x" + Twine::utohexstr(*SectionAddressData))); Just moving the default `-T` f

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when '-T' is specified

benshi001 updated this revision to Diff 493179. benshi001 retitled this revision from "[Driver][AVR] Don't emit default '-Tdata' when a linker script is specified" to "[Driver][AVR] Don't emit default '-Tdata' when '-T' is specified". benshi001 edited the summary of this revision. benshi001 remov

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 added a comment. In D142595#4089124 , @MaskRay wrote: > OK. If this doesn't add `-Tdata=` driver options, I'm fine with it. > But why is default `-Tdata` added in the first place? > > Most linker scripts are added as `-Wl,-T,a.lds` (`-Wl,` value

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:500 - if (SectionAddressData) { -CmdArgs.push_back(Args.MakeArgString( -"-Tdata=0x" + Twine::utohexstr(*SectionAddressData))); - } else { -// We do not have an entry for this CPU

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 updated this revision to Diff 493053. benshi001 edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142595/new/ https://reviews.llvm.org/D142595 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/test/Drive

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 added a comment. In D142595#4088364 , @MaskRay wrote: > This is probably not a good idea. See > https://github.com/llvm/llvm-project/issues/60203#issuecomment-1407532083 I agree with your comment in `https://github.com/llvm/llvm-project/issue

[PATCH] D142595: [Driver][AVR] Don't emit default '-Tdata' when a linker script is specified

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl, Miss_Grape. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Fixes htt

[PATCH] D141598: [clang] Redefine some AVR specific macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG16f9451b0761: [clang] Redefine some AVR specific macros (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141598/new/ https://reviews.l

[PATCH] D141647: [clang][test] Remove unnecessary 'REQUIRES'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG485ba407a6a9: [clang][test] Remove unnecessary 'REQUIRES' (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141647: [clang][test] Remove unnecessary 'REQUIRES'

benshi001 created this revision. benshi001 added reviewers: aaron.ballman, MaskRay. Herald added subscribers: kosarev, tpr. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. The test 'Preproc

[PATCH] D141598: [clang] Redefine some AVR specific macros

benshi001 created this revision. benshi001 added reviewers: aykevl, Miss_Grape. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG L

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 added a comment. In D139305#4013217 , @aykevl wrote: > I think having `-mcpu` as an alias for `-mmcu` on AVR is fine, but I don't > think it's very useful to be honest. The `-mmcu` (or `-mcpu`) flag is > inherently specific to that particular

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2638a7a34d9: [clang] Do not extend i8 return values to i16 on AVR. (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139908/new/ https

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

benshi001 added a comment. On 32-bit / 64-bit machines, a function returning lower types (via a register) should an explicit sign/zero extension to full fill the register. But on AVR, a 8-bit register is used to return 8-bit values, so the sign/zero extension is unnecessary, and lead to extra u

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

benshi001 added a comment. This patch fixes https://github.com/llvm/llvm-project/issues/58877 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139908/new/ https://reviews.llvm.org/D139908 ___ cfe-commits

[PATCH] D139908: [clang] Do not extend i8 return values to i16 on AVR.

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 added a comment. In D139305#3974946 , @MaskRay wrote: > This makes `-mmcu=` available for non-AVR targets, which is not right. > Even for AVR, if this is a plain alias, is this really necessary? Usually > having more than one aliases for one fu

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 updated this revision to Diff 480749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139305/new/ https://reviews.llvm.org/D139305 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/avr-mmcu.c Index: clang/test/Driver/

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 updated this revision to Diff 480748. benshi001 retitled this revision from "[clang][driver] Make option '-mmcu' as an alias of option '-mcpu'" to "[clang][driver] Support option '-mcpu' on target AVR.". benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION https:/

[PATCH] D139305: [clang][driver] Make option '-mmcu' as an alias of option '-mcpu'

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:387 return A->getValue(); +if (const Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) + return A->getValue(); aricha

[PATCH] D139305: [clang][driver] Make option '-mmcu' as an alias of option '-mcpu'

benshi001 updated this revision to Diff 480040. benshi001 retitled this revision from "[clang][driver] Support option '-mcpu' on target AVR" to "[clang][driver] Make option '-mmcu' as an alias of option '-mcpu'". Herald added a subscriber: jeroen.dobbelaere. CHANGES SINCE LAST ACTION https://r

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR

benshi001 added inline comments. Comment at: clang/test/Driver/avr-mmcu.c:48 -// RUN: %clang -### --target=avr -mmcu=atmega16a -save-temps %s 2>&1 | FileCheck -check-prefix=CHECKb %s -// CHECKb: "-cc1" {{.*}} "-target-cpu" "atmega16a" -// CHECKb: "-cc1as" {{.*}} "-target-cpu" "a

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added subscribers: luismarques, s.egerton, Jim, PkmX, simoncook, kristof.beyls, arichardson. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, pcwan

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/Targets/AVR.cpp:355 +.Cases("31", "51", "6", true) +.Cases("104", "105", "106", "107", true) +.Default(false);

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

This revision was automatically updated to reflect the committed changes. Closed by commit rG84ef72357328: [clang] Fix wrong ABI of AVRTiny. (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138125/new/ https://reviews.llvm.org/

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/test/CodeGen/avr/struct.c:37 +long long fooi64(void) { + return 0xaa5533; +} aykevl wrote: > benshi001 wrote: > > This file should be renamed to return.c instead of cu

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 updated this revision to Diff 475808. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138125/new/ https://reviews.llvm.org/D138125 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/avr/return-value.c clang/test/CodeGen/avr/struct.c Index: clang/test/CodeGen/avr/r

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 added inline comments. Comment at: clang/test/CodeGen/avr/struct.c:37 +long long fooi64(void) { + return 0xaa5533; +} This file should be renamed to return.c instead of current struct.c, I will do that in another patch, just let you see clearly what I

[PATCH] D138125: [clang] Fix wrong ABI on AVRTiny

benshi001 created this revision. benshi001 added reviewers: aykevl, dylanmckay. Herald added a subscriber: Jim. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. A scalar which exceeds 4 byte

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:355 +.Cases("31", "51", "6", true) +.Cases("104", "105", "106", "107", true) +.Default(false); benshi001 wrote: > ATxmega16a4 with family code 102 also supports ELPM. Could y

[PATCH] D137572: [AVR][Clang] Implement __AVR_HAVE_*__ macros

benshi001 added inline comments. Comment at: clang/lib/Basic/Targets/AVR.cpp:355 +.Cases("31", "51", "6", true) +.Cases("104", "105", "106", "107", true) +.Default(false); ATxmega16a4 with family code 102 also supports ELPM. Could you please make a c

[PATCH] D137521: [AVR][Clang] Implement __AVR_ARCH__ macro

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137521/new/ https://reviews.llvm.org/D137521 _

[PATCH] D137520: [AVR][Clang] Move family names into MCU list

benshi001 accepted this revision. benshi001 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137520/new/ https://reviews.llvm.org/D137520 _

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. @phosek , I have re-landed my patch, it seems the core reason is compiler-rt is default in Fuchsia environment, other than libgcc. please inform me if it went wrong any longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. In D128133#3723847 , @phosek wrote: > We started seeing test failures after this change on our bots. Would it be > possible to revert the change and address these issues before relanding? > > In `Clang :: Driver/avr-ld.c`: > >

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44a647d21d94: [Driver] Support linking to compiler-rt for target AVR (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:539 +// Link to compiler-rt. We directly put the libclang.builtins.a +// as input file, other than '-lclang.builtins'. +if (RtLib == ToolChain:

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D127501: [AVR] Fixed broken linking using `avr-gcc`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d01a8572076: [Driver] Improve linking options for target AVR (authored by KOLANICH, committed by benshi001). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 added a comment. A gentle ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438238. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438195. benshi001 set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChain

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438182. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438181. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 added inline comments. Comment at: clang/test/Driver/avr-toolchain.c:83 +// RUN: %clang %s -### --target=avr -mmcu=atmega328 --sysroot=%S/Inputs/basic_avr_tree/ -resource-dir=%S/Inputs/resource_dir_with_per_target_subdir -fuse-ld=%S/Inputs/basic_avr_tree/usr/bin/ld.l

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 created this revision. benshi001 added reviewers: MaskRay, aykevl. Herald added subscribers: StephenFan, Jim, dberris, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang.

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438171. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438169. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. In D126192#3583924 , @haowei wrote: > In D126192#3583915 , @benshi001 > wrote: > >> It seems the file >> `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. It seems the file `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld` is missing on your machine, which I have newly created in current patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. In D126192#3583886 , @haowei wrote: > Emmm, I applied your latest patch on top of > main(6e02e27536b9de25a651cfc9c2966ce471169355 > ) but I > still get a te

[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

benshi001 added a comment. In D127814#3583854 , @haowei wrote: > I tested this patch on top of > https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25 > (reverted in > https://github.com/llvm/llvm-project/commit/7fae15f92

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. In D126192#3583795 , @haowei wrote: > I already reverted the change in > https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad > . It is likely the breakage is caused by the fact that Fuchsia's C

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 updated this revision to Diff 436992. benshi001 added a reviewer: haowei. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Dr

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. I think I have fixed in another patch https://reviews.llvm.org/D127814, could you please have a look? @haowei I have not your environment, my patch works on my ubuntu system, could you please try it on your build machine ? Repository: rG LLVM Github Monorepo CHA

[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

benshi001 created this revision. benshi001 added reviewers: haowei, MaskRay. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. I will fix it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D126192: [Driver] Improve linking options for target AVR

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7599be9e84f: [Driver] Improve linking options for target AVR (authored by benshi001). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://rev

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. a gentle ping ... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:428 +} + void AVR::Linker::ConstructJob(Compilation &C, const JobAction &JA, 1. Though I expect each device family has its own optimized build of compiler-rt binary, I found most t

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 435036. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 434709. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 434706. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

  1   2   3   4   >