[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tbaeder added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:121 + unsigned CharSize = llvm::getNumBytesForUTF8(*Begin); + const unsigned char *End = Begin + CharSize; tahonermann wrote: > This could assign `End` to a location past the end

[clang] d71a4e0 - Reland [clang-repl] Introduce Value to capture expression results

Author: Jun Zhang Date: 2023-05-19T13:40:44+08:00 New Revision: d71a4e02277a64a9dece591cdf2b34f15c3b19a0 URL: https://github.com/llvm/llvm-project/commit/d71a4e02277a64a9dece591cdf2b34f15c3b19a0 DIFF: https://github.com/llvm/llvm-project/commit/d71a4e02277a64a9dece591cdf2b34f15c3b19a0.diff LOG

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 ___

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147916/new/ https://reviews.llvm.org/D147916 ___

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 523649. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h Index: clang/includ

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna created this revision. Manna added a reviewer: tahonermann. Herald added a subscriber: steakhal. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch adds missing assignment operator to the class which h

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. I object to parse and ignore this GCC option, which appears obscure. Clang traditionally added many `clang_ignored_gcc_optimization_f_Group` and `IgnoredGCCCompat` options to suppor

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. In D141907#4355228 , @tstellar wrote: > @paperchalice Do you need someone to commit this for you? Sure, I don't have the commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. @paperchalice Do you need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907/new/ https://reviews.llvm.org/D141907 ___ cfe-commits mailing list

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

eopXD updated this revision to Diff 523646. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147916/new/ https://reviews.llvm.org/D147916 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChec

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 523645. eopXD marked 2 inline comments as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 Files: clang/inclu

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2602 + unsigned MaxIndex = cast(VTupleOperand->getType())->getNumElements(); + Index = std::min(Index, MaxIndex); + craig.topper wrote: > Does this `min` do anyt

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

eopXD updated this revision to Diff 523643. eopXD marked 4 inline comments as done. eopXD added a comment. Address comments from Craig.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147916/new/ https://reviews.llvm.org/D147916 Files: clang/incl

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

thesamesam added a comment. This is just a draft which I've only briefly tested so far. I'm wondering if this is the right place to put the option, as i've not had to write anything in tablegen before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

thesamesam created this revision. thesamesam added reviewers: MaskRay, jhuber6, tstellar. Herald added a project: All. thesamesam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since 47f5c54f997a59bb2c65abe6b8b811f6e7553456

[PATCH] D121497: Lex: add support for `{,u}i128` Microsoft extension

STREGA added a comment. I just hit this issue in my project. Here is intsafe.h from Windows 10 SDK 20348 (latest) F27520574: intsafe.h There are 3 macros with 128 bit suffixes; INT128_MAX, UINT128_MAX and INT128_MIN. I couldn't find any references to any of

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2640 + llvm::Value *VOperand = Ops[2]; + assert(isa(IndexOperand)); + Drop this assert Comment at: clang/include/clang/Basic/riscv_vecto

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2599 + llvm::Value *IndexOperand = Ops[1]; + assert(isa(IndexOperand)); + unsigned Index = cast(IndexOperand)->getZExtValue(); You can drop this a

[PATCH] D147915: [9/11][POC][Clang][RISCV] Define tuple type variant of vsoxseg2ei32 vsuxseg2ei32

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147915/new/ https://reviews.llvm.org/D147915 ___

[PATCH] D147914: [8/11][POC][Clang][RISCV] Define tuple type variant of vloxseg2ei32 vluxseg2ei32

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147914/new/ https://reviews.llvm.org/D147914 ___

[PATCH] D147913: [7/11][POC][Clang][RISCV] Define tuple type variant of vssseg2e32

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147913/new/ https://reviews.llvm.org/D147913 ___

[PATCH] D147912: [6/11][POC][Clang][RISCV] Define tuple type variant of vlsseg2e32

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147912/new/ https://reviews.llvm.org/D147912 ___

[PATCH] D147911: [5/11][POC][Clang][RISCV] Define tuple type variant of vlseg2e32ff

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147911/new/ https://reviews.llvm.org/D147911 ___

[PATCH] D147774: [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147774/new/ https://reviews.llvm.org/D147774 ___

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147731/new/ https://reviews.llvm.org/D147731 ___

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4fbc4bdbf58: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] b4fbc4b - [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Author: Manna, Soumi Date: 2023-05-18T18:14:07-07:00 New Revision: b4fbc4bdbf58b9cecc9c66e8b8d97d3cebb5a976 URL: https://github.com/llvm/llvm-project/commit/b4fbc4bdbf58b9cecc9c66e8b8d97d3cebb5a976 DIFF: https://github.com/llvm/llvm-project/commit/b4fbc4bdbf58b9cecc9c66e8b8d97d3cebb5a976.diff

[PATCH] D147915: [9/11][POC][Clang][RISCV] Define tuple type variant of vsoxseg2ei32 vsuxseg2ei32

eopXD updated this revision to Diff 523626. eopXD added a comment. Removed another variable that is too verbose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147915/new/ https://reviews.llvm.org/D147915 Files: clang/include/clang/Basic/riscv_ve

[PATCH] D147914: [8/11][POC][Clang][RISCV] Define tuple type variant of vloxseg2ei32 vluxseg2ei32

eopXD updated this revision to Diff 523625. eopXD added a comment. Removed another variable that is too verbose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147914/new/ https://reviews.llvm.org/D147914 Files: clang/include/clang/Basic/riscv_ve

[PATCH] D147913: [7/11][POC][Clang][RISCV] Define tuple type variant of vssseg2e32

eopXD updated this revision to Diff 523623. eopXD added a comment. Removed another variable that is too verbose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147913/new/ https://reviews.llvm.org/D147913 Files: clang/include/clang/Basic/riscv_ve

[PATCH] D147912: [6/11][POC][Clang][RISCV] Define tuple type variant of vlsseg2e32

eopXD updated this revision to Diff 523622. eopXD added a comment. Removed another variable that is too verbose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147912/new/ https://reviews.llvm.org/D147912 Files: clang/include/clang/Basic/riscv_ve

[PATCH] D147911: [5/11][POC][Clang][RISCV] Define tuple type variant of vlseg2e32ff

eopXD updated this revision to Diff 523621. eopXD added a comment. Removed another variable that is too verbose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147911/new/ https://reviews.llvm.org/D147911 Files: clang/include/clang/Basic/riscv_ve

[PATCH] D147774: [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32

eopXD updated this revision to Diff 523620. eopXD added a comment. Removed another variable that is too verbose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147774/new/ https://reviews.llvm.org/D147774 Files: clang/include/clang/Basic/riscv_ve

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD updated this revision to Diff 523617. eopXD added a comment. Removed another variable that is too verbose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147731/new/ https://reviews.llvm.org/D147731 Files: clang/include/clang/AST/ASTContext

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7bdf1996fd1: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag. (authored by Artem Dergachev ). Herald add

[clang] b7bdf19 - [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag.

Author: Artem Dergachev Date: 2023-05-18T17:20:27-07:00 New Revision: b7bdf1996fd195b20b9a2916c9183167650806f1 URL: https://github.com/llvm/llvm-project/commit/b7bdf1996fd195b20b9a2916c9183167650806f1 DIFF: https://github.com/llvm/llvm-project/commit/b7bdf1996fd195b20b9a2916c9183167650806f1.dif

[clang] 5070b55 - [RISCV] Fix incorrect check-prefixes in attr-riscv-rvv-vector-bits-types.c. NFC

Author: Craig Topper Date: 2023-05-18T17:10:22-07:00 New Revision: 5070b55df9116a77967f11d346d0b338b793ab2f URL: https://github.com/llvm/llvm-project/commit/5070b55df9116a77967f11d346d0b338b793ab2f DIFF: https://github.com/llvm/llvm-project/commit/5070b55df9116a77967f11d346d0b338b793ab2f.diff

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

NoQ updated this revision to Diff 523601. NoQ added a comment. Rebase *correctly*! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146669/new/ https://reviews.llvm.org/D146669 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/clang/Basic/DiagnosticOptions

[PATCH] D146669: [-Wunsafe-buffer-usage] Hide fixits/suggestions behind an extra flag, -fsafe-buffer-usage-suggestions.

NoQ updated this revision to Diff 523595. NoQ added a comment. Rebase! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146669/new/ https://reviews.llvm.org/D146669 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/clang/Basic/DiagnosticOptions.def clang

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

rjmccall added a comment. Can you add a test? I think we have some in-tree targets which put globals in a non-default address space. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1679 CGF.GetVTTParameter(GlobalDecl(D, Type), ForVirtualBase, Delegating); - QualType V

[clang] c51fceb - [RISCV] Remove unused CHECK-ILP lines from attr-riscv-rvv-vector-bits-types.c. NFC

Author: Craig Topper Date: 2023-05-18T15:47:29-07:00 New Revision: c51fcebbbfd389e5dd8c6437da169c46dedfe51d URL: https://github.com/llvm/llvm-project/commit/c51fcebbbfd389e5dd8c6437da169c46dedfe51d DIFF: https://github.com/llvm/llvm-project/commit/c51fcebbbfd389e5dd8c6437da169c46dedfe51d.diff

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and adapt __bf16 to be arithmetic type

codemzs added a comment. I have created a separate change to upgrade existing `__bf16` to arithmetic type at D150913 Comment at: clang/lib/AST/Type.cpp: + return (BT->getKind() >= BuiltinType::Bool && + BT->getKind() <=

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs added a comment. Misc style improvement. Comment at: clang/lib/AST/Type.cpp:2199 if (const auto *BT = dyn_cast(CanonicalType)) -return BT->getKind() >= BuiltinType::Bool && - BT->getKind() <= BuiltinType::Ibm128 && - BT->getKind() != BuiltinTy

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:59 +- Clang no longer allows dereferencing of a ``void*`` as an extension. Clang 16 + converted this to a warning-as-default-error as well as a SFINAE error. Mention `-Wvoid-ptr-dereference

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs created this revision. codemzs added reviewers: tahonermann, rjmccall, zahiraam, stuij, pengfei, erichkeane. Herald added subscribers: mattd, gchakrabarti, asavonic, kerbowa, kristof.beyls, jvesely. Herald added a project: All. codemzs requested review of this revision. Herald added subsc

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

ziqingluo-90 accepted this revision. ziqingluo-90 added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146773/new/ https://reviews.llvm.org/D146773

[PATCH] D150820: [NVPTX, CUDA] added optional src_size argument to __nvvm_cp_async*

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Re-approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150820/new/ https://reviews.llvm.org/D150820 ___

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 523569. yonghong-song edited the summary of this revision. yonghong-song added a comment. - Fixed previous llvm-objdump issue for '> 16bit' 'gotol' insns. - Now basic functionality for cpu=v4 should be complete for llvm, further work will focus on kerne

[PATCH] D150820: [NVPTX, CUDA] added optional src_size argument to __nvvm_cp_async*

tra requested review of this revision. tra added a comment. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150820/new/ https://reviews.llvm.org/D150820 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D150820: [NVPTX, CUDA] added optional src_size argument to __nvvm_cp_async*

tra updated this revision to Diff 523566. tra added a comment. Instead of changing existing intrinsic, introduce a new set which takes an additional src_size argument. This should keep existing users working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added a comment. Thank you @tahonermann, @NoQ, @aaronpuchert for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Thanks @Manna, this looks good to me now! Comment at: clang/include/clang/Sema/ParsedAttr.h:705-707 + // The move assignment operator is defined as deleted pending

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

MineGame159 created this revision. MineGame159 added reviewers: clang, clang-c. MineGame159 added projects: clang, clang-c. Herald added a subscriber: arphaman. Herald added a project: All. MineGame159 requested review of this revision. Herald added a subscriber: cfe-commits. Adds 2 new functions

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. Splitting this into two patches (one to do the renames, another to perform the other changes) would simplify review. Comment at: clang/lib/Frontend/TextD

[PATCH] D150394: [OpenMP 5.2] Deprecate MINUS (-) operator on reduction clauses

mdfazlay closed this revision. mdfazlay added a comment. Commit ID - c657363 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150394/new/ https://reviews.llvm.org/D150394 ___

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

aheejin added a comment. Nice! Just some drive-by nitpicking, sorry 😅 Comment at: lld/test/wasm/async.ll:11 + +define void @bar() #1 { +ret void Comment at: lld/test/wasm/async.ll:21-22 + +attributes #0 = { "wasm-async" } +attributes #1

[PATCH] D150087: [Clang] Support more stdio builtins

tuliom accepted this revision. tuliom added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150087/new/ https://reviews.llvm.org/D150087 __

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

qianzhen updated this revision to Diff 523546. qianzhen added a comment. Refactor as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150221/new/ https://reviews.llvm.org/D150221 Files: clang/include/clang/Basic/CodeGenOptions.def clang

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:705-707 + // The move assignment operator is defined as deleted pending further + // motivation. + AttributePool &operator=(AttributePool &&pool) = delete; tahonermann wrote: > Let'

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 523540. Manna marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Analysis/Analyses/Consumed.h clang/include/

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dim added a subscriber: bsdjhb. dim added a comment. In D150226#4353911 , @aaron.ballman wrote: > One of the major selling points to `constexpr` functions in C++ is that they > cannot contain UB -- if your code compiles, it is correct. This bug that >

[clang] e8b15c4 - [RISCV] Fix test that was still using __RISCV_RVV_VLEN_BITS. NFC

Author: Craig Topper Date: 2023-05-18T13:25:28-07:00 New Revision: e8b15c4eb28d56e9dd1ad792c32c5158080ec639 URL: https://github.com/llvm/llvm-project/commit/e8b15c4eb28d56e9dd1ad792c32c5158080ec639 DIFF: https://github.com/llvm/llvm-project/commit/e8b15c4eb28d56e9dd1ad792c32c5158080ec639.diff

[clang] c8a23ec - [NFC][Driver] Fix -Wdangling-else warning

Author: Michael Platings Date: 2023-05-18T21:16:56+01:00 New Revision: c8a23ec0cbac460dbbefb6683cdbed49e5472086 URL: https://github.com/llvm/llvm-project/commit/c8a23ec0cbac460dbbefb6683cdbed49e5472086 DIFF: https://github.com/llvm/llvm-project/commit/c8a23ec0cbac460dbbefb6683cdbed49e5472086.di

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

tahonermann added a comment. One last minor request and then I'm happy with this. Comment at: clang/include/clang/Sema/ParsedAttr.h:705-707 + // The move assignment operator is defined as deleted pending further + // motivation. + AttributePool &operator=(AttributePool &&poo

[clang] 7c26919 - [Clang] Fix typo in ReleaseNotes.rst

Author: Alexander Shaposhnikov Date: 2023-05-18T20:08:54Z New Revision: 7c26919c32f0620441417805329867884a5efc7b URL: https://github.com/llvm/llvm-project/commit/7c26919c32f0620441417805329867884a5efc7b DIFF: https://github.com/llvm/llvm-project/commit/7c26919c32f0620441417805329867884a5efc7b.d

[PATCH] D149906: [Clang] Update release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd4677f20704: [Clang] Update release notes (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149906/new/ https://reviews.l

[clang] cd4677f - [Clang] Update release notes

Author: Alexander Shaposhnikov Date: 2023-05-18T20:02:37Z New Revision: cd4677f207041e74f55d0cac6145942f04301ee7 URL: https://github.com/llvm/llvm-project/commit/cd4677f207041e74f55d0cac6145942f04301ee7 DIFF: https://github.com/llvm/llvm-project/commit/cd4677f207041e74f55d0cac6145942f04301ee7.d

[PATCH] D150820: [NVPTX, CUDA] added optional src_size argument to __nvvm_cp_async*

tra added a comment. Looks like the extra intrinsic argument broke MLIR. I'll need to figure out how to deal with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150820/new/ https://reviews.llvm.org/D150820 ___

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna added a comment. In D150411#4354135 , @NoQ wrote: > Static Analyzer changes look great, thanks! Thank you @NoQ for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 _

[PATCH] D150411: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

NoQ added a comment. Static Analyzer changes look great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

efriedma added a comment. I guess to make that work, the constant evaluator would need to track whether we're in an SFINAE context (Sema::isSFINAEContext()). Based on that, we'd need to explicitly generate an error if we're in an SFINAE context, and a warning if we're not in such a context. C

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings created this revision. michaelplatings added reviewers: stuij, pratlucas. Herald added subscribers: dmgreen, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1531 + Operands.push_back(Ops[Offset]); // Ptr + if (MaskOperand) +Operands.push_back(MaskOperand); MaskOperand can still be simplified. Repository: rG

[PATCH] D150473: [clang/Driver] Also consider `gnu++` standard when checking for modules support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e975d4f67c0: [clang/Driver] Also consider `gnu++` standard when checking for modules support (authored by akyrtzi). Changed prior to commit: http

[clang] 5e975d4 - [clang/Driver] Also consider `gnu++` standard when checking for modules support

Author: Argyrios Kyrtzidis Date: 2023-05-18T12:34:07-07:00 New Revision: 5e975d4f67c006420d0c65ccb0f5d08e3a352f46 URL: https://github.com/llvm/llvm-project/commit/5e975d4f67c006420d0c65ccb0f5d08e3a352f46 DIFF: https://github.com/llvm/llvm-project/commit/5e975d4f67c006420d0c65ccb0f5d08e3a352f46.

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

efriedma added a comment. In D150226#4354063 , @efriedma wrote: >> Also note, one of the bugs I reference shows how this breaks SFINAE: >> https://github.com/llvm/llvm-project/issues/57176 and that is not easily >> fixable. So this is non-conforming sin

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:4051 + if (II->isStr("vector")) +Actions.DeclareRISCVVBuiltins = true; erichkeane wrote: > So I'd say leave this where it was. Once line 4043

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik added a comment. In D150226#4354063 , @efriedma wrote: >> Also note, one of the bugs I reference shows how this breaks SFINAE: >> https://github.com/llvm/llvm-project/issues/57176 and that is not easily >> fixable. So this is non-conforming since

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Manna updated this revision to Diff 523509. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150895/new/ https://reviews.llvm.org/D150895 Files: clang/lib/Parse/ParsePragma.cpp Index: clang/lib/Parse/ParsePragma.cpp === ---

[PATCH] D150689: [clang][DependencyScanner] Remove all warning flags when suppressing warnings

ributzka added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:50 + // optimize. + if (!IsSystemModule) +return; This removes also all warnings when building your own module, because of the `[system]` attribute. I w

[PATCH] D147915: [9/11][POC][Clang][RISCV] Define tuple type variant of vsoxseg2ei32 vsuxseg2ei32

eopXD updated this revision to Diff 523506. eopXD added a comment. Reduce variables declared but only used once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147915/new/ https://reviews.llvm.org/D147915 Files: clang/include/clang/Basic/riscv_ve

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

efriedma added a comment. > Also note, one of the bugs I reference shows how this breaks SFINAE: > https://github.com/llvm/llvm-project/issues/57176 and that is not easily > fixable. So this is non-conforming since it breaks valid code. You can mark a warning diagnostic SFINAEFailure to ensure

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

erichkeane added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:4051 + if (II->isStr("vector")) +Actions.DeclareRISCVVBuiltins = true; So I'd say leave this where it was. Once line 4043 happens, II is stable, we just need to make sure it do

[PATCH] D147914: [8/11][POC][Clang][RISCV] Define tuple type variant of vloxseg2ei32 vluxseg2ei32

eopXD updated this revision to Diff 523503. eopXD added a comment. Reduce variables declared but only used once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147914/new/ https://reviews.llvm.org/D147914 Files: clang/include/clang/Basic/riscv_ve

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Manna updated this revision to Diff 523502. Manna added a comment. Herald added a subscriber: asb. I have removed `IntrinsicClass` and updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150895/new/ https://reviews.llvm.org/D150895 Files: clang/lib/Parse/ParsePragma.cpp I

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

shafik added a comment. In D150226#4353911 , @aaron.ballman wrote: > In D150226#4353905 , @dim wrote: > >> I submitted a similar workaround for the FreeBSD devel/gdb port, via >> https://bugs.freebsd.org/bugzill

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

aaron.ballman added a comment. In D150875#4353658 , @erichkeane wrote: > Ok, so I was curious why this was an extension. This is the original patch: > https://github.com/llvm/llvm-project/commit/80877c228d019e9cdca6295f3197867cc86e1720 > where @rsmith

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146873/new/ https://reviews.llvm.org/D146873 ___

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

erichkeane added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:4058 + PP.Lex(Tok); + II = Tok.getIdentifierInfo(); Manna wrote: > erichkeane wrote: > > I'm having trouble figuring out why this isn't a breaking change. > > `PP.Lex(Tok)` moves

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

eopXD updated this revision to Diff 523493. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146873/new/ https://reviews.llvm.org/D146873 Files: clang/include/clang/Basic/RISCVVTypes.def clang/li

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

nickdesaulniers updated this revision to Diff 523492. nickdesaulniers added a comment. - test __builtin_dynamic_object_size too, add that to release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150892/new/ https://reviews.llvm.org/D150892 F

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

Manna added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:4058 + PP.Lex(Tok); + II = Tok.getIdentifierInfo(); erichkeane wrote: > I'm having trouble figuring out why this isn't a breaking change. > `PP.Lex(Tok)` moves the current 'token' to b

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3156 } else { - AddrToStoreInto = -CreateTempAlloca(STy, Alloca.getAlignment(), "coerce"); -} + uint64_t SrcSize = CGM.getDataLayout().getTypeAllocSize(STy)

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

nickdesaulniers added a comment. This also changes the behavior of `__builtin_dynamic_object_size` (see @kees ' full example: https://github.com/llvm/llvm-project/issues/62789#issue-1714764560). s/changes/fixes/. Let me add more tests and notes about that. Repository: rG LLVM Github Monorep

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

eopXD updated this revision to Diff 523491. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146873/new/ https://reviews.llvm.org/D146873 Files: clang/include/clang/Basic/RISCVVTypes.def clang/li

[PATCH] D150895: [NFC][CLANG] Fix dereference issue before null check found by Coverity static analyzer tool

erichkeane added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:4058 + PP.Lex(Tok); + II = Tok.getIdentifierInfo(); I'm having trouble figuring out why this isn't a breaking change. `PP.Lex(Tok)` moves the current 'token' to be the next one (t

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

nickdesaulniers added a comment. Sure, thanks for the quick turnaround time on reviews! 🍻 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150892/new/ https://reviews.llvm.org/D150892 ___ cfe-commits mailin

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3135 STy->getNumElements() > 1) { -uint64_t SrcSize = CGM.getDataLayout().getTypeAllocSize(STy); -llvm::Type *DstTy = Ptr.getElementType(); -uint64_t DstSize = CGM.getD

[PATCH] D147913: [7/11][POC][Clang][RISCV] Define tuple type variant of vssseg2e32

eopXD updated this revision to Diff 523489. eopXD added a comment. Reduce variable declared but only used once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147913/new/ https://reviews.llvm.org/D147913 Files: clang/include/clang/Basic/riscv_vec

[PATCH] D150892: [clang][ExprConstant] fix __builtin_object_size for flexible array members

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm OK with this, but please give the clang-vendors folks a few days to comment before committing this. Thanks for your patience! Repository: rG LLVM Github Monorepo CHANGES SINCE

  1   2   3   >