ributzka added inline comments.

================
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:50
+  // optimize.
+  if (!IsSystemModule)
+    return;
----------------
This removes also all warnings when building your own module, because of the 
`[system]` attribute. I would prefer this optimization to be limited to modules 
that are in the sysroot and therefore ignore the `[system]` attribute. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150689/new/

https://reviews.llvm.org/D150689

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to