tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land.
Thanks @Manna, this looks good to me now! ================ Comment at: clang/include/clang/Sema/ParsedAttr.h:705-707 + // The move assignment operator is defined as deleted pending further + // motivation. + AttributePool &operator=(AttributePool &&pool) = delete; ---------------- Manna wrote: > tahonermann wrote: > > Let's explicitly delete the copy assignment operator too since the copy > > constructor is deleted. > @tahonermann , copy assignment operator has already been explicitly deleted > at line no 701. I made this change part of https://reviews.llvm.org/D149718. > It was a rebase issue, so it did show it before with my previous patch. I > have fixed it now and added comment since the copy assignment was added > explicitly as deleted. Ah, perfect! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150411/new/ https://reviews.llvm.org/D150411 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
