[PATCH] D147601: [clang][dataflow] Eliminate code duplication in Environment::createValueUnlessSelfReferential().

mboehme added a comment. Failing premerge check in CodeGen looks unrelated (this patch doesn't affect CodeGen in any way). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147601/new/ https://reviews.llvm.org/D147601

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

asb added a comment. In D146463#4247050 , @paulkirth wrote: > @asb, @craig.topper, @jrtc27 Are there any remaining considerations for us > here? From the discussions in psABI and sig-toolchain, I think we have a > consensus that this is the approach we

[PATCH] D147525: [X86] Add AMX_COMPLEX to Graniterapids

This revision was automatically updated to reflect the committed changes. Closed by commit rG847abddedca9: [X86] Add AMX_COMPLEX to Graniterapids (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147525/new/ https://reviews.llvm.

[clang] 847abdd - [X86] Add AMX_COMPLEX to Graniterapids

Author: Freddy Ye Date: 2023-04-06T13:19:44+08:00 New Revision: 847abddedca9ed2934e0c2386662ccb04ba4d298 URL: https://github.com/llvm/llvm-project/commit/847abddedca9ed2934e0c2386662ccb04ba4d298 DIFF: https://github.com/llvm/llvm-project/commit/847abddedca9ed2934e0c2386662ccb04ba4d298.diff LOG

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

jrtc27 added a comment. From an ABI/codegen perspective the small data limit doesn’t matter here, all it does is govern whether things go in .sdata or not. The linker is what chooses whether to use GP, which happens regardless of whether something is in .sdata, just things in .sdata are more li

[PATCH] D147657: [Sema] Fix reporting of invalid shader attribute on HLSL entry function

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. Thanks for fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147657/new/ https://reviews.llvm.org/D147657

[PATCH] D147572: [Clang][OpenMP] Fix failure with team-wide allocated variable

jhuber6 added inline comments. Comment at: clang/test/OpenMP/target_team_variable_codegen.cpp:33 +//. +// CHECK-NVIDIA: @local_a = internal addrspace(3) global [10 x i32] zeroinitializer, align 4 +//. Shouldn't the Nvidia version also be undefined? Not sure why

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added inline comments. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:444 +TARGET_BUILTIN(__builtin_altivec_vcmpnew_p, "iiV4iV4i", "", "power9-vector") +TARGET_BUILTIN(__builtin_altivec_vcmpned_p, "iiV2LLiV2LLi", "", "altivec") + maryammo wrote: > am

[clang] 5bbadec - Recommit [C++20] [Modules] Don't load declaration eagerly for named modules

Author: Chuanqi Xu Date: 2023-04-06T11:01:58+08:00 New Revision: 5bbadec2d1e0d5d0d25295759d49f6cd420d0968 URL: https://github.com/llvm/llvm-project/commit/5bbadec2d1e0d5d0d25295759d49f6cd420d0968 DIFF: https://github.com/llvm/llvm-project/commit/5bbadec2d1e0d5d0d25295759d49f6cd420d0968.diff LO

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

qiucf added a comment. In D143479#4243143 , @erichkeane wrote: > Based on GCC's behavior: https://godbolt.org/z/fxWzPTT9P I suspect our > behavior is consistent/correct now, and the 'regressions' are to be expected, > since GCC diagnoses the same thin

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

ChuanqiXu added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape-coro.cpp:75-79 + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:11: warning: an exception may be thrown in function 'b_ShouldNotDiag' which should not throw exceptions + if

[PATCH] D147615: [clang][Sema][NFC] Save token name instead of the full token

shafik added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:962 + // Save the token name used for static assertion. + const char *TokName = Tok.getName(); It looks like this comes from a static array so it should be fine but let's see what Aar

[PATCH] D147590: [clang] Add test for CWG607

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Thank you for working on these DRs, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147590/new/ https://reviews.llvm.org/D147590 ___

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added a comment. whe Comment at: clang/lib/Driver/SanitizerArgs.cpp:546 - if ((Kinds & SanitizerKind::ShadowCallStack) && - ((TC.getTriple().isAArch64() && -!llvm::AArch64::isX18ReservedByDefault(TC.getTriple())) || - (TC.getTriple().isRISCV() &&

[PATCH] D147666: [OPENMP] Adds /lib to rpath to avoid need to set LD_LIBRARY_PATH to find plugins.

jhuber6 added a comment. Using `-rpath` by default with OpenMP was removed after a long conversation in https://reviews.llvm.org/D143306. The way forward is most likely to have AOMP provide this in a resource file configuration. I think @ronlieb has a working version of that. Repository: rG

[PATCH] D147611: [RISCV][MC] Add support for experimental Zvfbfmin extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147611/new/ https://reviews.llvm.org/D147611 ___ cfe-commits mailing list c

[PATCH] D147673: [Clang] Improve designated inits diagnostic location

void created this revision. void added a reviewer: rsmith. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A "null" designator won't have a valid location. Try to approximate this location as best we can in

[PATCH] D146686: [Driver] Fix rpath for compiler-rt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG5f91c747763c: [Driver] Fix rpath for compiler-rt (authored by yaxunl). Herald added a project: clang. Chang

[clang] 5f91c74 - [Driver] Fix rpath for compiler-rt

Author: Yaxun (Sam) Liu Date: 2023-04-05T20:14:53-04:00 New Revision: 5f91c747763c20a63f3d6156fced03b474f842a1 URL: https://github.com/llvm/llvm-project/commit/5f91c747763c20a63f3d6156fced03b474f842a1 DIFF: https://github.com/llvm/llvm-project/commit/5f91c747763c20a63f3d6156fced03b474f842a1.dif

[PATCH] D147612: [RISCV][MC] Add support for experimental Zvfbfwma extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147612/new/ https://reviews.llvm.org/D147612 ___ cfe-commits mailing list c

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

mcgrathr added a comment. I don't see changes here to make the Fuchsia & Android targets stop doing implicit `-ffixed-x18` and to make them start doing implicit `-msmall-data-limit=0` for non-PIC modes. Comment at: clang/lib/Driver/SanitizerArgs.cpp:546 - if ((Kinds & Sani

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

craig.topper added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

MyDeveloperDay added inline comments. Herald added a project: clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Comment at: clang/lib/Format/FormatToken.h:615 tok::kw__Null_unspecified, tok::kw___ptr32, tok::kw___ptr64,

[PATCH] D147580: [Clang][NFC] Refactor "Designators" to be more similar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfee6f114236: [Clang][NFC] Refactor "Designators" to be more similar (authored by void). Changed prior to commit: https://reviews.llvm.org/D147580

[clang] bfee6f1 - [Clang][NFC] Refactor "Designators" to be more similar

Author: Bill Wendling Date: 2023-04-05T15:46:40-07:00 New Revision: bfee6f1142368e522d09551930ef90f4e6be1f42 URL: https://github.com/llvm/llvm-project/commit/bfee6f1142368e522d09551930ef90f4e6be1f42 DIFF: https://github.com/llvm/llvm-project/commit/bfee6f1142368e522d09551930ef90f4e6be1f42.diff

[clang] 3242934 - Lazily deserialize default member initializers.

Author: Richard Smith Date: 2023-04-05T15:46:13-07:00 New Revision: 32429341910d0a48336215be13c7c9140dd26da4 URL: https://github.com/llvm/llvm-project/commit/32429341910d0a48336215be13c7c9140dd26da4 DIFF: https://github.com/llvm/llvm-project/commit/32429341910d0a48336215be13c7c9140dd26da4.diff

cfe-commits@lists.llvm.org

ziqingluo-90 added a comment. In D143128#4245112 , @DavidSpickett wrote: > I've reverted this, please try to fix the test then reland. > > The full test output can be downloaded from the buildbot page, if you need > any more information let me know. Th

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

craig.topper accepted this revision. craig.topper added a comment. LGTM other than that one comment. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.cpp:86 InstrInfo(*this), RegInfo(getHwMode()), TLInfo(TM, *this) { - if (RISCV::isX18ReservedByDefault(TT)) -UserRes

[PATCH] D147546: [PS4][clang] Fix the format of the LTO debug options passed to orbis-ld

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147546/new/ https://reviews.llvm.org/D147546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142907/new/ https://reviews.llvm.org/D142907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147666: [OPENMP] Adds /lib to rpath to avoid need to set LD_LIBRARY_PATH to find plugins.

gregrodgers created this revision. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. gregrodgers requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1, MaskRay. Herald added a reviewer: jdoerfert. Herald added a project: clang.

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:502 ArrayRef LocalParameters, + SourceLocation RParenLoc, ArrayRef Requirements, erichkeane wrote: > Is this an unrelated change? Are p

cfe-commits@lists.llvm.org

Author: Ziqing Luo Date: 2023-04-05T14:54:03-07:00 New Revision: ca6ceeb0d6cd5b8545410d878c8d7bcce9538a3a URL: https://github.com/llvm/llvm-project/commit/ca6ceeb0d6cd5b8545410d878c8d7bcce9538a3a DIFF: https://github.com/llvm/llvm-project/commit/ca6ceeb0d6cd5b8545410d878c8d7bcce9538a3a.diff LO

[PATCH] D147580: [Clang] Refactor "Designators" to be more similar [NFC]

void updated this revision to Diff 511215. void added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147580/new/ https://reviews.llvm.org/D147580 Files: clang/include/clang/AST/Expr.h clang/include/clang/Sema/Designator.h c

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c614bd88f12: [clang-format] Fix bugs with "LambdaBodyIndentation: OuterScope" (authored by jp4a50, committed by owenpan). Repository: rG LLVM Gi

[clang] 5c614bd - [clang-format] Fix bugs with "LambdaBodyIndentation: OuterScope"

Author: Jon Phillips Date: 2023-04-05T14:38:38-07:00 New Revision: 5c614bd88f1252927ca1f9d9f8e802ef5e1eebe2 URL: https://github.com/llvm/llvm-project/commit/5c614bd88f1252927ca1f9d9f8e802ef5e1eebe2 DIFF: https://github.com/llvm/llvm-project/commit/5c614bd88f1252927ca1f9d9f8e802ef5e1eebe2.diff

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added a comment. @asb, @craig.topper, @jrtc27 Are there any remaining considerations for us here? From the discussions in psABI and sig-toolchain, I think we have a consensus that this is the approach we'll be taking for RISC-V. We'd prefer to correct this ASAP, so as to prevent futu

[PATCH] D147661: [Sema] Tweak merging of availability attributes

rsandifo-arm created this revision. rsandifo-arm added reviewers: arphaman, erichkeane. Herald added a reviewer: aaron.ballman. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Two calls to mergeAvai

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 511208. francii added a comment. Add -c test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/To

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

shafik added a subscriber: rsmith. shafik added a comment. Thank you for this fix. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->h

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. I have committed the patch here: https://reviews.llvm.org/rG59cb47015a18 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147574/new/ https://reviews.llvm.org/D147574 ___ cfe-commits

[clang] c61f45f - Update clang :: Driver/debug-options.c to fix the buildbots

Author: Matthew Voss Date: 2023-04-05T13:27:17-07:00 New Revision: c61f45fc3e041606c5b94c468a5c092e8a6e5601 URL: https://github.com/llvm/llvm-project/commit/c61f45fc3e041606c5b94c468a5c092e8a6e5601 DIFF: https://github.com/llvm/llvm-project/commit/c61f45fc3e041606c5b94c468a5c092e8a6e5601.diff

[PATCH] D144651: [Serialization] Place command line defines in the correct file

fdeazeve added a comment. I can check out a copy of this patch and help test it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144651/new/ https://reviews.llvm.org/D144651 ___ cfe-commits mailing list cfe

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 added a comment. Following on from our discussion about new options needing motivation from public style guides, I've updated the KJ style guide to clarify its stance on braced init lists: https://github.com/capnproto/capnproto/blob/master/style-guide.md#spacing-and-bracing Repository:

[PATCH] D147657: [Sema] Fix reporting of invalid shader attribute on HLSL entry function

rsandifo-arm created this revision. rsandifo-arm added reviewers: python3kgae, erichkeane. Herald added a subscriber: Anastasia. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the HLSL entry fun

[clang] 59cb470 - [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Author: Manna, Soumi Date: 2023-04-05T16:00:45-04:00 New Revision: 59cb47015a184862f3709a7ab084ccd086816176 URL: https://github.com/llvm/llvm-project/commit/59cb47015a184862f3709a7ab084ccd086816176 DIFF: https://github.com/llvm/llvm-project/commit/59cb47015a184862f3709a7ab084ccd086816176.diff

[PATCH] D147546: [PS4][clang] Fix the format of the LTO debug options passed to orbis-ld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc37b95b515a5: [PS4][clang] Fix the format of the LTO debug options passed to orbis-ld (authored by ormris). Herald added a project: clang. Herald add

[clang] c37b95b - [PS4][clang] Fix the format of the LTO debug options passed to orbis-ld

Author: Matthew Voss Date: 2023-04-05T12:57:21-07:00 New Revision: c37b95b515a5c69b2050c8fd50f076368742c6cb URL: https://github.com/llvm/llvm-project/commit/c37b95b515a5c69b2050c8fd50f076368742c6cb DIFF: https://github.com/llvm/llvm-project/commit/c37b95b515a5c69b2050c8fd50f076368742c6cb.diff

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

rsmith added a comment. I'm happy whenever Aaron is. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:8809 + // + // We will support P2448R2 in language modes earlier than C++23 as an extenion + // The concept of constexpr-compatible was removed. =

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

erichkeane added a comment. I can't really review the libcxxabi parts, or the llvm-demangler parts, but everything looks right to me. I've got a pair of quick questions, otherwise I think this is going to be fine for me. Note the extra paren changes are something I think are valuable, but I'm

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added a comment. Here's the diff to `test_demangle.pass.cpp`: --- a/libcxxabi/test/test_demangle.pass.cpp +++ b/libcxxabi/test/test_demangle.pass.cpp @@ -29995,10 +29995,10 @@ const char* cases[][2] = {"_Z15test_uuidofTypeI10TestStructEvDTu8__uuidofT_EE", "void test_uuidofTyp

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 added a comment. Thanks for accepting! Commit details as follows as per previous diff: Name: Jon Phillips Email: jonap2...@gmail.com If someone could commit for me that would be much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 65c0134 - [clang][deps] NFC: Make PCH test more debuggable

Author: Jan Svoboda Date: 2023-04-05T12:29:05-07:00 New Revision: 65c0134872c1e298ade176b5c84d86b4a058a85c URL: https://github.com/llvm/llvm-project/commit/65c0134872c1e298ade176b5c84d86b4a058a85c DIFF: https://github.com/llvm/llvm-project/commit/65c0134872c1e298ade176b5c84d86b4a058a85c.diff L

[clang] 34f1439 - [clang][deps] NFC: Don't collect PCH input files

Author: Jan Svoboda Date: 2023-04-05T12:29:03-07:00 New Revision: 34f143988f3f18dcca6d26a7a9817d8523300440 URL: https://github.com/llvm/llvm-project/commit/34f143988f3f18dcca6d26a7a9817d8523300440 DIFF: https://github.com/llvm/llvm-project/commit/34f143988f3f18dcca6d26a7a9817d8523300440.diff L

[PATCH] D146376: Update static_assert message for redundant cases

Krishna-13-cyber updated this revision to Diff 511181. Krishna-13-cyber added a comment. - Updated with the diagnostic messages (comments for test cases) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146376/new/ https://reviews.llvm.org/D146376 Fi

[clang] 385bcc6 - Revert "[clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR."

Author: Francesco Petrogalli Date: 2023-04-05T20:55:08+02:00 New Revision: 385bcc65ff44d9860572ee85adb5df1333860a05 URL: https://github.com/llvm/llvm-project/commit/385bcc65ff44d9860572ee85adb5df1333860a05 DIFF: https://github.com/llvm/llvm-project/commit/385bcc65ff44d9860572ee85adb5df1333860a0

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

vaibhav.y added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule = SarifRule::create().setR

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

fpetrogalli added a comment. In D147209#4246622 , @leonardchan wrote: > In D147209#4245229 , @fpetrogalli > wrote: > >> In D147209#4244615 , @leonardchan >> wrote: >> >

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

zequanwu added a comment. Added the missing release note at rG5bab9097ce5b093289e8d40809d02f002febe910 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147569/new/ https://reviews

[clang] 5bab909 - Add release note for D147569.

Author: Zequan Wu Date: 2023-04-05T14:43:52-04:00 New Revision: 5bab9097ce5b093289e8d40809d02f002febe910 URL: https://github.com/llvm/llvm-project/commit/5bab9097ce5b093289e8d40809d02f002febe910 DIFF: https://github.com/llvm/llvm-project/commit/5bab9097ce5b093289e8d40809d02f002febe910.diff LOG

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e93bd417445: [Coverage] Fix crash when visiting PseudoObjectExpr. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 4e93bd4 - [Coverage] Fix crash when visiting PseudoObjectExpr.

Author: Zequan Wu Date: 2023-04-05T14:37:41-04:00 New Revision: 4e93bd4174454c7c70b8f2fa7512e2f97681f295 URL: https://github.com/llvm/llvm-project/commit/4e93bd4174454c7c70b8f2fa7512e2f97681f295 DIFF: https://github.com/llvm/llvm-project/commit/4e93bd4174454c7c70b8f2fa7512e2f97681f295.diff LOG

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

leonardchan added a comment. In D147209#4245229 , @fpetrogalli wrote: > In D147209#4244615 , @leonardchan > wrote: > >> Hi. I think this led to some test failures on our builder at >> https://luci-milo.appspot.

[PATCH] D147569: [Coverage] Fix crash when visiting PseudoObjectExpr.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you, this looks much better to me! LGTM, but please add a release note about the fix when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D144651: [Serialization] Place command line defines in the correct file

john.brawn updated this revision to Diff 511153. john.brawn edited the summary of this revision. john.brawn added a comment. New version that checks for special filenames in ResolveImportedPath. I spent a while trying to come up with a test using just clang where not doing this fails, but couldn

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

This revision was automatically updated to reflect the committed changes. Closed by commit rG53152f12a47b: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate… (authored by agozillon). Changed prior to commit: https://reviews.llvm.org/D147324?vs=510080&id=511154#toc R

[clang] 53152f1 - [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

Author: Andrew Gozillon Date: 2023-04-05T12:50:32-05:00 New Revision: 53152f12a47bf6e97f1f2f2d6b71e7b4d4e3740a URL: https://github.com/llvm/llvm-project/commit/53152f12a47bf6e97f1f2f2d6b71e7b4d4e3740a DIFF: https://github.com/llvm/llvm-project/commit/53152f12a47bf6e97f1f2f2d6b71e7b4d4e3740a.dif

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

aaron.ballman added a comment. Ah, I like this approach -- it keeps things roughly in sync with checking for unique object representations, which is great. I spotted a few questions, but in general this is heading in the right direction. You should also add a release note to clang/docs/ReleaseN

[PATCH] D147623: [MSVC] Allow declaration of multi-dim 'property' array fields

mikerice closed this revision. mikerice added a comment. 57caadc57a30f2279099e5b86bb555b4aab621ce CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147623/new/ https://reviews.llvm.org/D147623 __

[clang] 57caadc - [MSVC] Allow declaration of multi-dim 'property' array fields

Author: Mike Rice Date: 2023-04-05T10:29:37-07:00 New Revision: 57caadc57a30f2279099e5b86bb555b4aab621ce URL: https://github.com/llvm/llvm-project/commit/57caadc57a30f2279099e5b86bb555b4aab621ce DIFF: https://github.com/llvm/llvm-project/commit/57caadc57a30f2279099e5b86bb555b4aab621ce.diff LOG

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon added a comment. In D147324#4245932 , @kiranchandramohan wrote: > LG. This portion of the patch was accepted in > https://reviews.llvm.org/D145264. > > See inline comment about location of LLVM Dialect tests. You may either > remove the LLVM

[clang] 78d0d59 - Add some additional comments to this test; NFC

Author: Aaron Ballman Date: 2023-04-05T13:15:34-04:00 New Revision: 78d0d59209bf858435bcd19046e94fce0386ace8 URL: https://github.com/llvm/llvm-project/commit/78d0d59209bf858435bcd19046e94fce0386ace8 DIFF: https://github.com/llvm/llvm-project/commit/78d0d59209bf858435bcd19046e94fce0386ace8.diff

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

probinson added a comment. An LLVM code change should be testable on its own; this has it tested by Clang. I think you need a new command-line option to set TargetOptions::UseTargetPathSeparator e.g. via llvm-mc. Other TargetOptions are handled this way. Repository: rG LLVM Github Monorepo

[PATCH] D147623: [MSVC] Allow declaration of multi-dim 'property' array fields

aaron.ballman accepted this revision. aaron.ballman added a comment. Changes LGTM but please add a release note about the new functionality when landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147623/new/ https://reviews.llvm.org/D147623

[PATCH] D147623: [MSVC] Allow declaration of multi-dim 'property' array fields

erichkeane added a comment. Ah, needs a release note however! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147623/new/ https://reviews.llvm.org/D147623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:808 unsigned NumElems = numStructUnionElements(ILE->getType()); - if (RDecl->hasFlexibleArrayMember()) + if (!RDecl->isUnion() && RDecl->hasFlexibleArrayMember()) ++NumElems; --

[PATCH] D146376: Update static_assert message for redundant cases

aaron.ballman added a comment. In D146376#4244355 , @Krishna-13-cyber wrote: > - Updated with release note > - I had tried adding more text to the `expected-error` but it already gives a > diagnostic of `static assertion failed due to requirement` curre

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. In D147574#4246004 , @aaron.ballman wrote: > LGTM Thank you @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147574/new/ https://reviews.llvm.org/D147574 _

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:91-92 expressions and how their types are deduced therein, in all C++ language versions. +- Implemented partial support for `P2448R2: Relaxing some constexpr restrictions

[libunwind] d080b5f - [libunwind] Fix a case of inconsistent indentation. NFC.

Author: Martin Storsjö Date: 2023-04-05T19:23:18+03:00 New Revision: d080b5f1737b4040aa74a5614ae01338f28cd714 URL: https://github.com/llvm/llvm-project/commit/d080b5f1737b4040aa74a5614ae01338f28cd714 DIFF: https://github.com/llvm/llvm-project/commit/d080b5f1737b4040aa74a5614ae01338f28cd714.diff

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 511126. sammccall marked 8 inline comments as done. sammccall added a comment. address comments (sorry about long turnaround!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.or

[PATCH] D147626: [clang] Do not crash when initializing union with flexible array member

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Due to missing check on union, there was a null expression added to init list that caused crash later. Fixes https://gi

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal added a comment. I think as we converge, now it could be time to update the summary of the patch to reflect the current implementation. (e.g. flowids etc.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144269/new/ https://reviews.llvm.org/D144269 _

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

steakhal added a comment. Looks even better. Only minor concerns remained, mostly about style and suggestions of llvm utilities. Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:129-130 /// Given a pointer/reference argument, return the value it refers to

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

zequanwu updated this revision to Diff 58. zequanwu added a comment. Herald added a subscriber: ormris. - Pass `LangOptions.UseTargetPathSeparator` down to TargetOptions to use host path separator when it's set. - Add a test case. The problem is when if we are targeting to linux, clang won'

[PATCH] D147621: [clang][Interp] Start handling mutable record members

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147574/new/ https://reviews.llvm.org/D147574 ___ cfe-commits mailing list cfe-commi

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. TODO: Fix review comments, rename check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144036/new/ https://reviews.llvm.org/D144036 __

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

PiotrZSL added a comment. Thank you for review, I will correct comments in this week. Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:107 +CheckFactories.registerCheck( +"bugprone-enum-to-bool-conversion"); CheckFactories.registerCheck(

[PATCH] D144036: [clang-tidy] Add bugprone-enum-to-bool-conversion check

carlosgalvezp added a comment. Such a great check, thanks! I have very minor comments, the most debatable one about the name of the check (but no strong opinion). Comment at: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp:107 +CheckFactories.registerCheck( +

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LG. This portion of the patch was accepted in https://reviews.llvm.org/D145264. See inline comment about location of LLVM Dialect tests. You may either remove the LLVM di

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. In D147574#4245881 , @erichkeane wrote: > In D147574#4245877 , @Manna wrote: > >> Thanks @erichkeane. >> >> Is this known failure? >> >> Failed Tests (1): >> >> Clang :: >> SemaCXX/warn-

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

jp4a50 updated this revision to Diff 511098. jp4a50 added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146042/new/ https://reviews.llvm.org/D146042 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseN

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

erichkeane added a comment. In D147574#4245877 , @Manna wrote: > Thanks @erichkeane. > > Is this known failure? > > Failed Tests (1): > > Clang :: > SemaCXX/warn-unsafe-buffer-usage-fixits-addressof-arraysubscript.cpp > > https://buildkite.com/llvm-pro

[PATCH] D147324: [OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them

agozillon added a comment. Hi @awarzynski would it please be possible to get this reviewed when you have a spare moment or few, it's essentially the segment of the modifications from this patch which you accepted: https://reviews.llvm.org/D145264 the lowering has been separated into a different

[PATCH] D147574: [NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Manna added a comment. Thanks @erichkeane. Is this known failure? Failed Tests (1): Clang :: SemaCXX/warn-unsafe-buffer-usage-fixits-addressof-arraysubscript.cpp https://buildkite.com/llvm-project/premerge-checks/builds/145026#01874e21-00e2-47a9-9bc4-975357d197ef Repository: rG LLVM Gith

[PATCH] D147615: [clang][Sema][NFC] Save token name instead of the full token

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes it a bit clearer why we're saving the token (so no need for the later c

[PATCH] D147561: [clang] don't serialize MODULE_DIRECTORY with ModuleFileHomeIsCwd

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ee5029b225b: [clang] don't serialize MODULE_DIRECTORY with ModuleFileHomeIsCwd (authored by rmaz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147561/new/

[clang] 8ee5029 - [clang] don't serialize MODULE_DIRECTORY with ModuleFileHomeIsCwd

Author: Richard Howell Date: 2023-04-05T07:19:48-07:00 New Revision: 8ee5029b225ba1ff415e0a0a6a68dc4e3efee4d1 URL: https://github.com/llvm/llvm-project/commit/8ee5029b225ba1ff415e0a0a6a68dc4e3efee4d1 DIFF: https://github.com/llvm/llvm-project/commit/8ee5029b225ba1ff415e0a0a6a68dc4e3efee4d1.diff

[PATCH] D146873: [2/N][POC][Clang][RISCV] Define RVV tuple types

eopXD updated this revision to Diff 511093. eopXD added a comment. Rebase upon change of parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146873/new/ https://reviews.llvm.org/D146873 Files: clang/include/clang/Basic/RISCVVTypes.def

  1   2   >