[PATCH] D132285: [LoongArch] Implement ABI lowering

SixWeining updated this revision to Diff 454705. SixWeining added a comment. Add a test for struct with zero size arrays. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132285/new/ https://reviews.llvm.org/D132285 Files: clang/lib/Basic/Targets/L

[PATCH] D132285: [LoongArch] Implement ABI lowering

SixWeining added a comment. In D132285#3739568 , @xry111 wrote: > In D132285#3737855 , @SixWeining > wrote: > >> Ignore zero-width bit fields and add a test. > > Thanks! There is a GCC test (https://gcc.gnu.or

[PATCH] D132434: Add noread_thread_id attribute to intrinsics

ChuanqiXu created this revision. ChuanqiXu added reviewers: nhaehnle, jyknight, nikic, rjmccall, efriedma, fhahn, ychen, jdoerfert. ChuanqiXu added a project: clang. Herald added subscribers: jeroen.dobbelaere, wenlei, okura, kuter, arichardson. Herald added a project: All. ChuanqiXu requested rev

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

This revision was automatically updated to reflect the committed changes. Closed by commit rG15b65bcd6519: [Clang][LoongArch] Add initial LoongArch target and driver support (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1302

[clang] 15b65bc - [Clang][LoongArch] Add initial LoongArch target and driver support

Author: Weining Lu Date: 2022-08-23T13:47:22+08:00 New Revision: 15b65bcd65195df8c9c0e84b64a1a825d9901ba6 URL: https://github.com/llvm/llvm-project/commit/15b65bcd65195df8c9c0e84b64a1a825d9901ba6 DIFF: https://github.com/llvm/llvm-project/commit/15b65bcd65195df8c9c0e84b64a1a825d9901ba6.diff LO

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu updated this revision to Diff 454697. ChuanqiXu added a comment. I post the incorrect version the last time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132352/new/ https://reviews.llvm.org/D132352 Files: llvm/docs/LangRef.rst llvm/include/llvm/Bitcode/LLVMBitCodes.h

[PATCH] D132286: [clang][Interp] Implement function calls

tbaeder marked 4 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:614 + +if (Optional T = classify(E->getType())) { + // Put arguments on the stack. aaron.ballman wrote: > Should this be using `

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu updated this revision to Diff 454696. ChuanqiXu marked 3 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132352/new/ https://reviews.llvm.org/D132352 Files: llvm/docs/LangRef.rst llvm/include/llvm/Bitcode

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

CarlosAlbertoEnciso added a comment. In D131665#3740037 , @phosek wrote: > LGTM @phosek Thanks for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://reviews.llvm.org/D131665

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c6c4f6a9b3e: [CMake] Support passing arguments to build tool (bootstrap). (authored by CarlosAlbertoEnciso). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[clang] 6c6c4f6 - [CMake] Support passing arguments to build tool (bootstrap).

Author: Carlos Alberto Enciso Date: 2022-08-23T05:45:25+01:00 New Revision: 6c6c4f6a9b3ef2d7db937cb78784245ea8a61418 URL: https://github.com/llvm/llvm-project/commit/6c6c4f6a9b3ef2d7db937cb78784245ea8a61418 DIFF: https://github.com/llvm/llvm-project/commit/6c6c4f6a9b3ef2d7db937cb78784245ea8a614

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda marked 2 inline comments as done. arda added inline comments. Comment at: lld/ELF/InputFiles.cpp:1721 +Expected fatLTOData = IRObjectFile::findBitcodeInMemBuffer(mb); +if (!errorToBool(fatLTOData.takeError())) + return make(*fatLTOData, archiveName, offsetInArc

[PATCH] D132001: [clang-format] Fix regressions in WhitespaceSensitiveMacros

owenpan added a comment. In D132001#3741467 , @kuhar wrote: > This seems to have caused a test failure: > https://lab.llvm.org/buildbot/#/builders/109/builds/45138 > > Failed Tests (1): > Clang-Unit :: > Format/./FormatTests/TokenAnnotatorTest/Unde

[PATCH] D132001: [clang-format] Fix regressions in WhitespaceSensitiveMacros

kuhar added a comment. This seems to have caused a test failure: https://lab.llvm.org/buildbot/#/builders/109/builds/45138 Failed Tests (1): Clang-Unit :: Format/./FormatTests/TokenAnnotatorTest/UnderstandsLBracesInMacroDefinition Testing Time: 92.30s Skipped :38 Uns

[clang] 47e7056 - [clang-format] Remove an extraneous test in TokenAnnotatorTest.cpp

Author: owenca Date: 2022-08-22T21:18:37-07:00 New Revision: 47e70569fc356c3dc1fbc444a55975dac586ce73 URL: https://github.com/llvm/llvm-project/commit/47e70569fc356c3dc1fbc444a55975dac586ce73 DIFF: https://github.com/llvm/llvm-project/commit/47e70569fc356c3dc1fbc444a55975dac586ce73.diff LOG: [

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

rjmccall added a comment. Okay. Doc parts LGTM, but I don't Comment at: llvm/include/llvm/IR/InstrTypes.h:1855 + } + void setNoReadThreadID() { addFnAttr(Attribute::NoReadThreadID); } + The closest existing precedent would suggest `doesNotReadThreadID` and

[PATCH] D132001: [clang-format] Fix regressions in WhitespaceSensitiveMacros

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e36120726ee: [clang-format] Fix regressions in WhitespaceSensitiveMacros (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D132001?vs=453161&id=454685#toc Repository: rG LLVM

[clang] 2e36120 - [clang-format] Fix regressions in WhitespaceSensitiveMacros

Author: owenca Date: 2022-08-22T20:42:54-07:00 New Revision: 2e36120726ee46cbfd3eee1e9244bdd756dee92d URL: https://github.com/llvm/llvm-project/commit/2e36120726ee46cbfd3eee1e9244bdd756dee92d DIFF: https://github.com/llvm/llvm-project/commit/2e36120726ee46cbfd3eee1e9244bdd756dee92d.diff LOG: [

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

ChuanqiXu updated this revision to Diff 454683. ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Address comments: - Edit LangRef.rst. - Split the add-the-attributes part in later revisions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132352/new/ https://revi

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

pengfei added a comment. Thanks @RKSimon Comment at: clang/lib/Headers/immintrin.h:223 +#if !(defined(_MSC_VER) || defined(__SCE__)) || __has_feature(modules) || \ +(defined(__AVX512VL__) && defined(__AVX512FP16__)) #include RKSimon wrote: > (style)

[PATCH] D132342: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08388ad81e9d: [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGE

[clang] 08388ad - [X86][AVX512FP16] Relax limitation to AVX512FP16 intrinsics. NFCI

Author: Phoebe Wang Date: 2022-08-23T11:35:16+08:00 New Revision: 08388ad81e9d65116b0857b0ebc9bcf7f2be5e31 URL: https://github.com/llvm/llvm-project/commit/08388ad81e9d65116b0857b0ebc9bcf7f2be5e31 DIFF: https://github.com/llvm/llvm-project/commit/08388ad81e9d65116b0857b0ebc9bcf7f2be5e31.diff L

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

ChuanqiXu added a reviewer: dblaikie. ChuanqiXu added a comment. LGTM. But I am not familiar with debugger internals. So I'll leave the formal acceptance for other reviewers. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:138 +} \ No newline at end of file

[PATCH] D131625: [HLSL] Entry functions require param annotation

beanz added inline comments. Comment at: clang/include/clang/AST/Attr.h:193 +class HLSLAnnotationAttr : public InheritableAttr { +protected: aaron.ballman wrote: > beanz wrote: > > aaron.ballman wrote: > > > Is this intended to be used only for parameters (that

[PATCH] D131203: [HLSL] Initial codegen for SV_GroupIndex

beanz updated this revision to Diff 454677. beanz added a comment. Updates based on review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131203/new/ https://reviews.llvm.org/D131203 Files: clang/lib/AST/Mangle.cpp clang/lib/CodeGen/C

[PATCH] D131625: [HLSL] Entry functions require param annotation

beanz updated this revision to Diff 454676. beanz added a comment. Updating based on PR feedback from @Aaron.ballman. I changed around the diagnostics so that the error is on the function decl with a note pointing at the parameter declaration. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:207 +// CHECK-NEXT:[[EXT:%.*]] = fpext half [[TMP0]] to float +// CHECK-NEXT:store float [[EXT]], ptr [[RETVAL]], align 2 +// CHECK-NEXT:[[TMP1:%.*]] = load half, ptr [[RETVAL]], a

[PATCH] D132430: [clang][modules] Track affecting modules

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When compiling a module, its semantics and Clang's behavior

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:207 +// CHECK-NEXT:[[EXT:%.*]] = fpext half [[TMP0]] to float +// CHECK-NEXT:store float [[EXT]], ptr [[RETVAL]], align 2 +// CHECK-NEXT:[[TMP1:%.*]] = load half, ptr [[RETVAL]], al

[clang] be795ee - [clang][deps] Allow switching between lazily/eagerly loaded PCMs

Author: Jan Svoboda Date: 2022-08-22T18:22:27-07:00 New Revision: be795ee16a7f8dba9210c26efaa6f75dc8608e1d URL: https://github.com/llvm/llvm-project/commit/be795ee16a7f8dba9210c26efaa6f75dc8608e1d DIFF: https://github.com/llvm/llvm-project/commit/be795ee16a7f8dba9210c26efaa6f75dc8608e1d.diff L

[PATCH] D132066: [clang][deps] Allow switching between lazily/eagerly loaded PCMs

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe795ee16a7f: [clang][deps] Allow switching between lazily/eagerly loaded PCMs (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1320

[PATCH] D132421: [NFC] [HLSL] Add HLSLExternalSemaSource as ExternalSemaSource instead of ASTContext::ExternalSource.

beanz added a comment. This change doesn't look like it is NFC to me. If I'm understanding correctly it results in the HLSLExternalSemaSource being set for Sema, but allows a different external source to be set for the AST context. That doesn't seem unreasonable to me, but perhaps we should hav

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan created this revision. leonardchan added reviewers: mcgrathr, eugenis, phosek, vitalybuka. leonardchan added a project: clang. Herald added subscribers: abrachet, kristof.beyls. Herald added a project: All. leonardchan requested review of this revision. Full context in https://bugs.fuc

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

glandium added a comment. FWIW, it also broke compiler-rt standalone builds: CMake Error at lib/builtins/CMakeLists.txt:702 (add_security_warnings): Unknown CMake command "add_security_warnings". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D132186: Clang: Add a new flag Wmisnoinline for printing hot noinline functions

paulkirth added a comment. Hi, thanks for taking a look at this. Before we start an in-depth review, can you describe the deficiencies w/ the existing diagnostics, and why they don't meet your needs? Primarily, I'm a little skeptical if taking the same approach as MisExpect is the correct appr

[PATCH] D132421: [NFC] [HLSL] Add HLSLExternalSemaSource as ExternalSemaSource instead of ASTContext::ExternalSource.

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use CompilerInstance::set

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd added inline comments. Comment at: clang/include/clang/Frontend/SARIFDiagnosticPrinter.h:63-65 + void setSarifWriter(SarifDocumentWriter *SarifWriter) { +Writer = std::unique_ptr(SarifWriter); + } aaron.ballman wrote: > This interface seems danger

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 454652. abrahamcd marked 26 inline comments as done. abrahamcd added a comment. Addressed review comments on formatting, style, C++ best practices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ ht

[PATCH] D132209: [Clang][OpenMP] Make copyin clause on combined and composite construct work

ABataev added a comment. In D132209#3741110 , @yutsumi wrote: > @ABataev , could you please commit this patch because I don't have commit > access yet? > My git user name and email address: Yuichiro Utsumi > (utsumi.yuich...@fujitsu.com) > > Thank you f

[PATCH] D132209: [Clang][OpenMP] Make copyin clause on combined and composite construct work

yutsumi added a comment. @ABataev , could you please commit this patch because I don't have commit access yet? My git user name and email address: Yuichiro Utsumi (utsumi.yuich...@fujitsu.com) Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9436 +CGM.getModule(), Type, true, +llvm::GlobalValue::LinkageTypes::LinkOnceODRLinkage, +llvm::ConstantInt::get(Type, Value), Name, nullptr, This does not support

[PATCH] D131714: [compiler-rt][builtins] Add compiler flags to catch potential errors that can lead to security vulnerabilities

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f886adbfd7c: [compiler-rt][builtins] Add compiler flags to catch potential errors (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1317

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

klausler added a comment. I can't speak to the lowering or driver bits, but the runtime part looks pretty good to me. Comment at: flang/runtime/environment-default-list.h:1 +//===-- Runtime/environment-default-list.h ===// +//

Re: [clang] acaf6b9 - [NFC] Add [[maybe_unused]] to avoid warning in gcc9

Seems like a bug in the GCC9 warning - any chance we can disable it? (is it fixed in later versions of GCC?) I can't seem to reproduce this with godbolt at least with basic examples - it'd be good to know how bad the thing is we're working around so we know if we want to keep working around it, or

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added a comment. e137fb6fb85 should fix this issue. Thanks for your patience! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203 _

[clang] e137fb6 - [clang][libcxx] renames `__remove_reference`

Author: Christopher Di Bella Date: 2022-08-22T23:15:10Z New Revision: e137fb6fb85b41978814e64eae652d05688bcca5 URL: https://github.com/llvm/llvm-project/commit/e137fb6fb85b41978814e64eae652d05688bcca5 DIFF: https://github.com/llvm/llvm-project/commit/e137fb6fb85b41978814e64eae652d05688bcca5.dif

[PATCH] D132419: [clang] Pull some utility functions into CompilerInvocation NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGMT! Nice cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132419/new/ https://reviews.llvm.org/D132419

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic added a comment. @klausler Could you please take a look at this again and let me know if it is more in line with your suggestion above? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D130513 __

[clang] f9969a3 - [CodeGen] Sort llvm.global_ctors by lexing order before emission

Author: Yuanfang Chen Date: 2022-08-22T16:00:14-07:00 New Revision: f9969a3d28e738e9427e371aac06d71269220123 URL: https://github.com/llvm/llvm-project/commit/f9969a3d28e738e9427e371aac06d71269220123 DIFF: https://github.com/llvm/llvm-project/commit/f9969a3d28e738e9427e371aac06d71269220123.diff

[PATCH] D127233: [CodeGen] Sort llvm.global_ctors by lexing order before emission

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9969a3d28e7: [CodeGen] Sort llvm.global_ctors by lexing order before emission (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127233/new/

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen added a comment. I'll land this tomorrow if no objections. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 ___ cfe-commits mailing list cfe-commit

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningWorker.h:102 +std::vector +serializeCompilerInvocation(const CompilerInvocation &CI); + jansvoboda11 wrote: > Maybe we could add this API directly to

[PATCH] D132419: [clang] Pull some utility functions into CompilerInvocation NFC

benlangmuir created this revision. benlangmuir added a reviewer: jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move copying compiler arguments to a vector and modifying common module-

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:1139 + AddCXXSynthetic( // XXX + cpp_category_sp, I need to remove this. This is a left-over from an earlier implementation sketch Repository:

[PATCH] D128372: [Clang-Tidy] Empty Check

abrahamcd updated this revision to Diff 454635. abrahamcd marked 2 inline comments as done. abrahamcd added a comment. Formatting fixes and synchronization of documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f6cb3e9fdb4: [AMDGPU] Add builtin s_sendmsg_rtn (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/ne

[clang] 9f6cb3e - [AMDGPU] Add builtin s_sendmsg_rtn

Author: Yaxun (Sam) Liu Date: 2022-08-22T18:29:23-04:00 New Revision: 9f6cb3e9fdb4f5255f78d77c0a537dc3cb50dc9d URL: https://github.com/llvm/llvm-project/commit/9f6cb3e9fdb4f5255f78d77c0a537dc3cb50dc9d DIFF: https://github.com/llvm/llvm-project/commit/9f6cb3e9fdb4f5255f78d77c0a537dc3cb50dc9d.dif

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 updated this revision to Diff 454632. pfultz2 added a comment. Updated to diagnose `return` statements as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570 Files: clang-tools-extra/clang-tid

[PATCH] D132275: [clang] Create alloca to pass into static lambda

vitalybuka updated this revision to Diff 454629. vitalybuka added a comment. new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132275/new/ https://reviews.llvm.org/D132275 Files: clang/lib/CodeGen/CGClass.cpp clang/test/CodeGenCXX/lambda-

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

dschuff added a comment. This broke us in emscripten as well (building with trunk clang against a recent-but-not-trunk version of libcxx). I can test the fix if you want. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.ll

[PATCH] D132275: [clang] Create alloca to pass into static lambda

vitalybuka updated this revision to Diff 454628. vitalybuka added a comment. created alloca instead of changing attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132275/new/ https://reviews.llvm.org/D132275 Files: clang/lib/CodeGen/CGClas

[PATCH] D132275: [clang] Reset some attributed calling lambda

vitalybuka added a comment. In D132275#3740822 , @efriedma wrote: > In D132275#3740802 , @vitalybuka > wrote: > >> In D132275#3740479 , @efriedma >> wrote: >> >>> Among

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang created this revision. avogelsgesang added reviewers: ChuanqiXu, aprantl, labath, mib, JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: All. avogelsgesang requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-comm

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

fdeazeve added a comment. In D116203#3740843 , @cjdb wrote: > I think there's a forward fix available, but since I can't repro locally, I'm > going to need to push it to main and observe how the tools fare. I need to be AFK for a bit now, but I can test

[PATCH] D132414: [Clang] follow-up D128745, use ClangABICompat15 instead of ClangABICompat14 Since the patch missed release 15.x and will be included in release 16.x.

ychen created this revision. ychen added reviewers: aaron.ballman, royjacobson. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also, simplify related tests. Repository: rG LLVM Github Monorepo https:

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added a comment. I think there's a forward fix available, but since I can't repro locally, I'm going to need to push it to main and observe how the tools fare. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org

[PATCH] D131683: Diagnosing the Future Keywords

erichkeane added a comment. Looks about right, please see if you can do more work on the static-assert test to make sure we don't lose other testing behavior, AND see the other comment. Comment at: clang/lib/Lex/Preprocessor.cpp:847 if (II.isFutureCompatKeyword() && !Disabl

[PATCH] D132275: [clang] Reset some attributed calling lambda

efriedma added a comment. In D132275#3740802 , @vitalybuka wrote: > In D132275#3740479 , @efriedma > wrote: > >> Among other things, we could use a definition from a different module. > > Is this a thing, I assu

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 454612. Codesbyusman marked 5 inline comments as done. Codesbyusman added a comment. updated with suggestios Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683 File

[PATCH] D132275: [clang] Reset some attributed calling lambda

vitalybuka added a comment. In D132275#3740479 , @efriedma wrote: > Among other things, we could use a definition from a different module. Is this a thing, I assumed lambda is always defined in the module? > Either we relax the requirements globally for

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

yaxunl updated this revision to Diff 454607. yaxunl added a comment. remove unnecessary tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/new/ https://reviews.llvm.org/D132140 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/CodeGen/CGBuiltin.cpp clang/test/

[clang] 9a478d5 - [NFC] Rename dx.shader to hlsl.shader

Author: Chris Bieneman Date: 2022-08-22T16:03:40-05:00 New Revision: 9a478d523239fe0d01f32ecc8e64e88d1809fd8e URL: https://github.com/llvm/llvm-project/commit/9a478d523239fe0d01f32ecc8e64e88d1809fd8e DIFF: https://github.com/llvm/llvm-project/commit/9a478d523239fe0d01f32ecc8e64e88d1809fd8e.diff

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

paulkirth added a comment. I think the test strategy here needs to be: - Format checking -. llvm generates the correct object file sections when configured for fatlto 1. clang generates fatlto objects correctly (i.e. correctly sets up the codegen pipeline in llvm) Comment a

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2260 Result.addFnAttr(llvm::Attribute::ReadNone); -else if (ReadOnly) + Result.addFnAttr(llvm::Attribute::NoReadThreadID); +} else if (ReadOnly) Hmm, my comment here got

[PATCH] D132352: Introduce noread_thread_id to address the thread identification problem in coroutines

rjmccall added inline comments. Comment at: llvm/docs/LangRef.rst:1931 +This attribute indicates that the function does not read thread id. +The behavior of noread_thread_id shouldn't depend on the thread it lives in. + Suggestion: > This attribute indi

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:34 +/// \see FullDependencies::Commands. +class Command { +public: jansvoboda11 wrote: > Have you considered using the `Job`/`Command` classes

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

alecto added a comment. If possible I would like to error out if MaxEmptyLinesToKeep < DefinitionBlockSpacing, because that case is probably a mistake on the part of the user, and a failure would be better than clang-format silently doing something unexpected, but I'm not sure where to put the

[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Ericson2314 added a comment. https://reviews.llvm.org/D132411 should fix the issue @aaron.ballman mentioned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132324/new/ https://reviews.llvm.org/D132324 ___

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

HazardyKnusperkeks added a comment. In D132256#3738407 , @alecto wrote: > In D132256#3736076 , > @HazardyKnusperkeks wrote: > >> Do we want to define the behavior of `MaxEmptyLinesToKeep < >> DefinitionBlockSpac

[clang] 0bf525b - [clang-cl] Add _M_FP_* #defines for floating point modes

Author: David Majnemer Date: 2022-08-22T20:04:35Z New Revision: 0bf525bf902e3cd2072ddac82069f28e6d01fdc5 URL: https://github.com/llvm/llvm-project/commit/0bf525bf902e3cd2072ddac82069f28e6d01fdc5 DIFF: https://github.com/llvm/llvm-project/commit/0bf525bf902e3cd2072ddac82069f28e6d01fdc5.diff LOG

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:34 +/// \see FullDependencies::Commands. +class Command { +public: Have you considered using the `Job`/`Command` classes the driver uses? What

[PATCH] D131217: [clang][WebAssembly] Pass `-Wl,-no-type-check` through to the MC layer

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. This looks good to me from the wasm perspective Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131217/new/ https://reviews.llvm.org/D131217 __

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

denik added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnosticPrinter.cpp:71 + // other infrastructure necessary when emitting more rich diagnostics. + if (!Info.getLocation().isValid()) { // TODO: What is this case? +// SARIFDiag->addDiagnosticWithoutLocation

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:207 +// CHECK-NEXT:[[EXT:%.*]] = fpext half [[TMP0]] to float +// CHECK-NEXT:store float [[EXT]], ptr [[RETVAL]], align 2 +// CHECK-NEXT:[[TMP1:%.*]] = load half, ptr [[RETVAL]], a

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:78 +emitFilename(FE->getName(), Loc.getManager()); +// FIXME: No current way to add file-only location to SARIF object + } cjdb wrote: > I think it wo

[clang] 5d79455 - [Sema][ObjC] Don't warn about implicitly-retained self in an unevaluated

Author: Akira Hatanaka Date: 2022-08-22T12:16:37-07:00 New Revision: 5d794552bc0c15bbe9852080e60bcecead09302f URL: https://github.com/llvm/llvm-project/commit/5d794552bc0c15bbe9852080e60bcecead09302f DIFF: https://github.com/llvm/llvm-project/commit/5d794552bc0c15bbe9852080e60bcecead09302f.diff

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. I get that libcxx doesn't run on precommit CI (which is unfortunate for those of us modifying the CFE), but it becomes difficult to run locally, when check-all (requires check-runtimes or check-cxx) don't cover it, and now even check-cxx doesn't cover it. >> What do

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

yaxunl added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-gfx11.cl:23 + +// Test mismatched argument and return types are handled. + tra wrote: > Is there a particular reason for this test? > > Argument and return value type checks shoul

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a comment. In D126907#3739923 , @aaron.ballman wrote: > In D126907#3739750 , @Mordante > wrote: > >> In D126907#3738383 , @erichkeane >> wrote: >> >>> Th

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

tschuett added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:44 + + enum CommandKind { +CK_CC1, Why is this not an enum class? Comment at: clang/include/clang/Tooling/DependencyScann

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir added inline comments. Herald added a subscriber: ormris. Comment at: clang/test/ClangScanDeps/diagnostics.c:31 // CHECK-NEXT: { -// CHECK-NEXT: "clang-context-hash": "[[HASH_TU:.*]], +// CHECK:"clang-context-hash": "[[HASH_TU:.*]], // CHECK-NE

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda added inline comments. Comment at: lld/test/ELF/fatlto/fatlto.test:4-6 +; clang -c -ffat-lto-objects -o a-fatLTO.o a.c +; clang -c -ffat-lto-objects -o main-fatLTO.o main.c +; clang -c a.c main.c phosek wrote: > LLD tests cannot depend on `clang`, that's a l

[PATCH] D131618: [WIP][Do NOT review] LLD related changes for -ffat-lto-objects support

arda updated this revision to Diff 454585. arda marked 9 inline comments as done. arda added a comment. Herald added a subscriber: mgorny. Reimplement embed-bitcode part as a separate pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131618/new/ h

[PATCH] D131796: [clang][deps] Use a cc1 invocation in FullDependencies::getCommandLine()

benlangmuir abandoned this revision. benlangmuir added a comment. Closing in favour of https://reviews.llvm.org/D132405 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131796/new/ https://reviews.llvm.org/D131796

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of trying to "fix" the original driver invocation by a

[clang] 3d89323 - [clang-cl] Increase /fp flag fidelity

Author: David Majnemer Date: 2022-08-22T18:32:58Z New Revision: 3d89323d1896fde5dc69ecb8306917718c5e3aed URL: https://github.com/llvm/llvm-project/commit/3d89323d1896fde5dc69ecb8306917718c5e3aed DIFF: https://github.com/llvm/llvm-project/commit/3d89323d1896fde5dc69ecb8306917718c5e3aed.diff LOG

[PATCH] D132275: [clang] Reset some attributed calling lambda

efriedma added a comment. Given that we mark up lambdas with the requirement that the pointer is nonnull/noundef/dereferenceable, we can't fix that by just messing with the attributes. Among other things, we could use a definition from a different module. Either we relax the requirements glob

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

tra added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-gfx11.cl:23 + +// Test mismatched argument and return types are handled. + Is there a particular reason for this test? Argument and return value type checks should've been handled by

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I would wait for @aaron.ballman or @erichkeane to sign off on it, but this looks good to me. Thanks again for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

royjacobson updated this revision to Diff 454577. royjacobson added a comment. Clarify ambiguous doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128619/new/ https://reviews.llvm.org/D128619 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/D

  1   2   3   >