erichkeane added a comment.

I get that libcxx doesn't run on precommit CI (which is unfortunate for those 
of us modifying the CFE), but it becomes difficult to run locally, when 
check-all (requires check-runtimes or check-cxx) don't cover it, and now even 
check-cxx doesn't cover it.

>> What do you exactly mean with "test all the libcxx things" flag?

For example, this enable-modules flag isn't covered by my local check-cxx, 
which I went out of my way to run on this patch locally.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to